From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.54419.1688460737553852459 for ; Tue, 04 Jul 2023 01:52:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12A502F4; Tue, 4 Jul 2023 01:52:59 -0700 (PDT) Received: from e126645.arm.com (e126645.nice.arm.com [10.34.100.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2B69A3F73F; Tue, 4 Jul 2023 01:52:15 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Jiewen Yao , Jian J Wang , Ard Biesheuvel , Sami Mujawar , Jose Marinho , Kun Qin Subject: [PATCH v2 0/6] SecurityPkg/MdePkg: Update RngLib GUID identification Date: Tue, 4 Jul 2023 10:51:55 +0200 Message-Id: <20230704085201.260801-1-pierre.gondois@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Pierre Gondois v2: [1/8] MdePkg/ArmTrngLib: Remove ASSERTs in Null implementation - Dropped [2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg - Change gEfiMdePkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm token number - Rename to SecurityPkg/SecurityPkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg [5/8] MdePkg/Rng: Add GetRngGuid() to RngLib - Remove gEfiRngAlgorithmUnSafe from inf file - Split Guids definitions in arch specific sections [6/8] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib - Remove RngFindDefaultAlgo() and change logic accordingly. [7/8] SecurityPkg/RngDxe: Select safe default Rng algorithm - Dropped due to changes in [6/8] This patch also requires the following patch on top of the serie: - https://edk2.groups.io/g/devel/message/106546 This patchset follows the 'code first' approach and relates to [1]. This patchset follows the thread at [3] that aims to solve [2]. [1] and [2] are bound and this patchset aims to solve both. In this patchset: a- The RngDxe can rely on the RngLib. However the RngLib has no interface allowing to describe which Rng algorithm is implemented. The RngDxe must advertise the algorithm that are available through the RngGetInfo() callback. Add a GetRngGuid() for interface to the RngLib. b- The Arm Architecture states the RNDR that the DRBG algorithm should be compliant with NIST SP800-90A, while not mandating a particular algorithm, so as to be inclusive of different geographies. The RngLib can rely on this Arm RNDR instruction. In order to accurately describe the implementation using the RNDR instruction, add a EFI_RNG_ALGORITHM_ARM_RNDR GUID [1]. c- For the same reason as a/b, add a GUID describing unsafe RNG algorithms, allowing to accurately describe the BaseRngLibTimerLib. d- Use a/b/c mechanisms/GUIDs to select a safe Rng algorithm in the Arm implementation of the RngDxe. [1] BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4441 [2] BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4151 [3] https://edk2.groups.io/g/devel/message/100806 Pierre Gondois (6): SecurityPkg/SecurityPkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg MdePkg/DxeRngLib: Request raw algorithm instead of default MdePkg/Rng: Add GUIDs to describe Rng algorithms MdePkg/Rng: Add GetRngGuid() to RngLib SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm MdePkg/Include/Library/RngLib.h | 17 ++++++ MdePkg/Include/Protocol/Rng.h | 20 +++++++ MdePkg/Library/BaseRngLib/AArch64/Rndr.c | 42 +++++++++++++++ MdePkg/Library/BaseRngLib/BaseRngLib.inf | 10 ++++ MdePkg/Library/BaseRngLib/Rand/RdRand.c | 26 +++++++++ .../Library/BaseRngLibNull/BaseRngLibNull.c | 22 ++++++++ .../BaseRngLibTimerLib/BaseRngLibTimerLib.inf | 3 ++ .../Library/BaseRngLibTimerLib/RngLibTimer.c | 28 ++++++++++ MdePkg/Library/DxeRngLib/DxeRngLib.c | 36 ++++++++++++- MdePkg/MdePkg.dec | 7 +++ .../RngDxe/AArch64/AArch64Algo.c | 54 +++++++++++++------ .../RandomNumberGenerator/RngDxe/ArmRngDxe.c | 23 ++++---- .../RandomNumberGenerator/RngDxe/RngDxe.inf | 5 +- SecurityPkg/SecurityPkg.dec | 2 - 14 files changed, 258 insertions(+), 37 deletions(-) --=20 2.25.1