From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.46]) by mx.groups.io with SMTP id smtpd.web10.11217.1688540205166008964 for ; Tue, 04 Jul 2023 23:56:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=osrLg25m; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.237.46, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a2rnjEk8TM0wHS9c/mYDQMUi54V9Upy4LZl+fPhoXNj88uK3Wt3bmw9BngT66aUHIFQ2Edr5TTSbmHyOXe8U/JxLhRMzX4FhEtQkp9+UjskHQXwId5bWkfZL1uBPNqJryjQZuuPKd4Xn58/3Wvq5MVcjp2GjtVy8FfG92x5WzIocxMJ+xL4x98z56YqjbsutLDinmbMd1oCVKrMT+PN8HBhRxH8guXRAyW2HWxT98E/xRC4C9VXKkAiChHS5Xx6H8eMVSvYad6tzIrNUCNBOP9uyV8LPl1WP2J2zuiGMGgk6+pKj4CX83I2UkH8LkiWh5tG/Grfo8CQKd4YyFLyviA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xo1tKbSYdWuXRJXHul39nXH28Q263jVxTQlhwl5FZp0=; b=UrcylPj6l2qmG4spTQ/HUU54MA3lAVuxHQRD0eyxl9JmIL8MyF3ae/eIoT/QHNEB5g/r/uTU8zWuG1thTcecHBC6Y7LFJg21YB07IjXkAzLVJ9AoVNFvcmd8FqGo198FNCvPaaiSRbyg2lflVD4y/9DORUtBUO81p4qs7UXtnWHo+XntY9/80o3zLKM/sYfuI61smoNDsK3FwHlF7vVGi3EvhxnaSzoEap8lY8sxWV0bvxXuvx4lTa8RzKwe2D2bRc1NPSRWr2advWonB6zTBMAH0DCNEE+IFiRUgHPMtrPs4bHykpGPzE50htQSoI435q99AO3UW1n45y6PkmRVCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xo1tKbSYdWuXRJXHul39nXH28Q263jVxTQlhwl5FZp0=; b=osrLg25m7APjV/2wiqTWp96FAfS6rN4radJFtuuHvv0oHPs0kyrS4p4tah9JpZ2DHcjXzZchS99EReTZM+3qlGGAVsNI76IDE8LQM4nFOyyJx2D/zKvQru1k7qTdAmrVhICW5/mr9pYgKa0w8K8RSvN9P5STMSLRPeWVRE3lxtiIU1o9mXXsPlXOXzomjXG/MTGCS0yBknVXVnRlj2wnrSOLG3ob675U75nKR/yTYbPAz4dwab5RPDd0F83W7JRETI9/71m0pLStFupH4LqShOy7INvQ23coCFnSa0R8rh28hlaWQL9/YYnnXQMJa+0/CEZHwGzLR4euYT94HF0puw== Received: from DS7PR03CA0314.namprd03.prod.outlook.com (2603:10b6:8:2b::26) by IA1PR12MB6386.namprd12.prod.outlook.com (2603:10b6:208:38a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Wed, 5 Jul 2023 06:56:41 +0000 Received: from DM6NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2b:cafe::a9) by DS7PR03CA0314.outlook.office365.com (2603:10b6:8:2b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Wed, 5 Jul 2023 06:56:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT024.mail.protection.outlook.com (10.13.172.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.45 via Frontend Transport; Wed, 5 Jul 2023 06:56:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 4 Jul 2023 23:56:31 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 4 Jul 2023 23:56:30 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Tue, 4 Jul 2023 23:56:29 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [PATCH v2 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe Date: Wed, 5 Jul 2023 14:56:28 +0800 Message-ID: <20230705065628.1329-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT024:EE_|IA1PR12MB6386:EE_ X-MS-Office365-Filtering-Correlation-Id: 54b2ec21-8684-4013-11b2-08db7d24fcc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x8WXbngZ4EPqhX7kH+TvYspm6GFf/907P+cEiOf9XYQmQaQOBLkCZrD4ijdJIWR+AHv7F/zj6eRvHedJpsnLL1adEzgbFNiMFbKUqAqgQkuLdZ0zfvjuX3/e2dF/4eD56aq3peXmu8bXxmraoTaPxjqvD/k/YbZ9OhA3zIzuLHnUCITuVUwe2NkGc+2I8at3TaA0UawiUwn6udhQCRlys32NcAVHKAgIZvBf7EvsU2tMi72Ga+Q75POu+YPQ1akbvA0kIoDbabSR3Gt5WnbWGRV78zPR88Vb4OUcCLNbTTj0rTl+vgqf6fRZ8J/SOLB6Dv7BG8tbvFa4cpILVnP6+wOsc8hBxkiJr2BQcn9KgBV93CVBh+OeBHnSuvsDrHP6fQs67x/ImG2MsBH7vLS6Q84uQnCAJahgrGYL8N6GwnWN2M2HV80DA52r2RFd9A4I64byR4k/lkifjnBU5tdAhaSu8TA7MGh8o+WDdXBcAmOCvTAnSqAtiXJ3G9XkLVbH+O5LwdAM3P899DeEJQTvYw76RORNlgaq1D48aSAkPtrswmJpkRwXOe/+SVyos3sSEfxKzEC/pkgJxrwtR7Im+8aeheEgLKCNUg5KYfpgrr4srjbve8KV+Qv1Xik66x8aoXEmVycXDFKxqxqDzf5syLn9nop1IhusMUgxDIC27aSVL/aftY2P3vPybGa7lY4Zv1V6v2MHYrkUFwQ3EWiJ0lMXf67FsgWO+/eViMOxXn4Ce4ukgiaVkpV4Ft1iv/iT X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(6029001)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199021)(36840700001)(40470700004)(46966006)(4326008)(2906002)(41300700001)(8676002)(5660300002)(40460700003)(82310400005)(36756003)(8936002)(40480700001)(86362001)(7696005)(83380400001)(47076005)(107886003)(426003)(336012)(36860700001)(478600001)(186003)(2616005)(1076003)(7636003)(356005)(26005)(70206006)(70586007)(6916009)(82740400003)(316002)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 06:56:41.4366 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54b2ec21-8684-4013-11b2-08db7d24fcc2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6386 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain RedfishRestExDxe driver failed to uninstall service binding protocol when driver binding stop is called. Application drivers may still use RedfishRestExDxe after it is disconnected in system. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c b/RedfishPkg= /RedfishRestExDxe/RedfishRestExDriver.c index ad65ae213ae0..7036aed42683 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c @@ -3,6 +3,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -57,6 +58,7 @@ RestExDestroyChildEntryInHandleBuffer ( ChildHandleBuffer =3D ((RESTEX_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT *)Con= text)->ChildHandleBuffer; =20 if (!NetIsInHandleBuffer (Instance->ChildHandle, NumberOfChildren, Child= HandleBuffer)) { + RemoveEntryList (&Instance->Link); return EFI_SUCCESS; } =20 @@ -563,7 +565,7 @@ RedfishRestExDriverBindingStop ( ); } =20 - if ((NumberOfChildren =3D=3D 0) && IsListEmpty (&RestExSb->RestExChildre= nList)) { + if (IsListEmpty (&RestExSb->RestExChildrenList)) { gBS->UninstallProtocolInterface ( NicHandle, &gEfiRestExServiceBindingProtocolGuid, --=20 2.17.1