* [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib
@ 2023-07-06 1:40 Michael Kubacki
2023-07-06 2:54 ` [edk2-devel] " Isaac Oram
[not found] ` <176F27C19A6762FE.24383@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: Michael Kubacki @ 2023-07-06 1:40 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone, Isaac Oram, Liming Gao, Eric Dong
From: Michael Kubacki <michael.kubacki@microsoft.com>
Commit `b71f2bd` introduced a couple build errors in
VariableWritelib. This change adds the SMM Services Table (`gSmst`)
and MM Services Table (`gMmst`) calls needed to register the
protocol notify in the Traditional and Standalone MM services
constructors.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c | 6 +++++-
Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c
index 8c2b7d18f5f8..447d358a3104 100644
--- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c
+++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c
@@ -74,7 +74,11 @@ StandaloneMmVariableWriteLibConstructor (
//
// Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServicesProtocolGuid.
//
- Status = SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocolGuid, VarLibExitBootServicesCallback, &Registration);
+ Status = gMmst->MmRegisterProtocolNotify (
+ &gEdkiiSmmExitBootServicesProtocolGuid,
+ VarLibExitBootServicesCallback,
+ &Registration
+ );
ASSERT_EFI_ERROR (Status);
return Status;
diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c
index abc1e25cde6c..413930d465eb 100644
--- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c
+++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c
@@ -74,7 +74,11 @@ TraditionalMmVariableWriteLibConstructor (
//
// Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServicesProtocolGuid.
//
- Status = SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocolGuid, VarLibExitBootServicesCallback, &Registration);
+ Status = gSmst->SmmRegisterProtocolNotify (
+ &gEdkiiSmmExitBootServicesProtocolGuid,
+ VarLibExitBootServicesCallback,
+ &Registration
+ );
ASSERT_EFI_ERROR (Status);
return Status;
--
2.41.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib
2023-07-06 1:40 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib Michael Kubacki
@ 2023-07-06 2:54 ` Isaac Oram
[not found] ` <176F27C19A6762FE.24383@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: Isaac Oram @ 2023-07-06 2:54 UTC (permalink / raw)
To: devel@edk2.groups.io, mikuback@linux.microsoft.com
Cc: Chiu, Chasel, Desimone, Nathaniel L, Gao, Liming, Dong, Eric
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
Sent: Wednesday, July 5, 2023 6:40 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib
From: Michael Kubacki <michael.kubacki@microsoft.com>
Commit `b71f2bd` introduced a couple build errors in VariableWritelib. This change adds the SMM Services Table (`gSmst`) and MM Services Table (`gMmst`) calls needed to register the protocol notify in the Traditional and Standalone MM services constructors.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c | 6 +++++- Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c
index 8c2b7d18f5f8..447d358a3104 100644
--- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c
+++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Standalo
+++ neMmVariableWriteLibConstructor.c
@@ -74,7 +74,11 @@ StandaloneMmVariableWriteLibConstructor (
//
// Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServicesProtocolGuid.
//
- Status = SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocolGuid, VarLibExitBootServicesCallback, &Registration);
+ Status = gMmst->MmRegisterProtocolNotify (
+ &gEdkiiSmmExitBootServicesProtocolGuid,
+ VarLibExitBootServicesCallback,
+ &Registration
+ );
ASSERT_EFI_ERROR (Status);
return Status;
diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c
index abc1e25cde6c..413930d465eb 100644
--- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c
+++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Traditio
+++ nalMmVariableWriteLibConstructor.c
@@ -74,7 +74,11 @@ TraditionalMmVariableWriteLibConstructor (
//
// Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServicesProtocolGuid.
//
- Status = SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocolGuid, VarLibExitBootServicesCallback, &Registration);
+ Status = gSmst->SmmRegisterProtocolNotify (
+ &gEdkiiSmmExitBootServicesProtocolGuid,
+ VarLibExitBootServicesCallback,
+ &Registration
+ );
ASSERT_EFI_ERROR (Status);
return Status;
--
2.41.0.windows.1
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106669): https://edk2.groups.io/g/devel/message/106669
Mute This Topic: https://groups.io/mt/99977994/1492418
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com]
-=-=-=-=-=-=
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib
[not found] ` <176F27C19A6762FE.24383@groups.io>
@ 2023-07-07 1:14 ` Isaac Oram
0 siblings, 0 replies; 3+ messages in thread
From: Isaac Oram @ 2023-07-07 1:14 UTC (permalink / raw)
To: devel@edk2.groups.io, Oram, Isaac W, mikuback@linux.microsoft.com
Cc: Chiu, Chasel, Desimone, Nathaniel L, Gao, Liming, Dong, Eric
Pushed as f4fbaf6022603957fefa77c9ceb77f4b2851b0dc
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Wednesday, July 5, 2023 7:55 PM
To: devel@edk2.groups.io; mikuback@linux.microsoft.com
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
Sent: Wednesday, July 5, 2023 6:40 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib
From: Michael Kubacki <michael.kubacki@microsoft.com>
Commit `b71f2bd` introduced a couple build errors in VariableWritelib. This change adds the SMM Services Table (`gSmst`) and MM Services Table (`gMmst`) calls needed to register the protocol notify in the Traditional and Standalone MM services constructors.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c | 6 +++++- Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c
index 8c2b7d18f5f8..447d358a3104 100644
--- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c
+++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Standalo
+++ neMmVariableWriteLibConstructor.c
@@ -74,7 +74,11 @@ StandaloneMmVariableWriteLibConstructor (
//
// Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServicesProtocolGuid.
//
- Status = SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocolGuid, VarLibExitBootServicesCallback, &Registration);
+ Status = gMmst->MmRegisterProtocolNotify (
+ &gEdkiiSmmExitBootServicesProtocolGuid,
+ VarLibExitBootServicesCallback,
+ &Registration
+ );
ASSERT_EFI_ERROR (Status);
return Status;
diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c
index abc1e25cde6c..413930d465eb 100644
--- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c
+++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Traditio
+++ nalMmVariableWriteLibConstructor.c
@@ -74,7 +74,11 @@ TraditionalMmVariableWriteLibConstructor (
//
// Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServicesProtocolGuid.
//
- Status = SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocolGuid, VarLibExitBootServicesCallback, &Registration);
+ Status = gSmst->SmmRegisterProtocolNotify (
+ &gEdkiiSmmExitBootServicesProtocolGuid,
+ VarLibExitBootServicesCallback,
+ &Registration
+ );
ASSERT_EFI_ERROR (Status);
return Status;
--
2.41.0.windows.1
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106669): https://edk2.groups.io/g/devel/message/106669
Mute This Topic: https://groups.io/mt/99977994/1492418
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] -=-=-=-=-=-=
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-07 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-06 1:40 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib Michael Kubacki
2023-07-06 2:54 ` [edk2-devel] " Isaac Oram
[not found] ` <176F27C19A6762FE.24383@groups.io>
2023-07-07 1:14 ` Isaac Oram
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox