From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.20862.1688646617792940246 for ; Thu, 06 Jul 2023 05:30:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LNSMkiRf; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688646616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bhUlYzSEfOBl6qq+CKF2PDZ0fU02VBLYl5x/5bvAbTA=; b=LNSMkiRfq13AFYjA6garbog4NB1TA7COb6vNX48epKJMkSR6WTsU6KN2pcz/Txceo2nXDL Nvw1rxLBMc96stO+dlm2FmN8Md2nu5G3pzuqG928loPX6wGihgQCy/MNuRlMSORssu8OAI rE0lql6/dZPshuo45qnoDnZpofY/SZU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-231-Z5BTO5ZpM7Sz12zf0DuZMg-1; Thu, 06 Jul 2023 08:30:13 -0400 X-MC-Unique: Z5BTO5ZpM7Sz12zf0DuZMg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3F3A3858EED; Thu, 6 Jul 2023 12:30:13 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.221]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E809E492C13; Thu, 6 Jul 2023 12:30:11 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E49ED1800D4D; Thu, 6 Jul 2023 14:30:09 +0200 (CEST) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Gerd Hoffmann , Sami Mujawar , Laszlo Ersek Subject: [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console Date: Thu, 6 Jul 2023 14:30:09 +0200 Message-ID: <20230706123009.802243-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Be consistent with pl011-based serial console setup. Suggested-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c index b92a916f7eec..85c01351b09d 100644 --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c @@ -606,7 +606,7 @@ SetupVirtioSerial ( 1 }; - STATIC CONST VENDOR_DEVICE_PATH TerminalNode = { + STATIC VENDOR_DEVICE_PATH TerminalNode = { { MESSAGING_DEVICE_PATH, MSG_VENDOR_DP, @@ -615,7 +615,7 @@ SetupVirtioSerial ( (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8) }, }, - DEVICE_PATH_MESSAGING_VT_UTF8 + // copy from PcdTerminalTypeGuidBuffer }; EFI_STATUS Status; @@ -634,6 +634,11 @@ SetupVirtioSerial ( return; } + CopyGuid ( + &TerminalNode.Guid, + PcdGetPtr (PcdTerminalTypeGuidBuffer) + ); + DevicePath = AppendDevicePathNode ( DevicePath, &SerialNode.Header -- 2.41.0