From: "Sunil V L" <sunilvl@ventanamicro.com>
To: devel@edk2.groups.io
Cc: Sunil V L <sunilvl@ventanamicro.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Andrei Warkentin <andrei.warkentin@intel.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH v2 2/4] OvmfPkg/RiscVVirt: SecEntry: Remove unnecessary assembly directives
Date: Tue, 11 Jul 2023 21:13:33 +0530 [thread overview]
Message-ID: <20230711154335.586343-3-sunilvl@ventanamicro.com> (raw)
In-Reply-To: <20230711154335.586343-1-sunilvl@ventanamicro.com>
llvm fails to resolve _ModuleEntry when these extra directives are
present. ASM_FUNC already takes care what is required.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
---
OvmfPkg/RiscVVirt/Sec/SecEntry.S | 3 ---
1 file changed, 3 deletions(-)
diff --git a/OvmfPkg/RiscVVirt/Sec/SecEntry.S b/OvmfPkg/RiscVVirt/Sec/SecEntry.S
index e919a3cb0e80..192fff321ce5 100644
--- a/OvmfPkg/RiscVVirt/Sec/SecEntry.S
+++ b/OvmfPkg/RiscVVirt/Sec/SecEntry.S
@@ -7,9 +7,6 @@
#include "SecMain.h"
-.text
-.align 3
-
ASM_FUNC (_ModuleEntryPoint)
/* Use Temp memory as the stack for calling to C code */
li a4, FixedPcdGet32 (PcdOvmfSecPeiTempRamBase)
--
2.34.1
next prev parent reply other threads:[~2023-07-11 15:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 15:43 [PATCH v2 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain support Sunil V L
2023-07-11 15:43 ` [PATCH v2 1/4] OvmfPkg/RiscVVirt: use 'auto' alignment and FIXED for XIP modules Sunil V L
2023-07-11 15:43 ` Sunil V L [this message]
2023-07-11 15:43 ` [PATCH v2 3/4] BaseTools/tools_def: Add CLANGDWARF support for RISC-V Sunil V L
2023-07-31 11:28 ` [edk2-devel] " Rebecca Cran
2023-07-11 15:43 ` [PATCH v2 4/4] OvmfPkg/RiscVVirt: Update README for CLANGDWARF support Sunil V L
2023-07-17 1:51 ` 回复: [PATCH v2 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain support gaoliming
2023-07-17 4:07 ` [edk2-devel] " Sunil V L
2023-07-17 9:38 ` Ard Biesheuvel
2023-07-21 4:52 ` Sunil V L
2023-07-25 15:59 ` Ard Biesheuvel
2023-07-28 5:32 ` Sunil V L
2023-07-31 10:29 ` Ard Biesheuvel
2023-07-31 11:28 ` Rebecca Cran
2023-07-31 14:24 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711154335.586343-3-sunilvl@ventanamicro.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox