From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DF71DD80F93 for ; Mon, 17 Jul 2023 09:54:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=52DVpp/aXdfl4fUkWIiK64qIOUMvdAII6lD46smUbvc=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-Received:X-Received:X-MS-Exchange-Authentication-Results:Received-SPF:X-Received:X-Received:X-CheckRecipientChecked:X-CR-MTA-CID:X-CR-MTA-TID:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:X-MS-Exchange-Authentication-Results:Received-SPF:X-Received:X-Received:X-Received:X-Received:From:To:CC:Subject:Date:Message-ID:MIME-Version:X-EOPAttributedMessage:X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id:x-checkrecipientrouted:NoDisclaimer:X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam-Untrusted:X-Microsoft-Antispam-Message-Info-Original:X-Forefront-Antispam-Report-Untrusted:X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-MS-Exchange-Transport-CrossTenantHeadersStripped:X-MS-PublicTrafficType:X-MS-Office365-Filtering-Correlation-Id-Prvs:X-Microsoft-Antispam-Message-Info:X-OriginatorOrg:X-MS-Exchange-CrossTenant-OriginalArrivalTime:X-MS-Exchange-CrossTenant -Network-Message-Id:X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-FromEntityHeader:X-MS-Exchange-Transport-CrossTenantHeadersStamped:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:X-Gm-Message-State:Content-Transfer-Encoding:Content-Type; s=20140610; t=1689587667; v=1; b=j2PQHBlcQA8eaFaemGJ0RnP+WF8oauGebKEJjvkm2EfjjZ6s9CG/ofSPi+PyMHWU0zFu6A5c 0ZKsng1d9PFt+REouWBxU6hABjAIzcFRukSDP6YUrqed+EL34B30vGQHbRPtN2IVbYb4pim5D2P DRD3z/IQke0BjujncsiFKM/U= X-Received: by 127.0.0.2 with SMTP id o9jBYY7687511x7yKkcYMKTC; Mon, 17 Jul 2023 02:54:27 -0700 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.84]) by mx.groups.io with SMTP id smtpd.web10.4678.1689587665861260075 for ; Mon, 17 Jul 2023 02:54:26 -0700 X-Received: from AS9PR06CA0676.eurprd06.prod.outlook.com (2603:10a6:20b:49c::25) by GV1PR08MB7987.eurprd08.prod.outlook.com (2603:10a6:150:9d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 09:54:20 +0000 X-Received: from AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49c:cafe::dc) by AS9PR06CA0676.outlook.office365.com (2603:10a6:20b:49c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32 via Frontend Transport; Mon, 17 Jul 2023 09:54:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT056.mail.protection.outlook.com (100.127.140.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32 via Frontend Transport; Mon, 17 Jul 2023 09:54:20 +0000 X-Received: ("Tessian outbound ba2f3d95109c:v145"); Mon, 17 Jul 2023 09:54:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b873410f448da6cd X-CR-MTA-TID: 64aa7808 X-Received: from ffeb9b235536.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1523ACD6-ACF5-4015-B7BA-17BBA8B11173.1; Mon, 17 Jul 2023 09:54:09 +0000 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ffeb9b235536.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 17 Jul 2023 09:54:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJHxW2+GQlVaVw0w3pEPtBIgQzMCDAob2L0GdBD5k5oD5x8OXErSfjFP26r6nSiDS3qzMqHlM8gP5MCm/ArE49UfG0iwcWYfA8tvET/zi1soRVywwee4LvVr6xfT4vA2fp7C1Xf5kfDAoAeYXZj9yJWXrrB67TP8iOt09lJSzC3PON7ypTm2N9zK67zsArfjPWAjtLoyx+DQIU6pdLd7uBObGhupH+A7JyZ2wenvtftQ1Zbaxe73Leu9ClWEU8S4uefWZOpmStI/rjrPJslb1KnSp9tW0VhraWehaAyayz8Yl4a6P7NzEcV4IeMrvhEynYuBh2llYNsG04V2oQZFKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y5pHMsd+5RQwrRcdGJTOAaZuX6PcTWGObFttV1bX/rk=; b=AW2DzGDwBsFPqKjBpnMcxH42en4grYYk25ki4V2Zi4Qc0KCGKJxCiXQPvPRffc4THuD6KlvXAnbnE8uFGYgDQGMFrJsh4it/ObwCFpmr+fyK0NybANs57FrBFgISahWgDzaq+Ddcqnq1+qDwcxu/2A/uLFscV6TYnFrjZ2kbdreFwSocad4BkK1EN6gFcujPipR6Yzs0VpuX0MZaFj3E7ddvi+StYqG9N71iAxHF+plGeRwYNDXAHduoFe74LZnCl64TGq7ubB9TqajNYYN1HSKA1SFUHUVr/mT2CeyNgcWN9wkk6f7IiDxEEKHR7DsCP69frJqStC96uWPDbaKdYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from ZR0P278CA0170.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::12) by DU0PR08MB9322.eurprd08.prod.outlook.com (2603:10a6:10:41d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 09:54:05 +0000 X-Received: from VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:45:cafe::b1) by ZR0P278CA0170.outlook.office365.com (2603:10a6:910:45::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32 via Frontend Transport; Mon, 17 Jul 2023 09:54:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT052.mail.protection.outlook.com (100.127.144.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6588.32 via Frontend Transport; Mon, 17 Jul 2023 09:54:04 +0000 X-Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 09:54:02 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 09:54:02 +0000 X-Received: from e129823.cambridge.arm.com (10.1.196.51) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Mon, 17 Jul 2023 09:54:01 +0000 From: "levi.yun" To: CC: , , , , , , , Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg/BaseCryptoLib: Remove unnecessary key generation. Date: Mon, 17 Jul 2023 10:54:01 +0100 Message-ID: <20230717095401.1954867-1-yeoreum.yun@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT052:EE_|DU0PR08MB9322:EE_|AM7EUR03FT056:EE_|GV1PR08MB7987:EE_ X-MS-Office365-Filtering-Correlation-Id: 91a10ab8-7fad-4689-6da9-08db86abcadf x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 80wSB2rDUlgukcPZaliXwPrZC1eUQZTPkxth0/VMfpG/4uFRGkvkVyzP0P9jXuhHiHx4qA0h8sNiP//26eMqjguUvPzeps8w3LFZEkd/OnD9W+IUN9j+ZlQYgLMc4EWtbwWHpGQ4OQMtuhynX+X5YoWGgI0wHbFkpaKx2BZfqi6SIH92CgzQyufvm6FJYPI+QBKYmgReHe6jVsWrZ6nLNKO1JNAv58uibh6L8261TdG6bsZU7KGWZ0d9yQ3XbmDaJet8tT1xLKWnTKseMePRhMz8EWjzytHFdT0ldYQTyzNlI7TuTfhJHWk/ghqNRzJ/5kgoxr60OwFvZAVKc/k79Hu/irrfPXkgXUsm1v8ePkKmVDiI2GBB9O0dg8Nmm78p5eB5gkuABqkm6gC5RCvU5yPe4eNfJBSKsVfK+wlG8vr5dBmgAXD5pOui7IJJ0592KAj65hDH741xzJHX0DZP+2bD5Sr6IYfIlBaNPCbofd50b8yaNY7Z7NMcXMbEVci7GLYL3mN9CCRwfSdphUIaYD+Igg4LtCeZpKGjZhz0C9AhO5xezZaACI22sgKiIsooCxeK/RN4/1gRjs3x/fdZSgEvvdPfsN6wlogReitbEdMB6n0M3SqH2gM/f8ZC/LWEzX/OmmhsftGWDSakT0tfGqFnJyCcJeu6bddcueKuO2ULcAd8Z1hHeMTh3bmOH5v444QnTbR929Gk6tbD1BKfmRBR0oykdeMytqK2XRbk9i/JhgSJvFFntHRCYn6WBTBZgpg7uufio2A8tqLJL30USQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(346002)(376002)(82310400008)(451199021)(36840700001)(40470700004)(46966006)(2906002)(54906003)(478600001)(7696005)(8936002)(36756003)(8676002)(41300700001)(316002)(70206006)(6916009)(70586007)(4326008)(82740400003)(83380400001)(426003)(336012)(47076005)(81166007)(86362001)(356005)(966005)(40460700003)(5660300002)(1076003)(26005)(2616005)(186003)(36860700001)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9322 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1752aa71-c27b-41b2-96ea-08db86abc1b5 X-Microsoft-Antispam-Message-Info: tbGR6vzZb7VoW3ubSxWcO5+QWNQwFMaWswOMFrWrgG8XwG92xoHorFuQzmWlGdGfUM8BH3vXl8FLGg9fCMDfD7mVhHLTdDShzBpJhWCVcyHf7xCKMaqL6jRJAJRUfj6lORGv3+FM5zZE7Crq+bFQNVv/NFPyUpXJzccdhBbUD2m+Nl+bGlMqy9NUZYQG2YeiOr//iiZp1WSQ/dMZheIW2/je/4+dVr90oQOwCEHjksVs9A5WgwdRmvW8zC80jNwsVozF321gv+aMopDWPg3Gdv+BC2g3dV4Dvx5DYWsSf9ioG6v0Ie9ZxePUY1iQ5p3dgTZ6ifuZ4IvTW6/Z1jjhFphytfAkgI7Bp3MX/d/7B40OoatYMULY7cEd6yFDATqBonyf64/LFlHcsNG5jgQKPfM4iZ7PPEz92/Z/Yli32jMvwXcxVz+r9e5xA7KVBqRVbsIjlpfVASDcLXiGQXmSU01eAJGLi1qTBOgAJZO4xgHYyEvwv11+JhqhXcQ6RIAWX0EV8QycWk6zIp2jjEphPlvBHziEEss3rYzbHqUFmMcxQpFNMKFdN32PrVzCrj8x4DNNfs5wqWEVTN/l4bFn16cgMcuqQ4FJAl+G83B/0reLQlWoai/XjkdcSiWhWeKuSF4IyBC3TBF2HLIcrqBAoffEUI9xpt7Q8sf6VjN/+Z8KPrvJw4cOqxQmxJLWr5uP+Q3P8u7GFNBLyITmkFShFV7TOSw+2jVjnejvSB2gJ+I= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 09:54:20.3602 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91a10ab8-7fad-4689-6da9-08db86abcadf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7987 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yeoreum.yun@arm.com X-Gm-Message-State: geWkrRwXVoRvx9C3BOZlHwKNx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=j2PQHBlc; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") When EcGenerateKey() is called with PublicKeySize set to zero or less than the required size, it returns the size of the required buffer with failure. However, EcGenerateKey() generates a key and then checks if the buffer size is insufficient. This can be optimised by moving the public key size check before generating the key. Therefore, optimise to avoid unnecessary key generation. Signed-off-by: levi.yun --- This changes can be seen at https://github.com/LeviYeoReum/edk2/tree/levi/2= 716_not_generate_key_on_fail_size_v1 CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c b/CryptoPkg/Librar= y/BaseCryptLib/Pk/CryptEc.c index d8cc9ba0e8f968f6cbd9ac4c56018f9a4392cd0b..af67f512a22b23af3844b9bbc87= dd57bcf952f04 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c @@ -497,16 +497,16 @@ EcGenerateKey ( Group =3D EC_KEY_get0_group (EcKey); HalfSize =3D (EC_GROUP_get_degree (Group) + 7) / 8; + if (*PublicKeySize < HalfSize * 2) { + *PublicKeySize =3D HalfSize * 2; + return FALSE; + } + // Assume RAND_seed was called if (EC_KEY_generate_key (EcKey) !=3D 1) { return FALSE; } - if (*PublicKeySize < HalfSize * 2) { - *PublicKeySize =3D HalfSize * 2; - return FALSE; - } - *PublicKeySize =3D HalfSize * 2; EcPoint =3D EC_KEY_get0_public_key (EcKey); -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106962): https://edk2.groups.io/g/devel/message/106962 Mute This Topic: https://groups.io/mt/100191693/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-