* [edk2-devel] [edk2-libc Patch v2 0/1] edk2-libc/StdLib fix uninitialized global variable
@ 2023-07-21 15:47 Jayaprakash, N
2023-07-21 15:47 ` [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc/StdLib: Uninitialized " Jayaprakash, N
0 siblings, 1 reply; 2+ messages in thread
From: Jayaprakash, N @ 2023-07-21 15:47 UTC (permalink / raw)
To: devel; +Cc: Jayaprakash N
This patch has fix for un-initialized global variable in the
edk2-libc repos StdLib/BsdSocketLib.
Jayaprakash N (1):
edk2-libc/StdLib: Uninitialized global variable
StdLib/BsdSocketLib/res_init.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--
2.40.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107129): https://edk2.groups.io/g/devel/message/107129
Mute This Topic: https://groups.io/mt/100279092/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 2+ messages in thread
* [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc/StdLib: Uninitialized global variable
2023-07-21 15:47 [edk2-devel] [edk2-libc Patch v2 0/1] edk2-libc/StdLib fix uninitialized global variable Jayaprakash, N
@ 2023-07-21 15:47 ` Jayaprakash, N
0 siblings, 0 replies; 2+ messages in thread
From: Jayaprakash, N @ 2023-07-21 15:47 UTC (permalink / raw)
To: devel; +Cc: Jayaprakash N, Rebecca Cran, Michael D Kinney, Kloper Dimitry
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506
res_init() is called from different places in sockets library.
It depends on global _res variable containing a state.
The problem is that if __BIND_RES_TEXT macro is not defined, _res is not initialized.
Depending on compiler and build optimization this can fill
the variable with garbage that is later used by res_init().
Fix is trivial - explicitly initialize _res
Cc: Rebecca Cran <rebecca@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Co-authored-by: Kloper Dimitry <dimitry.kloper@intel.com>
Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
---
StdLib/BsdSocketLib/res_init.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/StdLib/BsdSocketLib/res_init.c b/StdLib/BsdSocketLib/res_init.c
index 613a76a..6421d9a 100644
--- a/StdLib/BsdSocketLib/res_init.c
+++ b/StdLib/BsdSocketLib/res_init.c
@@ -122,9 +122,10 @@ static u_int32_t net_mask __P((struct in_addr));
struct __res_state _res
# if defined(__BIND_RES_TEXT)
- = { RES_TIMEOUT, } /* Motorola, et al. */
-# endif
- ;
+ = { RES_TIMEOUT, }; /* Motorola, et al. */
+#else
+ = {0};
+#endif
/*
--
2.40.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107130): https://edk2.groups.io/g/devel/message/107130
Mute This Topic: https://groups.io/mt/100279095/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-21 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-21 15:47 [edk2-devel] [edk2-libc Patch v2 0/1] edk2-libc/StdLib fix uninitialized global variable Jayaprakash, N
2023-07-21 15:47 ` [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc/StdLib: Uninitialized " Jayaprakash, N
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox