From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <pierre.gondois@arm.com>,
<Anshuman.Khandual@arm.com>, <Matteo.Carlini@arm.com>,
<Akanksha.Jain2@arm.com>, <Sibel.Allinson@arm.com>, <nd@arm.com>
Subject: [edk2-devel] [PATCH v1 11/11] DynamicTablesPkg: Fix referencing of CPC token
Date: Tue, 25 Jul 2023 11:27:58 +0100 [thread overview]
Message-ID: <20230725102758.28132-12-sami.mujawar@arm.com> (raw)
In-Reply-To: <20230725102758.28132-1-sami.mujawar@arm.com>
The CpcToken has been incorrectly referenced in the
CreateTopologyFromGicC() and always points to the
CPC token in the first GICC Info object.
Therefore, fix this by correctly indexing into the
GicCInfo object array.
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
index 6fbba12a010bf987797f0901a032735e8e0be598..8228c7845ac0c26ca0f319fd86abf89bb3bfaf50 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
@@ -1298,7 +1298,7 @@ CreateTopologyFromGicC (
// If a CPC info is associated with the
// GicCinfo, create an _CPC method returning them.
- if (GicCInfo->CpcToken != CM_NULL_TOKEN) {
+ if (GicCInfo[Index].CpcToken != CM_NULL_TOKEN) {
Status = CreateAmlCpcNode (Generator, CfgMgrProtocol, &GicCInfo[Index], CpuNode);
if (EFI_ERROR (Status)) {
ASSERT_EFI_ERROR (Status);
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107238): https://edk2.groups.io/g/devel/message/107238
Mute This Topic: https://groups.io/mt/100347389/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-07-25 10:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 10:27 [edk2-devel] [PATCH v1 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 01/11] MdePkg: MADT: Add Online capable flag in GICC Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 02/11] MdePkg: MADT: Add TRBE interrupt to GICC Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 03/11] DynamicTablesPkg: Add TRBE interrupt to GICC object Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 04/11] DynamicTablesPkg: Add TRBE interrupt to GICC object parser Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5 Sami Mujawar
2023-08-01 15:44 ` Jeshua Smith via groups.io
2023-08-03 7:07 ` Sami Mujawar
2023-09-11 16:58 ` Jeshua Smith via groups.io
2023-09-11 17:59 ` Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 06/11] DynamicTablesPkg: Update FADT generator to " Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 07/11] ShellPkg: Acpiview: Update MADT parser for TRBE interrupt Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 08/11] DynamicTablesPkg: Add an ET info object to Arm namespace Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 09/11] DynamicTablesPkg: Add an ET info object parser Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 10/11] DynamicTablesPkg: Add ETE device to CPU node in AML Sami Mujawar
2023-07-25 10:27 ` Sami Mujawar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725102758.28132-12-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox