public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>
Subject: [edk2-devel] [PATCH 2/2] MdePkg: Add new status codes to PrintLib
Date: Mon, 31 Jul 2023 11:43:14 -0700	[thread overview]
Message-ID: <20230731184314.1253-3-nathaniel.l.desimone@intel.com> (raw)
In-Reply-To: <20230731184314.1253-1-nathaniel.l.desimone@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4514

PrintLib does not correctly decode the follow status codes:

 1. EFI_IP_ADDRESS_CONFLICT
 2. EFI_HTTP_ERROR
 3. EFI_WARN_FILE_SYSTEM
 4. EFI_WARN_RESET_REQUIRED

These missing status codes have been added.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 MdePkg/Library/BasePrintLib/PrintLibInternal.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/MdePkg/Library/BasePrintLib/PrintLibInternal.c b/MdePkg/Library/BasePrintLib/PrintLibInternal.c
index 42b598a432..c666c6614c 100644
--- a/MdePkg/Library/BasePrintLib/PrintLibInternal.c
+++ b/MdePkg/Library/BasePrintLib/PrintLibInternal.c
@@ -8,8 +8,8 @@
 
 #include "PrintLibInternal.h"
 
-#define WARNING_STATUS_NUMBER  5
-#define ERROR_STATUS_NUMBER    33
+#define WARNING_STATUS_NUMBER  7
+#define ERROR_STATUS_NUMBER    35
 
 //
 // Safe print checks
@@ -37,6 +37,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED CONST CHAR8  mWarningString[][24+1] = {
   "Warning Write Failure",        //  RETURN_WARN_WRITE_FAILURE     = 3
   "Warning Buffer Too Small",     //  RETURN_WARN_BUFFER_TOO_SMALL  = 4
   "Warning Stale Data",           //  RETURN_WARN_STALE_DATA        = 5
+  "Warning File System",          //  RETURN_WARN_FILE_SYSTEM       = 6
+  "Warning Reset Required",       //  RETURN_WARN_RESET_REQUIRED    = 7
 };
 
 //
@@ -75,7 +77,9 @@ GLOBAL_REMOVE_IF_UNREFERENCED CONST CHAR8  mErrorString[][20+1] = {
   "Reserved (30)",                //  RESERVED                      = 30 | MAX_BIT
   "End of File",                  //  RETURN_END_OF_FILE            = 31 | MAX_BIT
   "Invalid Language",             //  RETURN_INVALID_LANGUAGE       = 32 | MAX_BIT
-  "Compromised Data"              //  RETURN_COMPROMISED_DATA       = 33 | MAX_BIT
+  "Compromised Data",             //  RETURN_COMPROMISED_DATA       = 33 | MAX_BIT
+  "IP Address Conflict",          //  RETURN_IP_ADDRESS_CONFLICT    = 34 | MAX_BIT
+  "HTTP Error"                    //  RETURN_HTTP_ERROR             = 35 | MAX_BIT
 };
 
 /**
-- 
2.30.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107407): https://edk2.groups.io/g/devel/message/107407
Mute This Topic: https://groups.io/mt/100468027/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2023-07-31 18:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31 18:43 [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes Nate DeSimone
2023-07-31 18:43 ` [edk2-devel] [PATCH 1/2] " Nate DeSimone
2023-07-31 18:43 ` Nate DeSimone [this message]
2023-07-31 20:39 ` [edk2-devel] [PATCH v1 0/2] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230731184314.1253-3-nathaniel.l.desimone@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox