* [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Ampere: Fix parameter mismatch in DEBUG_ERROR message
@ 2023-08-07 1:55 Rebecca Cran
2023-08-07 6:53 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Rebecca Cran @ 2023-08-07 1:55 UTC (permalink / raw)
To: devel, Nhi Pham, Vu Nguyen, Thang Nguyen, Chuong Tran,
Leif Lindholm
Cc: Rebecca Cran
There's an extra format specifier in the DEBUG_ERROR message that
gets printed when the PCIe link check fails. This causes a
synchronous exception. Remove the string format specifier.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
index 94eb9e27d203..3c1fe5e35ca2 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
+++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
@@ -1405,7 +1405,7 @@ PFACounterRead (
Ret = LINK_CHECK_FAILED;
DEBUG ((
DEBUG_ERROR,
- "\tSocket%d RootComplex%d RP%d \t%s: %d \tGROUP:%d-EVENT:%d\n",
+ "\tSocket%d RootComplex%d RP%d \t: %d \tGROUP:%d-EVENT:%d\n",
RootComplex->Socket,
RootComplex->ID,
PcieIndex,
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107605): https://edk2.groups.io/g/devel/message/107605
Mute This Topic: https://groups.io/mt/100592555/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Ampere: Fix parameter mismatch in DEBUG_ERROR message
2023-08-07 1:55 [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Ampere: Fix parameter mismatch in DEBUG_ERROR message Rebecca Cran
@ 2023-08-07 6:53 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2023-08-07 6:53 UTC (permalink / raw)
To: devel, rebecca
Cc: Nhi Pham, Vu Nguyen, Thang Nguyen, Chuong Tran, Leif Lindholm
On Mon, 7 Aug 2023 at 03:56, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> There's an extra format specifier in the DEBUG_ERROR message that
> gets printed when the PCIe link check fails. This causes a
> synchronous exception. Remove the string format specifier.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Thanks
Pushed as 4507df44c528..84ccada59257
> ---
> Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
> index 94eb9e27d203..3c1fe5e35ca2 100644
> --- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
> +++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
> @@ -1405,7 +1405,7 @@ PFACounterRead (
> Ret = LINK_CHECK_FAILED;
> DEBUG ((
> DEBUG_ERROR,
> - "\tSocket%d RootComplex%d RP%d \t%s: %d \tGROUP:%d-EVENT:%d\n",
> + "\tSocket%d RootComplex%d RP%d \t: %d \tGROUP:%d-EVENT:%d\n",
> RootComplex->Socket,
> RootComplex->ID,
> PcieIndex,
> --
> 2.34.1
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107610): https://edk2.groups.io/g/devel/message/107610
Mute This Topic: https://groups.io/mt/100592555/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-07 6:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07 1:55 [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Ampere: Fix parameter mismatch in DEBUG_ERROR message Rebecca Cran
2023-08-07 6:53 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox