public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info
@ 2023-08-08  2:58 Zhenyu Zhang
  2023-08-21 14:41 ` Gerd Hoffmann
  0 siblings, 1 reply; 5+ messages in thread
From: Zhenyu Zhang @ 2023-08-08  2:58 UTC (permalink / raw)
  To: devel
  Cc: michael.d.kinney, gaoliming, zhiguang.liu, osteffen, ghoffman,
	shahuang, shan.gavin, zhenyzha

When the variable store is full, edk2 will directly assert.
Add debug information to help users understand what caused
the assertion.

 Actual results:
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x7E
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize =
 0x3FF98
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x92
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98

 Synchronous Exception at 0x000000023CA60374
 ......
 ASSERT [ArmCpuDxe] /builddir/build/BUILD/edk2-f80f052277c8/ArmPkg/
 Library/DefaultExceptionHandlerLib/AArch64/
 DefaultExceptionHandler.c(333): ((BOOLEAN) (0==1))

Cc: Oliver Steffen <osteffen@redhat.com>
Cc: Gerd Hoffmann <ghoffman@redhat.com>
Cc: Gavin Shan <gshan@redhat.com>
Cc: Shaoqin Huang <shahuang@redhat.com>
Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
---
 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 7a1331255b81..901112ac5961 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -1943,6 +1943,7 @@ UpdateVariable (
           // Existing data size + new data size exceed maximum variable size limitation.
           //
           Status = EFI_INVALID_PARAMETER;
+          DEBUG ((DEBUG_ERROR, "ERROR: The variable store exceed maximum variable size limitation.\n"));
           goto Done;
         }
 
-- 
2.39.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107639): https://edk2.groups.io/g/devel/message/107639
Mute This Topic: https://groups.io/mt/100623349/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info
@ 2023-08-08  5:42 Zhenyu Zhangzhenyzha12@gmail.com
  0 siblings, 0 replies; 5+ messages in thread
From: Zhenyu Zhangzhenyzha12@gmail.com @ 2023-08-08  5:42 UTC (permalink / raw)
  To: devel; +Cc: zhenyzha12

When the variable store is full, edk2 will directly assert.
Add debug information to help users understand what caused
the assertion.

 Actual results:
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x7E
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize =
 0x3FF98
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x92
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98

 Synchronous Exception at 0x000000023CA60374
 ......
 ASSERT [ArmCpuDxe] /builddir/build/BUILD/edk2-f80f052277c8/ArmPkg/
 Library/DefaultExceptionHandlerLib/AArch64/
 DefaultExceptionHandler.c(333): ((BOOLEAN) (0==1))

Cc: Oliver Steffen <osteffen@redhat.com>
Cc: Gerd Hoffmann <ghoffman@redhat.com>
Cc: Gavin Shan <gshan@redhat.com>
Cc: Shaoqin Huang <shahuang@redhat.com>
Signed-off-by: Zhenyu Zhang <zhenyzha12@gmail.com>
---
 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 7a1331255b81..901112ac5961 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -1943,6 +1943,7 @@ UpdateVariable (
           // Existing data size + new data size exceed maximum variable size limitation.
           //
           Status = EFI_INVALID_PARAMETER;
+          DEBUG ((DEBUG_ERROR, "ERROR: The variable store exceed maximum variable size limitation.\n"));
           goto Done;
         }
 
-- 
2.39.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107640): https://edk2.groups.io/g/devel/message/107640
Mute This Topic: https://groups.io/mt/100623349/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info
@ 2023-08-08 10:19 Zhenyu Zhang
  0 siblings, 0 replies; 5+ messages in thread
From: Zhenyu Zhang @ 2023-08-08 10:19 UTC (permalink / raw)
  To: devel; +Cc: zhenyzha12, michael.d.kinney, gaoliming, zhiguang.liu,
	Zhenyu Zhang

From: "Zhenyu Zhang" <zhenyzha@redhat.com>

When the variable store is full, edk2 will directly assert.
Add debug information to help users understand what caused
the assertion.

 Actual results:
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x7E
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize =
 0x3FF98
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x92
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98

 Synchronous Exception at 0x000000023CA60374
 ......
 ASSERT [ArmCpuDxe] /builddir/build/BUILD/edk2-f80f052277c8/ArmPkg/
 Library/DefaultExceptionHandlerLib/AArch64/
 DefaultExceptionHandler.c(333): ((BOOLEAN) (0==1))

Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
---
 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 7a1331255b81..901112ac5961 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -1943,6 +1943,7 @@ UpdateVariable (
           // Existing data size + new data size exceed maximum variable size limitation.

           //

           Status = EFI_INVALID_PARAMETER;

+          DEBUG ((DEBUG_ERROR, "ERROR: The variable store exceed maximum variable size limitation.\n"));

           goto Done;

         }

 

-- 
2.39.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107641): https://edk2.groups.io/g/devel/message/107641
Mute This Topic: https://groups.io/mt/100623349/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info
  2023-08-08  2:58 [edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info Zhenyu Zhang
@ 2023-08-21 14:41 ` Gerd Hoffmann
  0 siblings, 0 replies; 5+ messages in thread
From: Gerd Hoffmann @ 2023-08-21 14:41 UTC (permalink / raw)
  To: Zhenyu Zhang
  Cc: devel, michael.d.kinney, gaoliming, zhiguang.liu, osteffen,
	shahuang, shan.gavin

On Mon, Aug 07, 2023 at 10:58:26PM -0400, Zhenyu Zhang wrote:
> When the variable store is full, edk2 will directly assert.
> Add debug information to help users understand what caused
> the assertion.
> 
>  Actual results:
>  RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
>  48BCD90AD31A - 0x00000003 - 0x7E
>  CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize =
>  0x3FF98
>  RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
>  48BCD90AD31A - 0x00000003 - 0x92
>  CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98
> 
>  Synchronous Exception at 0x000000023CA60374
>  ......
>  ASSERT [ArmCpuDxe] /builddir/build/BUILD/edk2-f80f052277c8/ArmPkg/
>  Library/DefaultExceptionHandlerLib/AArch64/
>  DefaultExceptionHandler.c(333): ((BOOLEAN) (0==1))
> 
> Cc: Oliver Steffen <osteffen@redhat.com>
> Cc: Gerd Hoffmann <ghoffman@redhat.com>
> Cc: Gavin Shan <gshan@redhat.com>
> Cc: Shaoqin Huang <shahuang@redhat.com>
> Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>

You should also Cc the MdeModulePkg maintainers.

BaseTools/Scripts/GetMaintainer.py helps with finding them.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107921): https://edk2.groups.io/g/devel/message/107921
Mute This Topic: https://groups.io/mt/100623349/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info
@ 2023-08-22  2:14 Zhenyu Zhang
  0 siblings, 0 replies; 5+ messages in thread
From: Zhenyu Zhang @ 2023-08-22  2:14 UTC (permalink / raw)
  To: devel
  Cc: zhenyzha, Oliver Steffen, Gerd Hoffmann, Laszlo Ersek,
	Jian J Wang, Liming Gao, Hao A Wu

From: "Zhenyu Zhang" <zhenyzha@redhat.com>

When the variable store is full, edk2 will directly assert.
Add debug information to help users understand what caused
the assertion.

 Actual results:
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x7E
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize =
 0x3FF98
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x92
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98

 Synchronous Exception at 0x000000023CA60374
 ......
 ASSERT [ArmCpuDxe] /builddir/build/BUILD/edk2-f80f052277c8/ArmPkg/
 Library/DefaultExceptionHandlerLib/AArch64/
 DefaultExceptionHandler.c(333): ((BOOLEAN) (0==1))

Cc: Oliver Steffen <osteffen@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
---
 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 7a1331255b81..901112ac5961 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -1943,6 +1943,7 @@ UpdateVariable (
           // Existing data size + new data size exceed maximum variable size limitation.

           //

           Status = EFI_INVALID_PARAMETER;

+          DEBUG ((DEBUG_ERROR, "ERROR: The variable store exceed maximum variable size limitation.\n"));

           goto Done;

         }

 

-- 
2.39.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107940): https://edk2.groups.io/g/devel/message/107940
Mute This Topic: https://groups.io/mt/100623349/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-08-22  2:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08  2:58 [edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info Zhenyu Zhang
2023-08-21 14:41 ` Gerd Hoffmann
  -- strict thread matches above, loose matches on Subject: below --
2023-08-08  5:42 Zhenyu Zhangzhenyzha12@gmail.com
2023-08-08 10:19 Zhenyu Zhang
2023-08-22  2:14 Zhenyu Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox