public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhenyu Zhang" <zhenyzha@redhat.com>
To: devel@edk2.groups.io
Cc: zhenyzha12@gmail.com, michael.d.kinney@intel.com,
	gaoliming@byosoft.com.cn, zhiguang.liu@intel.com,
	"Zhenyu Zhang" <zhenyzha@redhat.com>
Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info
Date: Tue,  8 Aug 2023 06:19:27 -0400	[thread overview]
Message-ID: <20230808101927.2392291-1-zhenyzha@redhat.com> (raw)

From: "Zhenyu Zhang" <zhenyzha@redhat.com>

When the variable store is full, edk2 will directly assert.
Add debug information to help users understand what caused
the assertion.

 Actual results:
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x7E
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize =
 0x3FF98
 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
 48BCD90AD31A - 0x00000003 - 0x92
 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98

 Synchronous Exception at 0x000000023CA60374
 ......
 ASSERT [ArmCpuDxe] /builddir/build/BUILD/edk2-f80f052277c8/ArmPkg/
 Library/DefaultExceptionHandlerLib/AArch64/
 DefaultExceptionHandler.c(333): ((BOOLEAN) (0==1))

Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
---
 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 7a1331255b81..901112ac5961 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -1943,6 +1943,7 @@ UpdateVariable (
           // Existing data size + new data size exceed maximum variable size limitation.

           //

           Status = EFI_INVALID_PARAMETER;

+          DEBUG ((DEBUG_ERROR, "ERROR: The variable store exceed maximum variable size limitation.\n"));

           goto Done;

         }

 

-- 
2.39.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107641): https://edk2.groups.io/g/devel/message/107641
Mute This Topic: https://groups.io/mt/100623349/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2023-08-08 14:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 10:19 Zhenyu Zhang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-08-22  2:14 [edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info Zhenyu Zhang
2023-08-08  5:42 Zhenyu Zhangzhenyzha12@gmail.com
2023-08-08  2:58 Zhenyu Zhang
2023-08-21 14:41 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808101927.2392291-1-zhenyzha@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox