public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "VivianNK" <vnowkakeane@linux.microsoft.com>
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v1 0/7] Uncrustify GoogleTest update
Date: Wed,  9 Aug 2023 14:32:19 -0700	[thread overview]
Message-ID: <20230809213226.1387-1-vnowkakeane@linux.microsoft.com> (raw)

Introduce cpp-specific formatting rules to Uncrustify for readability:
 * indent_class: indent lines inside of a class
 * indent_extern: indent lines inside of an extern

Apply all Uncrustify formatting rules defined in the config to existing
cpp and header files (GoogleTest files).

Moving forward all GoogleTest files will be included in uncrustify
formatting checks, leading to more consistency and greater readability.

VivianNK (7):
  .pytool: Set uncrustify check to audit only
  .pytool: Add cpp support to uncrustify plugin
  MdeModulePkg: Applyy uncrustify formatting to relevant files.
  MdePkg: Apply uncrustify formatting to relevant files
  SecurityPkg: Apply uncrustify formatting to relevant files
  UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files
  .pytool: Undo uncrustify check change

 .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py                                                       |   2 +-
 .pytool/Plugin/UncrustifyCheck/uncrustify.cfg                                                           |   4 +-
 MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp                                   |  37 +-
 MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib.h                                |   4 +-
 MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPciHostBridgeLib.cpp                 |   8 +-
 MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests32.cpp                        | 114 ++--
 MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests64.cpp                        | 114 ++--
 MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp                                    | 563 ++++++++++----------
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h                                                |   6 +-
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h                                        |   6 +-
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h                                               |   4 +-
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTableLib.h                           |   4 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp                                           |  40 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServicesLib.cpp                           |  52 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp                                         |   6 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/MockUefiRuntimeServicesTableLib.cpp |  12 +-
 SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariableLibGoogleTest.cpp                | 205 ++++---
 SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtectionLib.h                          |   4 +-
 SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/MockPlatformPKProtectionLib.cpp    |   4 +-
 UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h                                                    |   2 +-
 UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoogleTest.cpp                       |  76 +--
 21 files changed, 664 insertions(+), 603 deletions(-)

-- 
2.41.0.windows.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107665): https://edk2.groups.io/g/devel/message/107665
Mute This Topic: https://groups.io/mt/100655288/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2023-08-10  0:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 21:32 VivianNK [this message]
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 1/7] .pytool: Set uncrustify check to audit only VivianNK
2023-08-15  1:06   ` Michael Kubacki
     [not found]   ` <177B69072E52D32F.12117@groups.io>
2023-08-15  1:22     ` Michael Kubacki
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 2/7] .pytool: Add cpp support to uncrustify plugin VivianNK
2023-08-15  1:22   ` Michael Kubacki
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 3/7] MdeModulePkg: Applyy uncrustify formatting to relevant files VivianNK
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 4/7] MdePkg: Apply " VivianNK
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 5/7] SecurityPkg: " VivianNK
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 6/7] UnitTestFrameworkPkg: " VivianNK
2023-08-10 19:25   ` Michael D Kinney
2023-08-15  1:22   ` Michael Kubacki
2023-08-09 21:32 ` [edk2-devel] [PATCH v1 7/7] .pytool: Undo uncrustify check change VivianNK
2023-08-15  1:28   ` Michael Kubacki
2023-08-15  1:32 ` [edk2-devel] [PATCH v1 0/7] Uncrustify GoogleTest update Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230809213226.1387-1-vnowkakeane@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox