[edk2-devel] [PATCH edk2-platforms 0/1] Enlarge firmware offsets

[edk2-devel] [PATCH edk2-platforms 0/1] Enlarge firmware offsets

[Marcin Juszkiewicz]

I am back from vacations. Started debug build and was greeted with
message that my firmware is too big:

GenFv: ERROR 3000: Invalid
  the required fv image size 0x216510 exceeds the set fv image size 0x200000

Which is weird as QemuSbsa uses 256MB flash images.

So as quick hack I decided to bump some offsets and check does it work.
It did but I am not sure is it the proper way.

Marcin Juszkiewicz (1):
  Platform/QemuSbsa: enlarge firmware offsets

 Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.41.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107796): https://edk2.groups.io/g/devel/message/107796
Mute This Topic: https://groups.io/mt/100783094/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: enlarge firmware offsets

[Marcin Juszkiewicz]

GenFv: ERROR 3000: Invalid
  the required fv image size 0x216510 exceeds the set fv image size 0x200000

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
index 677cea6344dc..bc432cac6fc8 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
@@ -58,20 +58,20 @@ [FD.SBSA_FLASH0]
 
 [FD.SBSA_FLASH1]
 BaseAddress   = 0x10000000|gArmTokenSpaceGuid.PcdFdBaseAddress
-Size          = 0x002C0000|gArmTokenSpaceGuid.PcdFdSize
+Size          = 0x003C0000|gArmTokenSpaceGuid.PcdFdSize
 ErasePolarity = 1
 BlockSize     = 0x00001000
-NumBlocks     = 0x2C0
+NumBlocks     = 0x3C0
 
 ## Place for EFI (BL33)
 # This offset (if any as it is 0x0 currently) + BaseAddress (0x10000000) must be set in PRELOADED_BL33_BASE at ATF
-0x00000000|0x00200000
+0x00000000|0x00300000
 gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
 FV = FVMAIN_COMPACT
 
 ## Place for Variables. They share flash1 with EFI
 # Must be aligned to Flash Block size 0x40000
-0x00200000|0x00040000
+0x00300000|0x00040000
 gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize
 #NV_VARIABLE_STORE
 DATA = {
@@ -109,7 +109,7 @@ [FD.SBSA_FLASH1]
   0x5A, 0xFE, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
 }
 
-0x00240000|0x00040000
+0x00340000|0x00040000
 gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize
 #NV_FTW_WORKING
 DATA = {
@@ -123,7 +123,7 @@ [FD.SBSA_FLASH1]
   0xE0, 0xFF, 0x03, 0x00, 0x00, 0x00, 0x00, 0x00
 }
 
-0x00280000|0x00040000
+0x00380000|0x00040000
 gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize
 #NV_FTW_SPARE
 
-- 
2.41.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107797): https://edk2.groups.io/g/devel/message/107797
Mute This Topic: https://groups.io/mt/100783095/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: enlarge firmware offsets

[Leif Lindholm]

On Wed, Aug 16, 2023 at 18:33:33 +0200, Marcin Juszkiewicz wrote:
> GenFv: ERROR 3000: Invalid
>   the required fv image size 0x216510 exceeds the set fv image size 0x200000
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

Presumably caused by the openssl3 shenanigans. But regardless, this
was an arbitrarily low size to begin with.

Pushed as 0f0cafb5defb. Thanks!

/
    Leif

> ---
>  Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> index 677cea6344dc..bc432cac6fc8 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> @@ -58,20 +58,20 @@ [FD.SBSA_FLASH0]
>  
>  [FD.SBSA_FLASH1]
>  BaseAddress   = 0x10000000|gArmTokenSpaceGuid.PcdFdBaseAddress
> -Size          = 0x002C0000|gArmTokenSpaceGuid.PcdFdSize
> +Size          = 0x003C0000|gArmTokenSpaceGuid.PcdFdSize
>  ErasePolarity = 1
>  BlockSize     = 0x00001000
> -NumBlocks     = 0x2C0
> +NumBlocks     = 0x3C0
>  
>  ## Place for EFI (BL33)
>  # This offset (if any as it is 0x0 currently) + BaseAddress (0x10000000) must be set in PRELOADED_BL33_BASE at ATF
> -0x00000000|0x00200000
> +0x00000000|0x00300000
>  gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
>  FV = FVMAIN_COMPACT
>  
>  ## Place for Variables. They share flash1 with EFI
>  # Must be aligned to Flash Block size 0x40000
> -0x00200000|0x00040000
> +0x00300000|0x00040000
>  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize
>  #NV_VARIABLE_STORE
>  DATA = {
> @@ -109,7 +109,7 @@ [FD.SBSA_FLASH1]
>    0x5A, 0xFE, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
>  }
>  
> -0x00240000|0x00040000
> +0x00340000|0x00040000
>  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize
>  #NV_FTW_WORKING
>  DATA = {
> @@ -123,7 +123,7 @@ [FD.SBSA_FLASH1]
>    0xE0, 0xFF, 0x03, 0x00, 0x00, 0x00, 0x00, 0x00
>  }
>  
> -0x00280000|0x00040000
> +0x00380000|0x00040000
>  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize
>  #NV_FTW_SPARE
>  
> -- 
> 2.41.0
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107827): https://edk2.groups.io/g/devel/message/107827
Mute This Topic: https://groups.io/mt/100783095/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-