From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 98B61D800C4 for ; Wed, 16 Aug 2023 20:13:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=HgWJgc4/nRoqjUbWzhgK4Yx1BogeZGQ/BxcAvBUtGLU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1692216793; v=1; b=L69tnX9dV5kSan/IfQEQOL4oLLJctPMtEx9xw7EapZ2bgHy9um+XKMmbxAEVj+ISbFMJltFY /k/J1VZbQmMqTQ1e1zYqXEOja0dcD2gHNBlOY3TLhKvAu4WTod/oiQEjIS6xnXF42IUdMiSvm5s OMtLJD8DeDnupehpVKc7gDgc= X-Received: by 127.0.0.2 with SMTP id zc6nYY7687511x9R0fMGZSU6; Wed, 16 Aug 2023 13:13:13 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.56]) by mx.groups.io with SMTP id smtpd.web10.170997.1692216792539632869 for ; Wed, 16 Aug 2023 13:13:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eSDgZtEXzVTjHWuAv6nCNl2j1W7gE8wJ7gNrRKf0dI5eb5KiZ4GHIh/Pjtu1nMkg8sC/vBXapSSkYHbDNvuai6FpQzCtYTTRE8hAvK70gMS+m0DUPBX9FNAya6wHzcQShjcNvPWy8E/B3M2v+CWyFh8sbpQXDJQsIFk7No2HmE1xkBud5A4eOqBNYLVZZWvfU4cVWBaSqyALAKAus5ubNjV7B11+QLMykXmKW+N5mAXtvX1klk1TzqR7Zl4vU+W8XWHIaLkqPUea7cL4jkEIgNG+yVDlsmQE1+JY9UYvu4rDNA0ZqOBpBCbkAiUgZLbnnVDtZVABu8xh/k7kGpMVHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fMsSZ3kHSoCin+mcYEFMgNjfh02XDHyiT8dZRQNwuPs=; b=V9lueexAnG+WAQ5iH0LRYL3P9OFWfnK0iyNdq0EKAZS6sFPJVOEYDQojEu/WXHCPFWZ07IcntS43wZG2XLMvUN7AtPENPGcri24tHJnurMkikVwH+BoB2W++e+GNxND4I6no9uf6sUcPwHRPsrqupnqWcwVNh4HlqQnh6oteL7hkGyxBvf6nXPVv682DfnLXmhD46qmx0gR3XYVEMb7YncsLWS2Q3gIaaOI3LDg35eWpH9ePw3kY3BWl0QY/YrnGS/UXDWd32Y/9L3+ar12hTRUXNA1Mt6SK06Rr3caAvmZUcfe3w03d7BxevDyFPhzQCu+M17ea19YKBRy1dayKzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from CH2PR16CA0030.namprd16.prod.outlook.com (2603:10b6:610:50::40) by BL1PR12MB5272.namprd12.prod.outlook.com (2603:10b6:208:319::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.29; Wed, 16 Aug 2023 20:13:08 +0000 X-Received: from SN1PEPF0002636A.namprd02.prod.outlook.com (2603:10b6:610:50:cafe::b2) by CH2PR16CA0030.outlook.office365.com (2603:10b6:610:50::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.33 via Frontend Transport; Wed, 16 Aug 2023 20:13:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002636A.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6699.14 via Frontend Transport; Wed, 16 Aug 2023 20:13:08 +0000 X-Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 16 Aug 2023 15:13:07 -0500 From: "Roth, Michael via groups.io" To: CC: YuanhaoXie , Tom Lendacky , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann , Ard Biesheuvel , Jiewen Yao , Jordan Justen , "Erdem Aktas" , James Bottomley , Min Xu Subject: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti Date: Wed, 16 Aug 2023 15:11:46 -0500 Message-ID: <20230816201146.1634348-3-michael.roth@amd.com> In-Reply-To: <20230816201146.1634348-1-michael.roth@amd.com> References: <20230816201146.1634348-1-michael.roth@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636A:EE_|BL1PR12MB5272:EE_ X-MS-Office365-Filtering-Correlation-Id: ba155e42-f60b-46ef-beb6-08db9e95354b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: rV7E2vl53tLG5DgEHvQDBVPo0shp9AGhAIpSSl90e/R1CV0wgSdbRjruXBkDkSFZy3Gk9dgMAa7lnlIosdDzeZUpoiJSAqJ09T0fbFc854cdWl/A5aHwJcSQ7yco3P4gmUIbGqeL7h53aPf83srpnuvWUpq02wPZGT8E5NmlVfgY+1mouPneVINrEZf++BP9r860X9vGfzeXy0IQgfSO9rx6609xPFqfuh6OIA+NwdaTQrje5slgYHktJbIBAl+8UScqefvVVzgOGnJG3A5W9vqY8o61ggdMoOInC70EY30ibVYlAXYzMQRG8fg+0plkCZd4/u/KvUrFcJ+vGQ7LdD9CeLYCCBfGLi/3ioBEWbziyqDuxlD6vX3Uy1JBdatVRp6ATneSW6iZK4Alirnjt+CCgwWP8wMAW20miRLsQBj7Sk613kfjKDIdEaB9JNLGof9taMCzgng6NEz/Ue5BEMH9S2tHwkBlKa6/cvYI/Y/GFbLv4Rd9vKmbxzWgcvMet9CRJh1ezAA0ot2lqKbs1CUG0iMNERZ4MV7jNJfGLdz/z4iv3ej7FGJccHmH/4yVhquscWK6Z6cZrXjOSRhwa9agpD+IiGmzs9BMAS3ujztc8x32gr5M2D3sAi7CYgVlf8ipEh8Y3BFcpsI+ZTrCnxC7MCifnITVNZ3qDWMnikVpjL+CLpm6LEqxLpvtWR9GT4m/ZHnSFbCR8M7UBAZsBgPFDVYx3eXPbtJ/Fvuo1hGY5JWU0ExONg3GmsW9ZK7qWI+ppDmf2+2afEYDBUUO4mquxjMBZMBteFZi6Tx51IM= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 20:13:08.3904 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba155e42-f60b-46ef-beb6-08db9e95354b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5272 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Michael.Roth@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: foM1USrnq7CXU1lOMzm62Xudx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=L69tnX9d; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is true by default, but needs to be disabled for QEMU/OVMF where early INIT is not simulated. Commit 1d76560146 ("OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.") added changes to disable it by default for OvmfPkg, but a similar change was not made for the AmdSev package. This breaks booting of SEV and SNP guests. Fix this defaulting PcdFirstTimeWakeUpAPsBySipi to false for AmdSev package, as was previously done for OvmfPkg variants. Fixes: eaffa1d7ff ("UefiCpuPkg:Wake up APs after power-up or RESET through = SIPI.") Cc: YuanhaoXie Cc: Tom Lendacky Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Erdem Aktas Cc: James Bottomley Cc: Min Xu Signed-off-by: Michael Roth --- OvmfPkg/AmdSev/AmdSevX64.dsc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc index f43300a95e..cf058f6a05 100644 --- a/OvmfPkg/AmdSev/AmdSevX64.dsc +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc @@ -469,6 +469,14 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDemand|TRUE gUefiOvmfPkgTokenSpaceGuid.PcdBootRestrictToFirmware|TRUE =20 + # + # INIT is now triggered before BIOS by ucode/hardware. In the OVMF + # environment, QEMU lacks a simulation for the INIT process. + # To address this, PcdFirstTimeWakeUpAPsBySipi set to FALSE to + # broadcast INIT-SIPI-SIPI for the first time. + # + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE + ##########################################################################= ###### # # Pcd Dynamic Section - list of all EDK II PCD Entries defined by this Pla= tform --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107807): https://edk2.groups.io/g/devel/message/107807 Mute This Topic: https://groups.io/mt/100787520/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-