[edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

[edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

[Yuanhao Xie]

Deactivate PcdFirstTimeWakeUpAPsBySipi for AMD SEV and SNP to preserve
the original execution of INIT-SIPI-SIPI.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
---
 OvmfPkg/AmdSev/AmdSevX64.dsc | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
index 2c6ed7c974..af52438fb2 100644
--- a/OvmfPkg/AmdSev/AmdSevX64.dsc
+++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
@@ -467,6 +467,13 @@
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDemand|TRUE
   gUefiOvmfPkgTokenSpaceGuid.PcdBootRestrictToFirmware|TRUE
+  #
+  # PcdFirstTimeWakeUpAPsBySipi determines whether to employ
+  # SIPI instead of the INIT-SIPI-SIPI sequence during APs
+  # initialization. Deactivate this parameter for AMD SEV and
+  #  SNP to preserve the original execution of INIT-SIPI-SIPI.
+  #
+  gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE
 
 ################################################################################
 #
-- 
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107823): https://edk2.groups.io/g/devel/message/107823
Mute This Topic: https://groups.io/mt/100794448/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

[Yuanhao Xie]

Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to
preserve the original execution of INIT-SIPI-SIPI.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
---
 OvmfPkg/IntelTdx/IntelTdxX64.dsc | 8 ++++++++
 OvmfPkg/Microvm/MicrovmX64.dsc   | 8 ++++++++
 OvmfPkg/OvmfXen.dsc              | 8 ++++++++
 3 files changed, 24 insertions(+)

diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
index 193657ff2d..80b0558c3f 100644
--- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc
+++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
@@ -463,6 +463,14 @@
   # Point to the MdeModulePkg/Application/UiApp/UiApp.inf
   gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
 
+  #
+  # PcdFirstTimeWakeUpAPsBySipi determines whether to employ
+  # SIPI instead of the INIT-SIPI-SIPI sequence during APs
+  # initialization. Deactivate this parameter to preserve
+  # the original execution of INIT-SIPI-SIPI.
+  #
+  gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE
+
 ################################################################################
 #
 # Pcd Dynamic Section - list of all EDK II PCD Entries defined by this Platform
diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
index 2f75856393..d2ef1e00a5 100644
--- a/OvmfPkg/Microvm/MicrovmX64.dsc
+++ b/OvmfPkg/Microvm/MicrovmX64.dsc
@@ -566,6 +566,14 @@
   gEfiMdeModulePkgTokenSpaceGuid.PcdSerialPciDeviceInfo|{0xFF}
   gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
 
+  #
+  # PcdFirstTimeWakeUpAPsBySipi determines whether to employ
+  # SIPI instead of the INIT-SIPI-SIPI sequence during APs
+  # initialization. Deactivate this parameter to preserve
+  # the original execution of INIT-SIPI-SIPI.
+  #
+  gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE
+
 ################################################################################
 #
 # Pcd Dynamic Section - list of all EDK II PCD Entries defined by this Platform
diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
index 210578c1d7..dcb99d1f0b 100644
--- a/OvmfPkg/OvmfXen.dsc
+++ b/OvmfPkg/OvmfXen.dsc
@@ -458,6 +458,14 @@
   # We populate DXE IPL tables with 1G pages preferably on Xen
   gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE
 
+  #
+  # PcdFirstTimeWakeUpAPsBySipi determines whether to employ
+  # SIPI instead of the INIT-SIPI-SIPI sequence during APs
+  # initialization. Deactivate this parameter to preserve
+  # the original execution of INIT-SIPI-SIPI.
+  #
+  gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE
+
 ################################################################################
 #
 # Pcd Dynamic Section - list of all EDK II PCD Entries defined by this Platform
-- 
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107939): https://edk2.groups.io/g/devel/message/107939
Mute This Topic: https://groups.io/mt/100887108/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

[Gerd Hoffmann]

On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote:
> Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to
> preserve the original execution of INIT-SIPI-SIPI.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107945): https://edk2.groups.io/g/devel/message/107945
Mute This Topic: https://groups.io/mt/100887108/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

[Gerd Hoffmann]

On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote:
> Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to
> preserve the original execution of INIT-SIPI-SIPI.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

Can we merge this now?

thanks,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108283): https://edk2.groups.io/g/devel/message/108283
Mute This Topic: https://groups.io/mt/100887108/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

[Ard Biesheuvel]

On Tue, 5 Sept 2023 at 15:34, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote:
> > Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to
> > preserve the original execution of INIT-SIPI-SIPI.
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Can we merge this now?
>

AFAICT this one is merged already.

I'm merging the AmdSev one now.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108284): https://edk2.groups.io/g/devel/message/108284
Mute This Topic: https://groups.io/mt/100887108/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

[Gerd Hoffmann]

On Tue, Sep 05, 2023 at 03:38:49PM +0200, Ard Biesheuvel wrote:
> On Tue, 5 Sept 2023 at 15:34, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote:
> > > Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to
> > > preserve the original execution of INIT-SIPI-SIPI.
> >
> > Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> >
> > Can we merge this now?
> 
> AFAICT this one is merged already.

Right, it's in (commit 020cc9e2e7053bb62247b0babbbe80cb855592e5).

> I'm merging the AmdSev one now.

Thanks.

The other AmdSev fix from the same series is needed too.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108286): https://edk2.groups.io/g/devel/message/108286
Mute This Topic: https://groups.io/mt/100887108/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

[Ard Biesheuvel]

On Tue, 5 Sept 2023 at 16:18, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Tue, Sep 05, 2023 at 03:38:49PM +0200, Ard Biesheuvel wrote:
> > On Tue, 5 Sept 2023 at 15:34, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > >
> > > On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote:
> > > > Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to
> > > > preserve the original execution of INIT-SIPI-SIPI.
> > >
> > > Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> > >
> > > Can we merge this now?
> >
> > AFAICT this one is merged already.
>
> Right, it's in (commit 020cc9e2e7053bb62247b0babbbe80cb855592e5).
>
> > I'm merging the AmdSev one now.
>
> Thanks.
>
> The other AmdSev fix from the same series is needed too.
>

OK now merging that as well.

Thanks,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108287): https://edk2.groups.io/g/devel/message/108287
Mute This Topic: https://groups.io/mt/100887108/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-