From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 21AAC740032 for ; Fri, 18 Aug 2023 18:17:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=i/5g+UZsD2fi1GZl7dZHYvjBhUC9p6AJceV0Q+RmaTU=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1692382677; v=1; b=Ywx+KFT8AA1/I2Ajf0RmnTP94/OM+J0HtQs6rwhCuq+4RP4xJ4Bxs59uZjynhM1a0qdjU7cb RGiPlukOckB6Fd0PbJ9+EQk1sgILV2818zpOm7qMzPbyLENTN4SO4KIexWSDSZHEXlcZhoacrEZ ZBgRAMmT3O3Lb0Z+w0NwdY9g= X-Received: by 127.0.0.2 with SMTP id MajxYY7687511x5NCoccd08r; Fri, 18 Aug 2023 11:17:57 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.1608.1692382677117501293 for ; Fri, 18 Aug 2023 11:17:57 -0700 X-Received: from OSD-Desktop.redmond.corp.microsoft.com (unknown [131.107.1.171]) by linux.microsoft.com (Postfix) with ESMTPSA id A0DDD211F7DE; Fri, 18 Aug 2023 11:17:56 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A0DDD211F7DE From: "Oliver Smith-Denny" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Gerd Hoffmann Subject: [edk2-devel][PATCH v1 1/1] ArmVirtPkg: ArmVirtQemu: Add Graphics and Input Date: Fri, 18 Aug 2023 11:17:51 -0700 Message-Id: <20230818181751.12308-1-osde@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vPrjyYzKlxyI4LSWcF4BiIy9x7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ywx+KFT8; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Currently, unlike OVMF, ArmVirtQemu does not display any graphics, only the QEMU monitor. Graphics are helpful to confirm booting into an OS is successful, interacting with the EFI shell while getting separate logging messages, etc. This patch adds the QEMU parameters to launch a graphical window and add a USB keyboard and mouse, which is modeled as a tablet as it tracks better in QEMU than a generic mouse. virtio-gpu-pci is chosen as the graphics device as it is recommended by QEMU for the ARM virtual platform. The graphics and USB input devices will only be added to QEMU when QEMU_HEADLESS =3D=3D FALSE, so CI builds will not attempt to use the graphics and if a user does not want graphics, they can add QEMU_HEADLESS=3DTRUE to the build cmdline. GitHub PR: https://github.com/tianocore/edk2/pull/4750 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Oliver Smith-Denny --- ArmVirtPkg/PlatformCI/PlatformBuildLib.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ArmVirtPkg/PlatformCI/PlatformBuildLib.py b/ArmVirtPkg/Platf= ormCI/PlatformBuildLib.py index 405817cae785..0ddaccf9c21f 100644 --- a/ArmVirtPkg/PlatformCI/PlatformBuildLib.py +++ b/ArmVirtPkg/PlatformCI/PlatformBuildLib.py @@ -244,6 +244,11 @@ class PlatformBuilder(UefiBuilder, BuildSettingsMana= ger): # Conditional Args if (self.env.GetValue("QEMU_HEADLESS").upper() =3D=3D "TRUE"): args +=3D " -display none" # no graphics + else: + args +=3D " -device virtio-gpu-pci" = # add recommended QEMU graphics device + args +=3D " -device qemu-xhci,id=3Dusb" = # add USB support for below devices + args +=3D " -device usb-tablet,id=3Dinput0,bus=3Dusb.0,port=3D= 1" # add a usb mouse + args +=3D " -device usb-kbd,id=3Dinput1,bus=3Dusb.0,port=3D2= " # add a usb keyboard =20 if (self.env.GetValue("MAKE_STARTUP_NSH").upper() =3D=3D "TRUE")= : f =3D open(os.path.join(VirtualDrive, "startup.nsh"), "w") --=20 2.40.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107853): https://edk2.groups.io/g/devel/message/107853 Mute This Topic: https://groups.io/mt/100826022/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-