From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EFB9EAC1948 for ; Tue, 22 Aug 2023 18:24:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Cg+Zff1pp3P3e7mKAM0moVk+gkPPI/Ow5el55knxL5E=; c=relaxed/simple; d=groups.io; h=From:To:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1692728640; v=1; b=vOsT8Kme4Frx4I1TdZ7vMJEjoZR3P92/h0ldHno91HY+3U36GFSmc9VyACaVvePLd2xxbwgF dYI6DDd+MjT5akE1TDNI+FFx/PW82BLUlbtmkyp9NpjVpq+SZ542PqWTByRJW4hnVWzQOohkxJM dPig0S/oJK51S7nXYhSf1omU= X-Received: by 127.0.0.2 with SMTP id CvsZYY7687511x1N53Ny4VPg; Tue, 22 Aug 2023 11:24:00 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.3656.1692728639716211755 for ; Tue, 22 Aug 2023 11:24:00 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B128E11FB for ; Tue, 22 Aug 2023 11:24:39 -0700 (PDT) X-Received: from beelzebub.ast.arm.com (abhsin07-ThinkStation-P720.austin.arm.com [10.118.30.31]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C3AB23F762 for ; Tue, 22 Aug 2023 11:23:58 -0700 (PDT) From: "Abhimanyu Singh" To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning Date: Tue, 22 Aug 2023 13:23:54 -0500 Message-Id: <20230822182354.79292-1-Abhi.Singh@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Abhi.Singh@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xp6wBsA1zb0rTmBPlX4sklyMx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vOsT8Kme; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3759 HIIConfigAccess and HIIConfigRouting Protocol RouteConfig tests assertions store a failure when RouteConfig returns EFI_ACCESS_DENIED. In the UEFI SPEC RouteConfig in both protocols can return EFI_ACCESS_DENIED when the action violates a system policy. The tests now record a pass with warning. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Sunny Wang Signed-off-by: Abhi Singh Change-Id: I8591c3d7b0855133141779d3c53a159129400815 --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HI= IConfigAccessBBTestFunction.c | 2 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/H= IIConfigRoutingBBTestFunction.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/Bla= ckBoxTest/HIIConfigAccessBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/E= FI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c index b3276487bb3c..8e46b547bdfe 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTe= st/HIIConfigAccessBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTe= st/HIIConfigAccessBBTestFunction.c @@ -521,7 +521,7 @@ BBTestRouteConfigFunctionTestCheckpoint1 ( );=0D if ( (EFI_SUCCESS =3D=3D Status) && (Progress =3D=3D Resp + SctStrLen (R= esp)) ) {=0D AssertionType =3D EFI_TEST_ASSERTION_PASSED;=0D - } else if ( EFI_OUT_OF_RESOURCES =3D=3D Status ) {=0D + } else if ( (EFI_OUT_OF_RESOURCES =3D=3D Status) || (EFI_ACCESS_DENIED = =3D=3D Status) ) {=0D AssertionType =3D EFI_TEST_ASSERTION_WARNING;=0D } else {=0D AssertionType =3D EFI_TEST_ASSERTION_FAILED;=0D diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/Bl= ackBoxTest/HIIConfigRoutingBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI= /EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestFunction.c index d4bd23d1fd82..9d7a7dcf42e2 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxT= est/HIIConfigRoutingBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxT= est/HIIConfigRoutingBBTestFunction.c @@ -546,7 +546,7 @@ BBTestRouteConfigFunctionTestCheckpoint1 ( =0D if ( (EFI_SUCCESS =3D=3D Status) && (Progress =3D=3D Resp2 + SctStrLen (= Resp2)) ) {=0D AssertionType =3D EFI_TEST_ASSERTION_PASSED;=0D - } else if ( EFI_OUT_OF_RESOURCES =3D=3D Status ){=0D + } else if ( (EFI_OUT_OF_RESOURCES =3D=3D Status) || (EFI_ACCESS_DENIED = =3D=3D Status) ) {=0D AssertionType =3D EFI_TEST_ASSERTION_WARNING;=0D } else {=0D AssertionType =3D EFI_TEST_ASSERTION_FAILED;=0D --=20 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107958): https://edk2.groups.io/g/devel/message/107958 Mute This Topic: https://groups.io/mt/100899969/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-