From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 806F694165F for ; Tue, 29 Aug 2023 08:01:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KhwbLxdmyR6Cihbe3iHWZVdJEbieuzCJf+Shl0MYbyY=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693296084; v=1; b=HFjGHgoA1HFdDZdUgXh+xjXH28hRqXAZeFs2l9s21PmN56PLW4XkfsM2pwX1dBAiF/CiKBZU ThUKckHMEZ2TDqdprtxnyB8DHmIaBYj55oQqMz7nfqq1AElVLfYqnEzDTwNdcGLrpvLZYlbzsg3 WhyTgmDRLNIQq9RdCdhOqsk8= X-Received: by 127.0.0.2 with SMTP id IeFQYY7687511xKn7iwZ5mrt; Tue, 29 Aug 2023 01:01:24 -0700 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web11.12655.1693296083132047584 for ; Tue, 29 Aug 2023 01:01:23 -0700 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2bcb50e194dso61921461fa.3 for ; Tue, 29 Aug 2023 01:01:22 -0700 (PDT) X-Gm-Message-State: MhvJf439bxHXxYnTYuLDyyAJx7686176AA= X-Google-Smtp-Source: AGHT+IExhTXTKl/NMvFSvJo3X+2+tLmNsN0vZXlnIwRcGyiOp6MOoO5ajdWGfTQEhRT3ZesLiaujQw== X-Received: by 2002:a2e:8687:0:b0:2bc:d993:bdaa with SMTP id l7-20020a2e8687000000b002bcd993bdaamr14370585lji.18.1693296081020; Tue, 29 Aug 2023 01:01:21 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h10-20020a2e900a000000b002ba130e9a29sm2077325ljg.76.2023.08.29.01.01.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 29 Aug 2023 01:01:20 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data Date: Tue, 29 Aug 2023 11:01:09 +0300 Message-Id: <20230829080112.12748-4-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-1-mike.maslenkin@gmail.com> References: <20230829080112.12748-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HFjGHgoA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++++ .../Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe.c | 4 ++++ RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index f5562fb49cab..32dca964aa0a 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -220,6 +220,10 @@ RedfishResourceConsumeResource ( Private->Json =3D NULL;=0D }=0D =0D + if (Etag !=3D NULL) {=0D + FreePool (Etag);=0D + }=0D +=0D return Status;=0D }=0D =0D diff --git a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSy= stemDxe.c b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSys= temDxe.c index 91968dbe488f..5c2a4eadf2f4 100644 --- a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe= .c +++ b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe= .c @@ -164,6 +164,10 @@ RedfishResourceConsumeResource ( Private->Json =3D NULL;=0D }=0D =0D + if (Etag !=3D NULL) {=0D + FreePool (Etag);=0D + }=0D +=0D return Status;=0D }=0D =0D diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c b/Redf= ishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c index c55a6848c74e..f34f3266f1ee 100644 --- a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c @@ -164,6 +164,10 @@ RedfishResourceConsumeResource ( Private->Json =3D NULL;=0D }=0D =0D + if (Etag !=3D NULL) {=0D + FreePool (Etag);=0D + }=0D +=0D return Status;=0D }=0D =0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108081): https://edk2.groups.io/g/devel/message/108081 Mute This Topic: https://groups.io/mt/101027005/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-