[edk2-devel] [edk2-libc Patch 0/1] python socket module fails with GCC compiler

[edk2-devel] [edk2-libc Patch 0/1] python socket module fails with GCC compiler

[Jayaprakash, N]

This patch fixes the compilation issue of Python UEFI interpreters socket
module due to duplicate definitions of certain structures as reported 
in BZ 4545.

Jayaprakash N (1):
  ek2-libc: socket module of python UEFI fails to compile with GCC

 .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.40.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108199): https://edk2.groups.io/g/devel/message/108199
Mute This Topic: https://groups.io/mt/101077158/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI fails to compile with GCC

[Jayaprakash, N]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4545

The compilation issues reported in the BZ are fixed by
defining below 2 macros in pyconfig.h
HAVE_ADDRINFO
HAVE_SOCKADDR_STORAGE

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jayaprakash N <n.jayaprakash@intel.com>
Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
---
 .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
index 3b9eceb..983cfda 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
+++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
@@ -66,7 +66,7 @@
 #undef HAVE_ACOSH
 
 /* struct addrinfo (netdb.h) */
-#undef HAVE_ADDRINFO
+#define HAVE_ADDRINFO   1
 
 /* Define to 1 if you have the 'alarm' function. */
 #undef HAVE_ALARM
@@ -683,7 +683,7 @@
 #undef HAVE_SOCKADDR_SA_LEN
 
 /* struct sockaddr_storage (sys/socket.h) */
-#undef HAVE_SOCKADDR_STORAGE
+#define HAVE_SOCKADDR_STORAGE   1
 
 /* Define if you have the 'socketpair' function. */
 #undef HAVE_SOCKETPAIR
-- 
2.40.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108200): https://edk2.groups.io/g/devel/message/108200
Mute This Topic: https://groups.io/mt/101077159/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI fails to compile with GCC

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: Jayaprakash, N <n.jayaprakash@intel.com>
> Sent: Thursday, August 31, 2023 9:13 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N <n.jayaprakash@intel.com>; Rebecca Cran
> <rebecca@bsdio.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI
> fails to compile with GCC
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4545
> 
> The compilation issues reported in the BZ are fixed by
> defining below 2 macros in pyconfig.h
> HAVE_ADDRINFO
> HAVE_SOCKADDR_STORAGE
> 
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> ---
>  .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h        | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h
> index 3b9eceb..983cfda 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h
> @@ -66,7 +66,7 @@
>  #undef HAVE_ACOSH
> 
>  /* struct addrinfo (netdb.h) */
> -#undef HAVE_ADDRINFO
> +#define HAVE_ADDRINFO   1
> 
>  /* Define to 1 if you have the 'alarm' function. */
>  #undef HAVE_ALARM
> @@ -683,7 +683,7 @@
>  #undef HAVE_SOCKADDR_SA_LEN
> 
>  /* struct sockaddr_storage (sys/socket.h) */
> -#undef HAVE_SOCKADDR_STORAGE
> +#define HAVE_SOCKADDR_STORAGE   1
> 
>  /* Define if you have the 'socketpair' function. */
>  #undef HAVE_SOCKETPAIR
> --
> 2.40.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108202): https://edk2.groups.io/g/devel/message/108202
Mute This Topic: https://groups.io/mt/101077159/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-