[edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues

[edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues

[Mike Maslenkin]

Please, find trivial memory leak fixes on error path.

The only question: is it required to use FreePool() or CoreFreePool()
from DXE core code? Patch 2/2 is made in accordance with existing code.

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108220): https://edk2.groups.io/g/devel/message/108220
Mute This Topic: https://groups.io/mt/101085561/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVol.c

[Mike Maslenkin]

FwVolHeader must be deallocated on error path.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 MdeModulePkg/Core/Dxe/FwVol/FwVol.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
index 153bfecafa77..0c1554ba4d63 100644
--- a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
+++ b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
@@ -659,6 +659,7 @@ NotifyFwVolBlock (
       //
       FvDevice = AllocateCopyPool (sizeof (FV_DEVICE), &mFvDevice);
       if (FvDevice == NULL) {
+        CoreFreePool (FwVolHeader);
         return;
       }
 
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108221): https://edk2.groups.io/g/devel/message/108221
Mute This Topic: https://groups.io/mt/101085563/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 2/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVolBlock.c

[Mike Maslenkin]

FvbDev->LbaCache must be freed on error path before deallocating FvbDev.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
index d81334ce24d1..9f5f40e5cd49 100644
--- a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
+++ b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
@@ -551,6 +551,7 @@ ProduceFVBProtocolOnBuffer (
     //
     FvbDev->DevicePath = (EFI_DEVICE_PATH_PROTOCOL *)AllocateCopyPool (sizeof (FV_MEMMAP_DEVICE_PATH), &mFvMemmapDevicePathTemplate);
     if (FvbDev->DevicePath == NULL) {
+      FreePool (FvbDev->LbaCache);
       FreePool (FvbDev);
       return EFI_OUT_OF_RESOURCES;
     }
@@ -563,6 +564,7 @@ ProduceFVBProtocolOnBuffer (
     //
     FvbDev->DevicePath = (EFI_DEVICE_PATH_PROTOCOL *)AllocateCopyPool (sizeof (FV_PIWG_DEVICE_PATH), &mFvPIWGDevicePathTemplate);
     if (FvbDev->DevicePath == NULL) {
+      FreePool (FvbDev->LbaCache);
       FreePool (FvbDev);
       return EFI_OUT_OF_RESOURCES;
     }
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108222): https://edk2.groups.io/g/devel/message/108222
Mute This Topic: https://groups.io/mt/101085565/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues

[Michael D Kinney]

Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, August 31, 2023 5:11 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike Maslenkin
> <mike.maslenkin@gmail.com>
> Subject: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> 
> Please, find trivial memory leak fixes on error path.
> 
> The only question: is it required to use FreePool() or CoreFreePool()
> from DXE core code? Patch 2/2 is made in accordance with existing code.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108463): https://edk2.groups.io/g/devel/message/108463
Mute This Topic: https://groups.io/mt/101085561/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVol.c

[Michael D Kinney]

+Jian

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, August 31, 2023 5:11 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike Maslenkin
> <mike.maslenkin@gmail.com>
> Subject: [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in
> FwVol.c
> 
> FwVolHeader must be deallocated on error path.
> 
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  MdeModulePkg/Core/Dxe/FwVol/FwVol.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
> b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
> index 153bfecafa77..0c1554ba4d63 100644
> --- a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
> +++ b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
> @@ -659,6 +659,7 @@ NotifyFwVolBlock (
>        //
> 
>        FvDevice = AllocateCopyPool (sizeof (FV_DEVICE), &mFvDevice);
> 
>        if (FvDevice == NULL) {
> 
> +        CoreFreePool (FwVolHeader);
> 
>          return;
> 
>        }
> 
> 
> 
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108464): https://edk2.groups.io/g/devel/message/108464
Mute This Topic: https://groups.io/mt/101085563/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVolBlock.c

[Michael D Kinney]

+Jian

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, August 31, 2023 5:11 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike Maslenkin
> <mike.maslenkin@gmail.com>
> Subject: [PATCH 2/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in
> FwVolBlock.c
> 
> FvbDev->LbaCache must be freed on error path before deallocating FvbDev.
> 
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> index d81334ce24d1..9f5f40e5cd49 100644
> --- a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> +++ b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> @@ -551,6 +551,7 @@ ProduceFVBProtocolOnBuffer (
>      //
> 
>      FvbDev->DevicePath = (EFI_DEVICE_PATH_PROTOCOL *)AllocateCopyPool
> (sizeof (FV_MEMMAP_DEVICE_PATH), &mFvMemmapDevicePathTemplate);
> 
>      if (FvbDev->DevicePath == NULL) {
> 
> +      FreePool (FvbDev->LbaCache);
> 
>        FreePool (FvbDev);
> 
>        return EFI_OUT_OF_RESOURCES;
> 
>      }
> 
> @@ -563,6 +564,7 @@ ProduceFVBProtocolOnBuffer (
>      //
> 
>      FvbDev->DevicePath = (EFI_DEVICE_PATH_PROTOCOL *)AllocateCopyPool
> (sizeof (FV_PIWG_DEVICE_PATH), &mFvPIWGDevicePathTemplate);
> 
>      if (FvbDev->DevicePath == NULL) {
> 
> +      FreePool (FvbDev->LbaCache);
> 
>        FreePool (FvbDev);
> 
>        return EFI_OUT_OF_RESOURCES;
> 
>      }
> 
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108465): https://edk2.groups.io/g/devel/message/108465
Mute This Topic: https://groups.io/mt/101085565/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues

[Michael D Kinney]

Hi Mike,

I have created a PR to run EDK II CI while we wait for a 
review from one of the DXE Core Maintainers

https://github.com/tianocore/edk2/pull/4815

Mike


> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, September 8, 2023 2:40 PM
> To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> 
> Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> 
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Thursday, August 31, 2023 5:11 PM
> > To: devel@edk2.groups.io
> > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>;
> > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike Maslenkin
> > <mike.maslenkin@gmail.com>
> > Subject: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> >
> > Please, find trivial memory leak fixes on error path.
> >
> > The only question: is it required to use FreePool() or CoreFreePool()
> > from DXE core code? Patch 2/2 is made in accordance with existing code.
> >
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108466): https://edk2.groups.io/g/devel/message/108466
Mute This Topic: https://groups.io/mt/101085561/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues

[gaoliming via groups.io]

Fort this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> Kinney
> 发送时间: 2023年9月9日 5:50
> 收件人: Mike Maslenkin <mike.maslenkin@gmail.com>;
> devel@edk2.groups.io
> 抄送: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> 主题: Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory
> leak issues
> 
> Hi Mike,
> 
> I have created a PR to run EDK II CI while we wait for a
> review from one of the DXE Core Maintainers
> 
> https://github.com/tianocore/edk2/pull/4815
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Friday, September 8, 2023 2:40 PM
> > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: RE: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> >
> > Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Thursday, August 31, 2023 5:11 PM
> > > To: devel@edk2.groups.io
> > > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > > <gaoliming@byosoft.com.cn>; Kinney, Michael D
> > <michael.d.kinney@intel.com>;
> > > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike
> Maslenkin
> > > <mike.maslenkin@gmail.com>
> > > Subject: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> > >
> > > Please, find trivial memory leak fixes on error path.
> > >
> > > The only question: is it required to use FreePool() or CoreFreePool()
> > > from DXE core code? Patch 2/2 is made in accordance with existing
code.
> > >
> > > Cc: Dandan Bi <dandan.bi@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > >
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108470): https://edk2.groups.io/g/devel/message/108470
Mute This Topic: https://groups.io/mt/101284117/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues

[Michael D Kinney]

Merged: https://github.com/tianocore/edk2/pull/4815


> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Sunday, September 10, 2023 5:55 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>;
> 'Mike Maslenkin' <mike.maslenkin@gmail.com>
> Cc: Bi, Dandan <dandan.bi@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory
> leak issues
> 
> Fort this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> > Kinney
> > 发送时间: 2023年9月9日 5:50
> > 收件人: Mike Maslenkin <mike.maslenkin@gmail.com>;
> > devel@edk2.groups.io
> > 抄送: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> > Kinney, Michael D <michael.d.kinney@intel.com>
> > 主题: Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory
> > leak issues
> >
> > Hi Mike,
> >
> > I have created a PR to run EDK II CI while we wait for a
> > review from one of the DXE Core Maintainers
> >
> > https://github.com/tianocore/edk2/pull/4815
> >
> > Mike
> >
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Sent: Friday, September 8, 2023 2:40 PM
> > > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > > <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> > > <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Subject: RE: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> > >
> > > Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > >
> > > > -----Original Message-----
> > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > Sent: Thursday, August 31, 2023 5:11 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > > > <gaoliming@byosoft.com.cn>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>;
> > > > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike
> > Maslenkin
> > > > <mike.maslenkin@gmail.com>
> > > > Subject: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> > > >
> > > > Please, find trivial memory leak fixes on error path.
> > > >
> > > > The only question: is it required to use FreePool() or CoreFreePool()
> > > > from DXE core code? Patch 2/2 is made in accordance with existing
> code.
> > > >
> > > > Cc: Dandan Bi <dandan.bi@intel.com>
> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > >
> >
> >
> >
> > 
> >
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108473): https://edk2.groups.io/g/devel/message/108473
Mute This Topic: https://groups.io/mt/101285586/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-