From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 637039403CF for ; Fri, 1 Sep 2023 00:10:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qPzabzNIDXcdqRKzyTVd1lq5E3YAq38P2ZqovPWez2U=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693527043; v=1; b=j86QnYQuNWpc4w3A+gFkyvGChLeY0O8ohMiMcEn8mL6f6SW7EzRvcYzCNciWqByGiWDe9J4G kmU6OQl7aoZY+UlVt9CE1Uc4Yr/wAL9JU9VoQLLCH5pytw+87wiCnQNmf4HFN/vph8dEJ2c5JwR JIbdOIr08ueMyquTApOo6wvg= X-Received: by 127.0.0.2 with SMTP id 7GvoYY7687511x09i0zdImEf; Thu, 31 Aug 2023 17:10:43 -0700 X-Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mx.groups.io with SMTP id smtpd.web10.9811.1693527042338404227 for ; Thu, 31 Aug 2023 17:10:42 -0700 X-Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-500b6456c7eso2667959e87.2 for ; Thu, 31 Aug 2023 17:10:42 -0700 (PDT) X-Gm-Message-State: Nqlah8FOOvRwnYspR6krkN6Ex7686176AA= X-Google-Smtp-Source: AGHT+IEtOktXKTwv2uSWWYOQS0V1lNgG4EUkz7f2Hp9CmTvHB9RSUedGzgiCsH00p6IFN3N7C/uB1Q== X-Received: by 2002:a05:6512:2089:b0:4fb:780d:2a49 with SMTP id t9-20020a056512208900b004fb780d2a49mr443268lfr.5.1693527040185; Thu, 31 Aug 2023 17:10:40 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h22-20020a197016000000b004ffa0350851sm461422lfc.78.2023.08.31.17.10.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 31 Aug 2023 17:10:39 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: dandan.bi@intel.com, gaoliming@byosoft.com.cn, michael.d.kinney@intel.com, nathaniel.l.desimone@intel.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVol.c Date: Fri, 1 Sep 2023 03:10:31 +0300 Message-Id: <20230901001032.52136-2-mike.maslenkin@gmail.com> In-Reply-To: <20230901001032.52136-1-mike.maslenkin@gmail.com> References: <20230901001032.52136-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=j86QnYQu; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io FwVolHeader must be deallocated on error path. Signed-off-by: Mike Maslenkin --- MdeModulePkg/Core/Dxe/FwVol/FwVol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c b/MdeModulePkg/Core/Dxe/Fw= Vol/FwVol.c index 153bfecafa77..0c1554ba4d63 100644 --- a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c +++ b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c @@ -659,6 +659,7 @@ NotifyFwVolBlock ( //=0D FvDevice =3D AllocateCopyPool (sizeof (FV_DEVICE), &mFvDevice);=0D if (FvDevice =3D=3D NULL) {=0D + CoreFreePool (FwVolHeader);=0D return;=0D }=0D =0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108221): https://edk2.groups.io/g/devel/message/108221 Mute This Topic: https://groups.io/mt/101085563/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-