From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fb.mail.gandi.net (spool7.mail.gandi.net [217.70.178.216]) by nmboxes206.sd4.0x35.net (Postfix) with ESMTPS id EE3BC60B2B for ; Fri, 1 Sep 2023 09:21:31 +0000 (UTC) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by fb.mail.gandi.net (Postfix) with ESMTPS id 4A76B6037A for ; Fri, 1 Sep 2023 09:21:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=edO92oKTge7GNUcHKXK5g3GbhSmc1OzUfX5NB32YKx4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693560090; v=1; b=cXjnQTjqKWyXFHYmNEa99gcrHs8QwBrE9qShGdHbYGOUZI7iTzGAoRx9b8Csxp2AO6wgUwIg QAikA6XlG1yUhxTOls5bvbo9UlXTcCLpH7uih7X6ZAZnCCgRY5OBsyZRykhCvEusl1nq/LsV00t YIl34M7OIVQT2wMF146yVxAA= X-Received: by 127.0.0.2 with SMTP id FsqIYY7687511xRnuDS4m8oE; Fri, 01 Sep 2023 02:21:30 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.13215.1693540489695167758 for ; Thu, 31 Aug 2023 20:54:49 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="376062959" X-IronPort-AV: E=Sophos;i="6.02,218,1688454000"; d="scan'208";a="376062959" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 20:54:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="829975653" X-IronPort-AV: E=Sophos;i="6.02,218,1688454000"; d="scan'208";a="829975653" X-Received: from wyam675.sh.intel.com ([10.239.160.23]) by FMSMGA003.fm.intel.com with ESMTP; 31 Aug 2023 20:54:47 -0700 From: "Wang, Yin" To: devel@edk2.groups.io Cc: sunilvl@ventanamicro.com, andrei.warkentin@intel.com, ardb+tianocore@kernel.org, jiewen.yao@intel.com, jordan.l.justen@intel.com, kraxel@redhat.com, Yin Wang Subject: [edk2-devel] [PATCH v4 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable Date: Fri, 1 Sep 2023 11:54:44 +0800 Message-Id: <20230901035444.1610144-1-yin.wang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yin.wang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EIPzlZnMzua3VaABScofjNDyx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: fb.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cXjnQTjq; spf=pass (fb.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) The Hii form is named "MainFormState" while the EFI variable is named "Plat= formConfig". This discrepancy in names causes the following SCT cases to fail on RiscVVi= rtQemu: ExtractConfigConformance ExtractConfigFunction ExtractConfig_Func Previous Commit 16acacf addressed two of these issues, and this patch fixes= the remaining one. Signed-off-by: Yin Wang v4: Only update commit message about version history - aefcc918: Enhance ExtractConfig() to match UEFI specification, adding che= ck of whether " matches the GUID and name" - 16acacf2: Fix Hii form name mismatch in ExtractConfig() - This patch: Add one more fix for Hii form name mismatch v3: Gerd comments on v2 that caused issues may related to RISC-V specific c= onfig. To address this separately, the patch was restored to v1, and detail= s were added to the commit message. v2: Add two more changes which caused other two SCT Hii cases to fail. v1: Initial version --- OvmfPkg/PlatformDxe/Platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c index cd3bfd554c..c32439683d 100644 --- a/OvmfPkg/PlatformDxe/Platform.c +++ b/OvmfPkg/PlatformDxe/Platform.c @@ -279,7 +279,7 @@ ExtractConfig ( //=0D ConfigRequestHdr =3D HiiConstructConfigHdr (=0D &gOvmfPlatformConfigGuid,=0D - mVariableName,=0D + mHiiFormName,=0D mImageHandle=0D );=0D if (ConfigRequestHdr =3D=3D NULL) {=0D --=20 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108223): https://edk2.groups.io/g/devel/message/108223 Mute This Topic: https://groups.io/mt/101088203/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-