* Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
2023-09-01 18:21 ` [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0 Avinash
@ 2023-09-04 5:15 ` Gao, Zhichao
2023-09-04 5:33 ` Dandan Bi
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Gao, Zhichao @ 2023-09-04 5:15 UTC (permalink / raw)
To: Bhargava, Avinash, devel@edk2.groups.io
Cc: Liu, Zhiguang, Bi, Dandan, Zeng, Star
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Bhargava, Avinash <avinash.bhargava@intel.com>
> Sent: Saturday, September 2, 2023 2:21 AM
> To: devel@edk2.groups.io
> Cc: Bhargava, Avinash <avinash.bhargava@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add
> New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
>
> Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0 Hex
> value - 16h Name - Intel® Processor
>
> Signed-off-by: avinashbhargava <avinash.bhargava@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 40bdc9a937c0..56cec615a010 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -554,6 +554,7 @@ typedef enum {
> ProcessorFamilyM2 = 0x13, ProcessorFamilyIntelCeleronM
> = 0x14, ProcessorFamilyIntelPentium4Ht = 0x15,+
> ProcessorFamilyIntel = 0x16, ProcessorFamilyAmdDuron
> = 0x18, ProcessorFamilyK5 = 0x19, ProcessorFamilyK6
> = 0x1A,--
> 2.37.3.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108248): https://edk2.groups.io/g/devel/message/108248
Mute This Topic: https://groups.io/mt/101104407/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
2023-09-01 18:21 ` [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0 Avinash
2023-09-04 5:15 ` Gao, Zhichao
@ 2023-09-04 5:33 ` Dandan Bi
2023-09-04 5:51 ` Zhiguang Liu
2023-09-05 2:29 ` 回复: " gaoliming via groups.io
3 siblings, 0 replies; 8+ messages in thread
From: Dandan Bi @ 2023-09-04 5:33 UTC (permalink / raw)
To: Bhargava, Avinash, devel@edk2.groups.io
Cc: Liu, Zhiguang, Zeng, Star, Gao, Zhichao
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: Bhargava, Avinash <avinash.bhargava@intel.com>
Sent: Saturday, September 2, 2023 2:21 AM
To: devel@edk2.groups.io
Cc: Bhargava, Avinash <avinash.bhargava@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0 Hex value - 16h Name - Intel® Processor
Signed-off-by: avinashbhargava <avinash.bhargava@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
---
MdePkg/Include/IndustryStandard/SmBios.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 40bdc9a937c0..56cec615a010 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -554,6 +554,7 @@ typedef enum {
ProcessorFamilyM2 = 0x13, ProcessorFamilyIntelCeleronM = 0x14, ProcessorFamilyIntelPentium4Ht = 0x15,+ ProcessorFamilyIntel = 0x16, ProcessorFamilyAmdDuron = 0x18, ProcessorFamilyK5 = 0x19, ProcessorFamilyK6 = 0x1A,--
2.37.3.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108249): https://edk2.groups.io/g/devel/message/108249
Mute This Topic: https://groups.io/mt/101104407/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
2023-09-01 18:21 ` [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0 Avinash
2023-09-04 5:15 ` Gao, Zhichao
2023-09-04 5:33 ` Dandan Bi
@ 2023-09-04 5:51 ` Zhiguang Liu
2023-09-05 2:29 ` 回复: " gaoliming via groups.io
3 siblings, 0 replies; 8+ messages in thread
From: Zhiguang Liu @ 2023-09-04 5:51 UTC (permalink / raw)
To: Bhargava, Avinash, devel@edk2.groups.io, Gao, Liming,
Kinney, Michael D
Cc: Bi, Dandan, Zeng, Star, Gao, Zhichao
++
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> -----Original Message-----
> From: Bhargava, Avinash <avinash.bhargava@intel.com>
> Sent: Saturday, September 2, 2023 2:21 AM
> To: devel@edk2.groups.io
> Cc: Bhargava, Avinash <avinash.bhargava@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add
> New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
>
> Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
> Hex value - 16h
> Name - Intel® Processor
>
> Signed-off-by: avinashbhargava <avinash.bhargava@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 40bdc9a937c0..56cec615a010 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -554,6 +554,7 @@ typedef enum {
> ProcessorFamilyM2 = 0x13,
>
> ProcessorFamilyIntelCeleronM = 0x14,
>
> ProcessorFamilyIntelPentium4Ht = 0x15,
>
> + ProcessorFamilyIntel = 0x16,
>
> ProcessorFamilyAmdDuron = 0x18,
>
> ProcessorFamilyK5 = 0x19,
>
> ProcessorFamilyK6 = 0x1A,
>
> --
> 2.37.3.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108250): https://edk2.groups.io/g/devel/message/108250
Mute This Topic: https://groups.io/mt/101104407/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* 回复: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
2023-09-01 18:21 ` [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0 Avinash
` (2 preceding siblings ...)
2023-09-04 5:51 ` Zhiguang Liu
@ 2023-09-05 2:29 ` gaoliming via groups.io
2023-09-05 2:58 ` Zeng, Star
3 siblings, 1 reply; 8+ messages in thread
From: gaoliming via groups.io @ 2023-09-05 2:29 UTC (permalink / raw)
To: devel, avinash.bhargava
Cc: 'Zhiguang Liu', 'Dandan Bi', 'Star Zeng',
'Zhichao Gao'
Avi:
The change is good. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
But, I have one minor comment. Please see below.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Avinash
> 发送时间: 2023年9月2日 2:21
> 收件人: devel@edk2.groups.io
> 抄送: avinashbhargava <avinash.bhargava@intel.com>; Zhiguang Liu
> <zhiguang.liu@intel.com>; Dandan Bi <dandan.bi@intel.com>; Star Zeng
> <star.zeng@intel.com>; Zhichao Gao <zhichao.gao@intel.com>
> 主题: [edk2-devel] [PATCH v1 1/1]
> MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family
> for SMBIOS Type 4 from SMBIOS 3.7.0
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
>
> Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
> Hex value - 16h
> Name - Intel® Processor
[Liming] Please remove non ascii char ® in the commit message.
Thanks
Liming
>
> Signed-off-by: avinashbhargava <avinash.bhargava@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 40bdc9a937c0..56cec615a010 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -554,6 +554,7 @@ typedef enum {
> ProcessorFamilyM2 = 0x13,
>
> ProcessorFamilyIntelCeleronM = 0x14,
>
> ProcessorFamilyIntelPentium4Ht = 0x15,
>
> + ProcessorFamilyIntel = 0x16,
>
> ProcessorFamilyAmdDuron = 0x18,
>
> ProcessorFamilyK5 = 0x19,
>
> ProcessorFamilyK6 = 0x1A,
>
> --
> 2.37.3.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108270): https://edk2.groups.io/g/devel/message/108270
Mute This Topic: https://groups.io/mt/101162131/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
2023-09-05 2:29 ` 回复: " gaoliming via groups.io
@ 2023-09-05 2:58 ` Zeng, Star
0 siblings, 0 replies; 8+ messages in thread
From: Zeng, Star @ 2023-09-05 2:58 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io, Bhargava, Avinash
Cc: Liu, Zhiguang, Bi, Dandan, Gao, Zhichao, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
BTW: You'd better to have a separated patch to also update https://github.com/tianocore/edk2/blob/master/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c#L1713.
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Tuesday, September 5, 2023 10:29 AM
To: devel@edk2.groups.io; Bhargava, Avinash <avinash.bhargava@intel.com>
Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: 回复: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
Avi:
The change is good. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
But, I have one minor comment. Please see below.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Avinash
> 发送时间: 2023年9月2日 2:21
> 收件人: devel@edk2.groups.io
> 抄送: avinashbhargava <avinash.bhargava@intel.com>; Zhiguang Liu
> <zhiguang.liu@intel.com>; Dandan Bi <dandan.bi@intel.com>; Star Zeng
> <star.zeng@intel.com>; Zhichao Gao <zhichao.gao@intel.com>
> 主题: [edk2-devel] [PATCH v1 1/1]
> MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor
> family for SMBIOS Type 4 from SMBIOS 3.7.0
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
>
> Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0 Hex
> value - 16h Name - Intel® Processor
[Liming] Please remove non ascii char ® in the commit message.
Thanks
Liming
>
> Signed-off-by: avinashbhargava <avinash.bhargava@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 40bdc9a937c0..56cec615a010 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -554,6 +554,7 @@ typedef enum {
> ProcessorFamilyM2 = 0x13,
>
> ProcessorFamilyIntelCeleronM = 0x14,
>
> ProcessorFamilyIntelPentium4Ht = 0x15,
>
> + ProcessorFamilyIntel = 0x16,
>
> ProcessorFamilyAmdDuron = 0x18,
>
> ProcessorFamilyK5 = 0x19,
>
> ProcessorFamilyK6 = 0x1A,
>
> --
> 2.37.3.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108273): https://edk2.groups.io/g/devel/message/108273
Mute This Topic: https://groups.io/mt/101162402/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread