[edk2-devel] [PATCH v1 1/1] MdePkg/Library/TdxLib: Remove unnecessary comparison

["Michael Kubacki" <mikuback@linux.microsoft.com>]

From: Michael Kubacki <michael.kubacki@microsoft.com>

Removes the comparison since unsigned values are always greater than
or equal to 0.

See the following CodeQL query for more info:
/cpp/cpp-unsigned-comparison-zero/

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 MdePkg/Library/TdxLib/Rtmr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Library/TdxLib/Rtmr.c b/MdePkg/Library/TdxLib/Rtmr.c
index a0283966b353..cbf1dda7bcff 100644
--- a/MdePkg/Library/TdxLib/Rtmr.c
+++ b/MdePkg/Library/TdxLib/Rtmr.c
@@ -51,7 +51,7 @@ TdExtendRtmr (
 
   ASSERT (Data != NULL);
   ASSERT (DataLen == SHA384_DIGEST_SIZE);
-  ASSERT (Index >= 0 && Index < RTMR_COUNT);
+  ASSERT (Index < RTMR_COUNT);
 
   if ((Data == NULL) || (DataLen != SHA384_DIGEST_SIZE) || (Index >= RTMR_COUNT)) {
     return EFI_INVALID_PARAMETER;
-- 
2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108335): https://edk2.groups.io/g/devel/message/108335
Mute This Topic: https://groups.io/mt/101198214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-