From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D70607803CE for ; Wed, 6 Sep 2023 21:49:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qdsI2kfgq0d6UqwcpIQ2+idXrFhAuw9HpXmPL+AJOpk=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1694036963; v=1; b=vte3IzpZqf/vd3Rz1lT9Z7+hEGHGTIiTVlgB48cKxfHX3gWByf3I6bHE8UqmPcF3JpJjFF1f ux8rY+FmsXiUDFRIECfkJNmjK4oHxy9nyvE+91liXSEXgDMH8GYO0CXLjT9pKKG0ZAuEtLE7WiF ZV1QD5fm0GLCDvdwRi7WlmZc= X-Received: by 127.0.0.2 with SMTP id FXASYY7687511xQGjB1BUVKX; Wed, 06 Sep 2023 14:49:23 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.2700.1694036962949019515 for ; Wed, 06 Sep 2023 14:49:23 -0700 X-Received: from OSD-Desktop.redmond.corp.microsoft.com (unknown [131.107.1.171]) by linux.microsoft.com (Postfix) with ESMTPSA id 7AFC8212B171; Wed, 6 Sep 2023 14:49:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7AFC8212B171 From: "Oliver Smith-Denny" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Gerd Hoffmann Subject: [edk2-devel][PATCH v1 1/1] ArmVirtPkg: Enable Early Serial For DxeCore Date: Wed, 6 Sep 2023 14:49:21 -0700 Message-Id: <20230906214921.19827-1-osde@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YFSNq8f6fAmJcmGhCBgW8BXWx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vte3IzpZ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Currently, ArmVirtPkg does not provide a serial library for DxeCore, so any early prints are missed. These prints are extremely valuable for debugging. The early serial port lib used by PeiCore and PEIMs is also applicable to DxeCore and in testing works to print debug prints from DxeCore throughout its lifecycle. This patchset adds the indicated support for DXE_CORE to EarlyFdtPL011SerialPortLib and adds this as the serial port instance for DxeCore in ArmVirtPkg. Github PR: https://github.com/tianocore/edk2/pull/4793 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Oliver Smith-Denny --- ArmVirtPkg/ArmVirt.dsc.inc = | 1 + ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.inf = | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index 2443e8351c99..cf352619fd6e 100644 --- a/ArmVirtPkg/ArmVirt.dsc.inc +++ b/ArmVirtPkg/ArmVirt.dsc.inc @@ -225,6 +225,7 @@ [LibraryClasses.common.DXE_CORE] DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.i= nf ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeE= xtractGuidedSectionLib.inf PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerfo= rmanceLib.inf + SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011Se= rialPortLib.inf =20 [LibraryClasses.common.DXE_DRIVER] SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/Dx= eSecurityManagementLib.inf diff --git a/ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011Serial= PortLib.inf b/ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011Seria= lPortLib.inf index 32b2d337d412..2c22ab088033 100644 --- a/ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib= .inf +++ b/ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib= .inf @@ -14,7 +14,7 @@ [Defines] FILE_GUID =3D 0983616A-49BC-4732-B531-4AF98D2056F= 0 MODULE_TYPE =3D BASE VERSION_STRING =3D 1.0 - LIBRARY_CLASS =3D SerialPortLib|SEC PEI_CORE PEIM + LIBRARY_CLASS =3D SerialPortLib|SEC PEI_CORE PEIM DXE= _CORE =20 [Sources.common] EarlyFdtPL011SerialPortLib.c --=20 2.40.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108342): https://edk2.groups.io/g/devel/message/108342 Mute This Topic: https://groups.io/mt/101203427/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-