From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5696CD810A5 for ; Thu, 7 Sep 2023 11:11:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Nb/CdSE8QlRfWiS917+5dg2hd0WasR0HQZRRf2Z3gHQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694085101; v=1; b=g08Ly8svfdDgLPaEibWI+AjEDO5WPB3TYNbzZ7mXkzQux101Uq9sZXISw7Rg7oj6FIflaQDo rJBr/LYiQkjhbr/taPaFrv6VPWimgCag4GJUYXkP4pq0O9zH9aOqVKWo/VkNTi1Y2QEKUWn0Fk/ 91x0NuZzpg9JowNULn/9fy58= X-Received: by 127.0.0.2 with SMTP id KBeRYY7687511xoJDahXJP5o; Thu, 07 Sep 2023 04:11:41 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.10365.1694085101167066990 for ; Thu, 07 Sep 2023 04:11:41 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-686-4eCKueyhMUa9it0NnCk0LA-1; Thu, 07 Sep 2023 07:11:37 -0400 X-MC-Unique: 4eCKueyhMUa9it0NnCk0LA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B45231C0DB05; Thu, 7 Sep 2023 11:11:36 +0000 (UTC) X-Received: from cav-thunderx1s-cn88xx-03.khw4.lab.eng.bos.redhat.com (cav-thunderx1s-cn88xx-03.khw4.lab.eng.bos.redhat.com [10.19.240.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AFB21121314; Thu, 7 Sep 2023 11:11:36 +0000 (UTC) From: "Zhenyu Zhang" To: devel@edk2.groups.io Cc: zhenyzha@redhat.com, osteffen@redhat.com, kraxel@redhat.com, marcandre.lureau@redhat.com, stefanb@linux.ibm.com, anthony.perard@citrix.com, julien@xen.org Subject: [edk2-devel] [PATCH v2 1/1] OvmfPkg:Add variable store is full debug info Date: Thu, 7 Sep 2023 07:11:17 -0400 Message-Id: <20230907111117.3559823-1-zhenyzha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhenyzha@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Qy4uDC2NXIQbv9iu9UVGkGKBx7686176AA= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=g08Ly8sv; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) From: "Zhenyu Zhang" When the variable store is full, edk2 will directly assert. Add debug information to help users understand what caused the assertion. Actual results: RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929- 48BCD90AD31A - 0x00000003 - 0x7E CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98 RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929- 48BCD90AD31A - 0x00000003 - 0x92 CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98 Synchronous Exception at 0x000000023CA60374 ...... ASSERT_EFI_ERROR (Status = Out of Resources) ASSERT /builddir/build/BUILD/edk2-ba91d0292e59/OvmfPkg/Library/ PlatformBootManagerLib/BdsPlatform.c(142): !(((INTN)(RETURN_ STATUS)(Status)) < 0) Cc: Oliver Steffen Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Stefan Berger Cc: Anthony Perard Cc: Julien Grall Signed-off-by: Zhenyu Zhang --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c index 8dc2bbf97371..c95c7931a3f5 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -139,6 +139,7 @@ PlatformRegisterFvBootOption ( if (OptionIndex == -1) { Status = EfiBootManagerAddLoadOptionVariable (&NewOption, MAX_UINTN); + DEBUG ((DEBUG_ERROR, "ERROR: Variable store is full.\n")); ASSERT_EFI_ERROR (Status); } -- 2.39.3 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108374): https://edk2.groups.io/g/devel/message/108374 Mute This Topic: https://groups.io/mt/101211889/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-