[edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md

[Rebecca Cran via groups.io]

Improve the Readme.md in Platform/Ampere:

- At this point eMAG is irrelevant, and most people are likely
  using Altra systems. Drop mention of it.
- Instead of mentioning the 'latest' versions of CentOS and Ubuntu
  (which will by definition change over time), specify Ubuntu 22.04
  and CentOS 7.
- Fix the link to the acpica download, since content has been moved from
  acpica.org to intel.com.
- Assuming the build is being done on Linux, acpica shouldn't be built
  with a CYGWIN definition.
- To avoid making people wait ages for acpica to build, add `-j8` as an
  example of building in parallel.

Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
---
 Platform/Ampere/Readme.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Platform/Ampere/Readme.md b/Platform/Ampere/Readme.md
index 894bad3437b8..066876dab4b5 100644
--- a/Platform/Ampere/Readme.md
+++ b/Platform/Ampere/Readme.md
@@ -8,8 +8,8 @@ Silicon code is located under Silicon/Ampere/Ampere{SoC Name}Pkg.
 
 # Build machines
 
-- x86 Linux host machines running latest Ubuntu or CentOS releases.
-- Arm64 Linux host machines if native compiling. This has been tested on Ampere's eMAG and Altra hardware platforms with latest AArch64 CentOS or Ubuntu releases.
+- x86 Linux host machines running Ubuntu 22.04 or CentOS 7 releases.
+- Arm64 Linux host machines if native compiling. This has been tested on Ampere's Altra hardware platforms with AArch64 CentOS 7 or Ubuntu 22.04 releases.
 
 # How to build (Linux Environment)
 
@@ -32,8 +32,8 @@ If you run into any build issue with the Intel ASL+ Optimizing Compiler/Disassem
 download and install the IASL compiler from https://acpica.org/. At the time of this write-up, we have tested with version 20200110.
 
 ```bash
-$ wget https://acpica.org/sites/acpica/files/acpica-unix2-20200110.tar.gz
+$ wget https://downloadmirror.intel.com/774850/acpica-unix2-20200110.tar.gz
 $ tar xzf acpica-unix2-20200110.tar.gz
 $ cd acpica-unix2-20200110
-$ make HOST=_CYGWIN && sudo make install
+$ make -j8 && sudo make install
 ```
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108494): https://edk2.groups.io/g/devel/message/108494
Mute This Topic: https://groups.io/mt/101298216/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md

[Nhi Pham via groups.io]

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

Thanks,

Nhi

On 9/12/2023 12:44 AM, Rebecca Cran wrote:
> Improve the Readme.md in Platform/Ampere:
>
> - At this point eMAG is irrelevant, and most people are likely
>    using Altra systems. Drop mention of it.
> - Instead of mentioning the 'latest' versions of CentOS and Ubuntu
>    (which will by definition change over time), specify Ubuntu 22.04
>    and CentOS 7.
> - Fix the link to the acpica download, since content has been moved from
>    acpica.org to intel.com.
> - Assuming the build is being done on Linux, acpica shouldn't be built
>    with a CYGWIN definition.
> - To avoid making people wait ages for acpica to build, add `-j8` as an
>    example of building in parallel.
>
> Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
> ---
>   Platform/Ampere/Readme.md | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Platform/Ampere/Readme.md b/Platform/Ampere/Readme.md
> index 894bad3437b8..066876dab4b5 100644
> --- a/Platform/Ampere/Readme.md
> +++ b/Platform/Ampere/Readme.md
> @@ -8,8 +8,8 @@ Silicon code is located under Silicon/Ampere/Ampere{SoC Name}Pkg.
>   
>   # Build machines
>   
> -- x86 Linux host machines running latest Ubuntu or CentOS releases.
> -- Arm64 Linux host machines if native compiling. This has been tested on Ampere's eMAG and Altra hardware platforms with latest AArch64 CentOS or Ubuntu releases.
> +- x86 Linux host machines running Ubuntu 22.04 or CentOS 7 releases.
> +- Arm64 Linux host machines if native compiling. This has been tested on Ampere's Altra hardware platforms with AArch64 CentOS 7 or Ubuntu 22.04 releases.
>   
>   # How to build (Linux Environment)
>   
> @@ -32,8 +32,8 @@ If you run into any build issue with the Intel ASL+ Optimizing Compiler/Disassem
>   download and install the IASL compiler from https://acpica.org/. At the time of this write-up, we have tested with version 20200110.
>   
>   ```bash
> -$ wget https://acpica.org/sites/acpica/files/acpica-unix2-20200110.tar.gz
> +$ wget https://downloadmirror.intel.com/774850/acpica-unix2-20200110.tar.gz
>   $ tar xzf acpica-unix2-20200110.tar.gz
>   $ cd acpica-unix2-20200110
> -$ make HOST=_CYGWIN && sudo make install
> +$ make -j8 && sudo make install
>   ```


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108512): https://edk2.groups.io/g/devel/message/108512
Mute This Topic: https://groups.io/mt/101298216/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md

[Leif Lindholm]

On Mon, Sep 11, 2023 at 11:44:12 -0600, Rebecca Cran wrote:
> Improve the Readme.md in Platform/Ampere:
> 
> - At this point eMAG is irrelevant, and most people are likely
>   using Altra systems. Drop mention of it.
> - Instead of mentioning the 'latest' versions of CentOS and Ubuntu
>   (which will by definition change over time), specify Ubuntu 22.04
>   and CentOS 7.
> - Fix the link to the acpica download, since content has been moved from
>   acpica.org to intel.com.
> - Assuming the build is being done on Linux, acpica shouldn't be built
>   with a CYGWIN definition.
> - To avoid making people wait ages for acpica to build, add `-j8` as an
>   example of building in parallel.
> 
> Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
> ---
>  Platform/Ampere/Readme.md | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Platform/Ampere/Readme.md b/Platform/Ampere/Readme.md
> index 894bad3437b8..066876dab4b5 100644
> --- a/Platform/Ampere/Readme.md
> +++ b/Platform/Ampere/Readme.md
> @@ -8,8 +8,8 @@ Silicon code is located under Silicon/Ampere/Ampere{SoC Name}Pkg.
>  
>  # Build machines
>  
> -- x86 Linux host machines running latest Ubuntu or CentOS releases.
> -- Arm64 Linux host machines if native compiling. This has been tested on Ampere's eMAG and Altra hardware platforms with latest AArch64 CentOS or Ubuntu releases.
> +- x86 Linux host machines running Ubuntu 22.04 or CentOS 7 releases.
> +- Arm64 Linux host machines if native compiling. This has been tested on Ampere's Altra hardware platforms with AArch64 CentOS 7 or Ubuntu 22.04 releases.

So, it's really good that you add "known good" versions so that if
someone runs into a problem around toolchain version compatibility,
they know what to use. But anything in edk2-platform should be kept up
to date so that it builds on current operating systems.

And I'd prefer for known versions to include toolchain profile and
versions of tools (so people don't need to go run lookup tables on
what versions are included in what distro).
It's fine (even good) to state "as included in distro X release Y",
but I want more granularity. Because I may well have a GCC9 lying
around in a vm somwehere, and then I can use that instead of hopping
off setting up a dedicated thing to build a specific platform.

>  # How to build (Linux Environment)
>  
> @@ -32,8 +32,8 @@ If you run into any build issue with the Intel ASL+ Optimizing Compiler/Disassem
>  download and install the IASL compiler from https://acpica.org/. At the time of this write-up, we have tested with version 20200110.
>  
>  ```bash
> -$ wget https://acpica.org/sites/acpica/files/acpica-unix2-20200110.tar.gz
> +$ wget https://downloadmirror.intel.com/774850/acpica-unix2-20200110.tar.gz
>  $ tar xzf acpica-unix2-20200110.tar.gz
>  $ cd acpica-unix2-20200110
> -$ make HOST=_CYGWIN && sudo make install
> +$ make -j8 && sudo make install
>  ```

No issue with this part.

/
    Leif

> -- 
> 2.34.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108526): https://edk2.groups.io/g/devel/message/108526
Mute This Topic: https://groups.io/mt/101298216/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md

[Rebecca Cran via groups.io]

On 9/12/2023 3:58 AM, Leif Lindholm via groups.io wrote:

> So, it's really good that you add "known good" versions so that if
> someone runs into a problem around toolchain version compatibility,
> they know what to use. But anything in edk2-platform should be kept up
> to date so that it builds on current operating systems.

Really, I think we'd want to remove everything from the Readme.md except 
perhaps the "Additional build tools" section.


-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108532): https://edk2.groups.io/g/devel/message/108532
Mute This Topic: https://groups.io/mt/101298216/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md

[Leif Lindholm]

On 2023-09-12 14:07, Rebecca Cran via groups.io wrote:
> On 9/12/2023 3:58 AM, Leif Lindholm via groups.io wrote:
> 
>> So, it's really good that you add "known good" versions so that if
>> someone runs into a problem around toolchain version compatibility,
>> they know what to use. But anything in edk2-platform should be kept up
>> to date so that it builds on current operating systems.
> 
> Really, I think we'd want to remove everything from the Readme.md except 
> perhaps the "Additional build tools" section.

I would be OK with that too.

/
     Leif




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108544): https://edk2.groups.io/g/devel/message/108544
Mute This Topic: https://groups.io/mt/101298216/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-