From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8D675D806D5 for ; Tue, 12 Sep 2023 07:01:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FCm6344/r4Z1EjEtoGRX7dda0LxADZ/SAObsm5aaPNE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1694502116; v=1; b=anLOLRMHEbZGieXK/G7tgoNy3TdGKrvgncU59aop+cwAPzMBGp8Xfsn+woA3n8TCexdH5lHp G9CclfvGvnqo/8gWd8GVSMauT7eKFQUP/XyjgGwl9CTTCkDV2amweRYSVMVmqdZPeN97MDAwC7e gDJmOgpjM2SPSr+iEKHR/5Kc= X-Received: by 127.0.0.2 with SMTP id jjMqYY7687511xMsfn6OY6dZ; Tue, 12 Sep 2023 00:01:56 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.60]) by mx.groups.io with SMTP id smtpd.web10.19479.1694502115512672746 for ; Tue, 12 Sep 2023 00:01:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMnM2ELnaXraQQfnVIcD6PzhFNQdxFeswwhAG9DY1MYUHk7pq3iaPvrh4VZDPll7quVCLuuJr58ADvgpUhNOUfoVbDBWXREGri6JH0DDkgGZ/SgfXoL60gK/38wp2W3umFcm80kpJy4mDBiWa/YzUFomRLrwSxegklfeSYaEi4kUvkfEqBAcm+gOmRQaMl/7bT5OLo2WqnyY9gHSTijX1CcRIjjbn6qXVUbj8VDQltQHTxRioQh35xMGe6j5gkcBcDnQoUAZwBTraqgmGqaBJu0qi+097TvnWKKeIk8Ij9ZRSt1CIlPyaq48y+1+DnrVtlEi/5KEc2bfeEMLB6IgzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHRkbcob1fKStEs1anG/rIUtFRRvKTV0MCYeaMz/HiI=; b=QO7+jqrqeNJWNcxR051T4wYFMuKJDUgO6O5Lloz7OGnvtsFO3pzxWSePebKSbM4ooigfrzj5OPLYgLXxowRF96wzFMloC5F8aUVbuNym5Ti0hONZ4hoEqV+Kd/CGpMSGE0JS0e9i676AotB0aWtJXOJXJmAjP9DuVzvAnp1PlHC5/dzvugRS5C7o00rSUktE5JNVb5pmGdy7L/ufG4HdXXYP/7WfSPKVRPBf0/RLj3pGoRdsna2jlWl+iqlfmrU/gOsJNSy325Wfezh5g9rImkkoclZW5kh8zp9yVsMRGH80CUORUHIpyP+tQu4iNjCor8TGyRjSrdGWTWcYK+084A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from BL1P223CA0016.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::21) by IA1PR12MB8554.namprd12.prod.outlook.com (2603:10b6:208:450::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.38; Tue, 12 Sep 2023 07:01:52 +0000 X-Received: from MN1PEPF0000ECDB.namprd02.prod.outlook.com (2603:10b6:208:2c4:cafe::1) by BL1P223CA0016.outlook.office365.com (2603:10b6:208:2c4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.35 via Frontend Transport; Tue, 12 Sep 2023 07:01:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.161) by MN1PEPF0000ECDB.mail.protection.outlook.com (10.167.242.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.17 via Frontend Transport; Tue, 12 Sep 2023 07:01:52 +0000 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 12 Sep 2023 00:01:36 -0700 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 12 Sep 2023 00:01:35 -0700 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Tue, 12 Sep 2023 00:01:34 -0700 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [edk2-devel] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. Date: Tue, 12 Sep 2023 15:01:34 +0800 Message-ID: <20230912070134.13729-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECDB:EE_|IA1PR12MB8554:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d7e3188-fd65-47ac-011b-08dbb35e2497 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 2tO2wchfV+5IDleLWQnF3en/piHM2hdPFYjPTIkfanfYL1BXVwr6ArXIaOcCM+JJjM3V/kxsttwh3q1Gj9gkzVceFQzl6HuC2lQuQZyYR04/tKM+BbVW81VW4hZMOyf55g4M8MtN+87v4PFko3rlYK9j2JBBJrN/Ui4YYJSfM9tZOe11j9k1SjFhy7y/r/Ta1QYP/hjUnjJaQ8xkil9mMoLU12A4pcgMqkfKdnlfoK387xz5CV9LkV63wM6/+vvlwFm+lfISkBJFofnCBahElnSwh8sCzyZx8tSb7AKwYvf6M22PiT6tF+U9E/oTrpbDghEYVU2CsiKobGb2GTjKhDETrInAjVQMuzpXJFMoR6j86Vh9GVNRVWYTu7+N8kvOTELhqg1L+2zXOZ1haZLa4qhCPem8k8G+yyBRRjbkEpLDz9JxVa4vdgKpV9aSUcpMeAHz+nyHdIAnzJv8cq710YRvdEtFG7MFmeBd2jNQJAPIvBxaO9toOZMHU8Nx4kzl44IaF1W0QCpZkUHe0wWPrafiluJEPXpvgJyN5OgmkFiuqb89NJYC3am81HlpgXk5eOnIJ2JHK2ozfR5SSnjXQfIcM0ggkT4HmsylylwYjPiiswknpWXdGDO0YOk2pppeA//VYBBLH4L/OXzaM79azFB8vxblB7hFlkZ3iLo7j/97mA//YspXri9rsvlvUB455tZunAQm0ExYO+cD2QncOj3WpZhH5+J22acmuToc/EJtzG6B9kY1FPTanHszj5jI X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 07:01:52.3043 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d7e3188-fd65-47ac-011b-08dbb35e2497 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECDB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8554 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4gm8N6SA1SitLlriTgiV613Lx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 190 X-GND-Status: SPAM Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=anLOLRMH; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") StatementValue->Buffer is converted from ASCII to Unicode by caller already so we don't have to convert it again. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index f2a8e77d9b00..30d2ef351eca 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -1660,12 +1660,11 @@ RedfishPlatformConfigSetStatementCommon ( // in string format from HII point of view. Do a patch here. // if ((TargetStatement->HiiStatement->Operand =3D=3D EFI_IFR_ONE_OF_OP) = && (StatementValue->Type =3D=3D EFI_IFR_TYPE_STRING)) { - TempBuffer =3D StrToUnicodeStr ((CHAR8 *)StatementValue->Buffer); - if (TempBuffer =3D=3D NULL) { - return EFI_OUT_OF_RESOURCES; - } - - FreePool (StatementValue->Buffer); + // + // Keep input buffer to TempBuffer because StatementValue will be + // assigned in HiiStringToOneOfOptionValue(). + // + TempBuffer =3D (EFI_STRING)StatementValue->Buffer; StatementValue->Buffer =3D NULL; StatementValue->BufferLen =3D 0; =20 --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108516): https://edk2.groups.io/g/devel/message/108516 Mute This Topic: https://groups.io/mt/101310452/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-