From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 47D89D80041 for ; Wed, 13 Sep 2023 04:27:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WCVHEj/onesZ14Vk8QaZRu4XAuHVh9G9DSH3vMYMP64=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1694579224; v=1; b=bQVB15im9i+AmGt56qjU2eDBc4QzIsBU0lEloOyuI8s2R4Ai7hDxIR3k5iMh6ewQnyorZwPV Xdk6zHGW9/OlHnuA+zTwhl+WvhdGse0ZiNewhA+sSoKNnMmu7OzQ/dCcA2rgGSDNtsV8SKeoptw 33bJuHmfgcSryuhQ0YvjJB00= X-Received: by 127.0.0.2 with SMTP id y3GMYY7687511xgYueW0idOw; Tue, 12 Sep 2023 21:27:04 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.4645.1694579216558329653 for ; Tue, 12 Sep 2023 21:27:03 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="363595405" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="363595405" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2023 21:27:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="859093614" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="859093614" X-Received: from shwdeopenlab705.ccr.corp.intel.com ([10.239.55.100]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2023 21:27:01 -0700 From: "Yuanhao Xie" To: devel@edk2.groups.io Cc: Ray Ni , Eric Dong , Rahul Kumar , Gerd Hoffmann Subject: [edk2-devel] [PATCH 02/16] UefiCpuPkg/MtrrUnitTest: Update the Unit Test for IsMtrrSupported(). Date: Wed, 13 Sep 2023 12:26:25 +0800 Message-Id: <20230913042639.2066-3-yuanhao.xie@intel.com> In-Reply-To: <20230913042639.2066-1-yuanhao.xie@intel.com> References: <20230913042639.2066-1-yuanhao.xie@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: su3OmM5aUDrMW6GIXkIDScNYx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=bQVB15im; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) The previous implementation returns FALSE if either fixed MTRR is unsupported or the number of variable MTRRs is 0. The correct behavior is to return FALSE only when both fixed MTRR is unsupported and the number of variable MTRRs is 0. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c b/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c index 1409ae27bb..ac18d9d25d 100644 --- a/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c +++ b/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c @@ -399,7 +399,7 @@ UnitTestIsMtrrSupported ( SystemParameter.VariableMtrrCount = 0; SystemParameter.FixedMtrrSupported = TRUE; InitializeMtrrRegs (&SystemParameter); - UT_ASSERT_FALSE (IsMtrrSupported ()); + UT_ASSERT_TRUE (IsMtrrSupported ()); // // MTRR capability on in CPUID leaf, but no fixed MTRRs. @@ -408,7 +408,7 @@ UnitTestIsMtrrSupported ( SystemParameter.VariableMtrrCount = 7; SystemParameter.FixedMtrrSupported = FALSE; InitializeMtrrRegs (&SystemParameter); - UT_ASSERT_FALSE (IsMtrrSupported ()); + UT_ASSERT_TRUE (IsMtrrSupported ()); // // MTRR capability on in CPUID leaf with both variable and fixed MTRRs. -- 2.36.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108558): https://edk2.groups.io/g/devel/message/108558 Mute This Topic: https://groups.io/mt/101331018/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-