[edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

[edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

[Laszlo Ersek]

The shortlog below provides a good summary :)

Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Cc: Andrew Jones <ajones@ventanamicro.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>

Thanks
Laszlo

Laszlo Ersek (3):
  OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG
  OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
  OvmfPkg/RiscVVirt/README: document direct kernel boot

 OvmfPkg/RiscVVirt/README.md | 43 +++++++++++++++++++-
 1 file changed, 42 insertions(+), 1 deletion(-)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108575): https://edk2.groups.io/g/devel/message/108575
Mute This Topic: https://groups.io/mt/101334263/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

[Laszlo Ersek]

Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such
setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew.

Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Cc: Andrew Jones <ajones@ventanamicro.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/RiscVVirt/README.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
index dbb40bbe89b0..193e4afe8dee 100644
--- a/OvmfPkg/RiscVVirt/README.md
+++ b/OvmfPkg/RiscVVirt/README.md
@@ -86,3 +86,8 @@ then specify that binary for QEMU, with the following additional command line
 option:
 
     -bios $OPENSBI_DIR/build/platform/generic/firmware/fw_dynamic.bin
+
+Note that the above only makes a difference with software emulation (which you
+can force with `-M accel=tcg`). With hardware virtualization (`-M accel=kvm`),
+KVM services the SBI (Supervisor Binary Interface) calls internally, therefore
+any externally loaded OpenSBI binary is ignored.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108576): https://edk2.groups.io/g/devel/message/108576
Mute This Topic: https://groups.io/mt/101334264/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

[Laszlo Ersek]

"acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
it. Original explanation by Drew Jones.

Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Cc: Andrew Jones <ajones@ventanamicro.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/RiscVVirt/README.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
index 193e4afe8dee..1dba1a26af2d 100644
--- a/OvmfPkg/RiscVVirt/README.md
+++ b/OvmfPkg/RiscVVirt/README.md
@@ -70,6 +70,11 @@ Below example shows how to boot openSUSE Tumbleweed E20.
         -device virtio-blk-device,drive=hd0 \
         -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0
 
+    Note: the `acpi=off` machine property is specified because Linux guest
+    support for ACPI (that is, the ACPI consumer side) is a work in progress.
+    Currently, `acpi=off` is recommended unless you are developing ACPI support
+    yourself.
+
 ## Test with your own OpenSBI binary
 Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
 OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108577): https://edk2.groups.io/g/devel/message/108577
Mute This Topic: https://groups.io/mt/101334265/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 3/3] OvmfPkg/RiscVVirt/README: document direct kernel boot

[Laszlo Ersek]

Direct (fw_cfg) kernel boot works on the RiscVVirt firmware platform too;
I've tested it after extracting the kernel, initrd, and kernel command
line from "openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw". Document this
type of boot, because at least historically, fw_cfg kernel boot was
implemented differently between OVMF and ArmVirtQemu. Thanks: Drew, Sunil.

Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Cc: Andrew Jones <ajones@ventanamicro.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/RiscVVirt/README.md | 33 +++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
index 1dba1a26af2d..47b97dd64a2f 100644
--- a/OvmfPkg/RiscVVirt/README.md
+++ b/OvmfPkg/RiscVVirt/README.md
@@ -75,8 +75,39 @@ Below example shows how to boot openSUSE Tumbleweed E20.
     Currently, `acpi=off` is recommended unless you are developing ACPI support
     yourself.
 
+3) Running QEMU with direct kernel boot
+
+    The following example boots the same guest, but loads the kernel image and
+    the initial RAM disk (which were extracted from
+    `openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw`) from the host filesystem.
+    It also sets the guest kernel command line on the QEMU command line.
+
+        CMDLINE=(root=UUID=76d9b92d-09e9-4df0-8262-c1a7a466f2bc
+                 systemd.show_status=1
+                 ignore_loglevel
+                 console=ttyS0
+                 earlycon=uart8250,mmio,0x10000000)
+
+        qemu-system-riscv64 \
+        -M virt,pflash0=pflash0,pflash1=pflash1,acpi=off \
+        -m 4096 -smp 2 \
+        -serial mon:stdio \
+        -device virtio-gpu-pci -full-screen \
+        -device qemu-xhci \
+        -device usb-kbd \
+        -device virtio-rng-pci \
+        -blockdev node-name=pflash0,driver=file,read-only=on,filename=RISCV_VIRT_CODE.fd \
+        -blockdev node-name=pflash1,driver=file,filename=RISCV_VIRT_VARS.fd \
+        -netdev user,id=net0 \
+        -device virtio-net-pci,netdev=net0 \
+        -device virtio-blk-device,drive=hd0 \
+        -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0 \
+        -kernel Image-6.5.2-1-default \
+        -initrd initrd-6.5.2-1-default \
+        -append "${CMDLINE[*]}"
+
 ## Test with your own OpenSBI binary
-Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
+Using the above QEMU command lines, **RISCV_VIRT_CODE.fd** is launched by the
 OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary
 as well:
 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108578): https://edk2.groups.io/g/devel/message/108578
Mute This Topic: https://groups.io/mt/101334266/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

[Ard Biesheuvel]

On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek <lersek@redhat.com> wrote:
>
> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
> it. Original explanation by Drew Jones.
>

Out of curiosity: how is this different from the -no-acpi QEMU command
line option?


> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Jones <ajones@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
> index 193e4afe8dee..1dba1a26af2d 100644
> --- a/OvmfPkg/RiscVVirt/README.md
> +++ b/OvmfPkg/RiscVVirt/README.md
> @@ -70,6 +70,11 @@ Below example shows how to boot openSUSE Tumbleweed E20.
>          -device virtio-blk-device,drive=hd0 \
>          -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0
>
> +    Note: the `acpi=off` machine property is specified because Linux guest
> +    support for ACPI (that is, the ACPI consumer side) is a work in progress.
> +    Currently, `acpi=off` is recommended unless you are developing ACPI support
> +    yourself.
> +
>  ## Test with your own OpenSBI binary
>  Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
>  OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108580): https://edk2.groups.io/g/devel/message/108580
Mute This Topic: https://groups.io/mt/101334265/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

[Sunil V L]

On Wed, Sep 13, 2023 at 01:02:07PM +0200, Ard Biesheuvel wrote:
> On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek <lersek@redhat.com> wrote:
> >
> > "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
> > it. Original explanation by Drew Jones.
> >
> 
> Out of curiosity: how is this different from the -no-acpi QEMU command
> line option?
> 
Hi Ard,

no-acpi switch is a legacy option which is deprecated. We should use
acpi machine parameter only.

REF: https://www.mail-archive.com/qemu-devel@nongnu.org/msg943298.html

Thanks,
Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108581): https://edk2.groups.io/g/devel/message/108581
Mute This Topic: https://groups.io/mt/101334265/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

[Laszlo Ersek]

On 9/13/23 13:02, Ard Biesheuvel wrote:
> On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
>> it. Original explanation by Drew Jones.
>>
> 
> Out of curiosity: how is this different from the -no-acpi QEMU command
> line option?

They are the same thing:

https://www.qemu.org/docs/master/about/deprecated.html#no-acpi-since-8-0

"The -no-acpi setting has been turned into a machine property. Use
-machine acpi=off instead."

That is, "-no-acpi" has been deprecated since QEMU 8.0.

Cheers
Laszlo

> 
> 
>> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
>> Cc: Andrew Jones <ajones@ventanamicro.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
>> index 193e4afe8dee..1dba1a26af2d 100644
>> --- a/OvmfPkg/RiscVVirt/README.md
>> +++ b/OvmfPkg/RiscVVirt/README.md
>> @@ -70,6 +70,11 @@ Below example shows how to boot openSUSE Tumbleweed E20.
>>          -device virtio-blk-device,drive=hd0 \
>>          -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0
>>
>> +    Note: the `acpi=off` machine property is specified because Linux guest
>> +    support for ACPI (that is, the ACPI consumer side) is a work in progress.
>> +    Currently, `acpi=off` is recommended unless you are developing ACPI support
>> +    yourself.
>> +
>>  ## Test with your own OpenSBI binary
>>  Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
>>  OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary
>>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108598): https://edk2.groups.io/g/devel/message/108598
Mute This Topic: https://groups.io/mt/101334265/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

[Andrew Jones]

On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote:
> Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such
> setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew.
> 
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Jones <ajones@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
> index dbb40bbe89b0..193e4afe8dee 100644
> --- a/OvmfPkg/RiscVVirt/README.md
> +++ b/OvmfPkg/RiscVVirt/README.md
> @@ -86,3 +86,8 @@ then specify that binary for QEMU, with the following additional command line
>  option:
>  
>      -bios $OPENSBI_DIR/build/platform/generic/firmware/fw_dynamic.bin
> +
> +Note that the above only makes a difference with software emulation (which you
> +can force with `-M accel=tcg`). With hardware virtualization (`-M accel=kvm`),
> +KVM services the SBI (Supervisor Binary Interface) calls internally, therefore
> +any externally loaded OpenSBI binary is ignored.
>

With the 'virt' machine model -bios is actually forbidden with accel=kvm,
not just ignored.

Otherwise,

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>

Thanks,
drew


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108609): https://edk2.groups.io/g/devel/message/108609
Mute This Topic: https://groups.io/mt/101334264/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

[Andrew Jones]

On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote:
> Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such
> setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew.
> 
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Jones <ajones@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
> index dbb40bbe89b0..193e4afe8dee 100644
> --- a/OvmfPkg/RiscVVirt/README.md
> +++ b/OvmfPkg/RiscVVirt/README.md
> @@ -86,3 +86,8 @@ then specify that binary for QEMU, with the following additional command line
>  option:
>  
>      -bios $OPENSBI_DIR/build/platform/generic/firmware/fw_dynamic.bin
> +
> +Note that the above only makes a difference with software emulation (which you
> +can force with `-M accel=tcg`). With hardware virtualization (`-M accel=kvm`),
> +KVM services the SBI (Supervisor Binary Interface) calls internally, therefore
> +any externally loaded OpenSBI binary is ignored.
>


Reviewed-by: Andrew Jones <ajones@ventanamicro.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108637): https://edk2.groups.io/g/devel/message/108637
Mute This Topic: https://groups.io/mt/101334264/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

[Andrew Jones]

On Wed, Sep 13, 2023 at 12:55:50PM +0200, Laszlo Ersek wrote:
> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
> it. Original explanation by Drew Jones.
> 
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Jones <ajones@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
> index 193e4afe8dee..1dba1a26af2d 100644
> --- a/OvmfPkg/RiscVVirt/README.md
> +++ b/OvmfPkg/RiscVVirt/README.md
> @@ -70,6 +70,11 @@ Below example shows how to boot openSUSE Tumbleweed E20.
>          -device virtio-blk-device,drive=hd0 \
>          -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0
>  
> +    Note: the `acpi=off` machine property is specified because Linux guest
> +    support for ACPI (that is, the ACPI consumer side) is a work in progress.
> +    Currently, `acpi=off` is recommended unless you are developing ACPI support
> +    yourself.
> +
>  ## Test with your own OpenSBI binary
>  Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
>  OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary
>

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108638): https://edk2.groups.io/g/devel/message/108638
Mute This Topic: https://groups.io/mt/101334265/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/RiscVVirt/README: document direct kernel boot

[Andrew Jones]

On Wed, Sep 13, 2023 at 12:55:51PM +0200, Laszlo Ersek wrote:
> Direct (fw_cfg) kernel boot works on the RiscVVirt firmware platform too;
> I've tested it after extracting the kernel, initrd, and kernel command
> line from "openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw". Document this
> type of boot, because at least historically, fw_cfg kernel boot was
> implemented differently between OVMF and ArmVirtQemu. Thanks: Drew, Sunil.
> 
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Jones <ajones@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/RiscVVirt/README.md | 33 +++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
> index 1dba1a26af2d..47b97dd64a2f 100644
> --- a/OvmfPkg/RiscVVirt/README.md
> +++ b/OvmfPkg/RiscVVirt/README.md
> @@ -75,8 +75,39 @@ Below example shows how to boot openSUSE Tumbleweed E20.
>      Currently, `acpi=off` is recommended unless you are developing ACPI support
>      yourself.
>  
> +3) Running QEMU with direct kernel boot
> +
> +    The following example boots the same guest, but loads the kernel image and
> +    the initial RAM disk (which were extracted from
> +    `openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw`) from the host filesystem.
> +    It also sets the guest kernel command line on the QEMU command line.
> +
> +        CMDLINE=(root=UUID=76d9b92d-09e9-4df0-8262-c1a7a466f2bc
> +                 systemd.show_status=1
> +                 ignore_loglevel
> +                 console=ttyS0
> +                 earlycon=uart8250,mmio,0x10000000)
> +
> +        qemu-system-riscv64 \
> +        -M virt,pflash0=pflash0,pflash1=pflash1,acpi=off \
> +        -m 4096 -smp 2 \
> +        -serial mon:stdio \
> +        -device virtio-gpu-pci -full-screen \
> +        -device qemu-xhci \
> +        -device usb-kbd \
> +        -device virtio-rng-pci \
> +        -blockdev node-name=pflash0,driver=file,read-only=on,filename=RISCV_VIRT_CODE.fd \
> +        -blockdev node-name=pflash1,driver=file,filename=RISCV_VIRT_VARS.fd \
> +        -netdev user,id=net0 \
> +        -device virtio-net-pci,netdev=net0 \
> +        -device virtio-blk-device,drive=hd0 \
> +        -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0 \
> +        -kernel Image-6.5.2-1-default \
> +        -initrd initrd-6.5.2-1-default \
> +        -append "${CMDLINE[*]}"
> +
>  ## Test with your own OpenSBI binary
> -Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
> +Using the above QEMU command lines, **RISCV_VIRT_CODE.fd** is launched by the
>  OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary
>  as well:
>

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108639): https://edk2.groups.io/g/devel/message/108639
Mute This Topic: https://groups.io/mt/101334266/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

[Andrew Jones]

On Thu, Sep 14, 2023 at 09:23:12AM +0200, Andrew Jones wrote:
> On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote:
> > Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such
> > setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew.
> > 
> > Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> > Cc: Andrew Jones <ajones@ventanamicro.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> >  OvmfPkg/RiscVVirt/README.md | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
> > index dbb40bbe89b0..193e4afe8dee 100644
> > --- a/OvmfPkg/RiscVVirt/README.md
> > +++ b/OvmfPkg/RiscVVirt/README.md
> > @@ -86,3 +86,8 @@ then specify that binary for QEMU, with the following additional command line
> >  option:
> >  
> >      -bios $OPENSBI_DIR/build/platform/generic/firmware/fw_dynamic.bin
> > +
> > +Note that the above only makes a difference with software emulation (which you
> > +can force with `-M accel=tcg`). With hardware virtualization (`-M accel=kvm`),
> > +KVM services the SBI (Supervisor Binary Interface) calls internally, therefore
> > +any externally loaded OpenSBI binary is ignored.
> >
> 
> 
> Reviewed-by: Andrew Jones <ajones@ventanamicro.com>

Eh, sorry for the redundant r-b and my 'ignored' comment still stands,
i.e. I wouldn't mind seeing a v2 with s/ignored/rejected/

Thanks,
drew


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108640): https://edk2.groups.io/g/devel/message/108640
Mute This Topic: https://groups.io/mt/101334264/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

[Laszlo Ersek]

On 9/13/23 18:28, Andrew Jones wrote:
> On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote:
>> Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such
>> setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew.
>>
>> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
>> Cc: Andrew Jones <ajones@ventanamicro.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
>> index dbb40bbe89b0..193e4afe8dee 100644
>> --- a/OvmfPkg/RiscVVirt/README.md
>> +++ b/OvmfPkg/RiscVVirt/README.md
>> @@ -86,3 +86,8 @@ then specify that binary for QEMU, with the following additional command line
>>  option:
>>  
>>      -bios $OPENSBI_DIR/build/platform/generic/firmware/fw_dynamic.bin
>> +
>> +Note that the above only makes a difference with software emulation (which you
>> +can force with `-M accel=tcg`). With hardware virtualization (`-M accel=kvm`),
>> +KVM services the SBI (Supervisor Binary Interface) calls internally, therefore
>> +any externally loaded OpenSBI binary is ignored.
>>
> 
> With the 'virt' machine model -bios is actually forbidden with accel=kvm,
> not just ignored.

Thanks, I think I should then say:

  therefore any OpenSBI binary specified with `-bios` is rejected

(I think I can still technically merge this series myself on github,
once it's been reviewed, so I could fix this up, to keep the churn low
for the maintainers.)

Unfortunately, I can't test KVM here; got no riscv64 hardware. (And I'm
not really considering nesting KVM under TCG! :) Even if TCG emulated
the virtualization extensions (?), the speed would probably be unbearable.)

> 
> Otherwise,
> 
> Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
> 
> Thanks,
> drew
> 

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108641): https://edk2.groups.io/g/devel/message/108641
Mute This Topic: https://groups.io/mt/101334264/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

[Sunil V L]

Hi Laszlo,

For the series with anticipated change for Drew's comment.

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Do you plan to queue this up with that change? Feel free to let me know
if you want me to take care.

Thanks,
Sunil
On Wed, Sep 13, 2023 at 12:55:48PM +0200, Laszlo Ersek wrote:
> The shortlog below provides a good summary :)
> 
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Jones <ajones@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (3):
>   OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG
>   OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
>   OvmfPkg/RiscVVirt/README: document direct kernel boot
> 
>  OvmfPkg/RiscVVirt/README.md | 43 +++++++++++++++++++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108643): https://edk2.groups.io/g/devel/message/108643
Mute This Topic: https://groups.io/mt/101334263/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

[Laszlo Ersek]

On 9/14/23 11:05, Sunil V L wrote:
> Hi Laszlo,
> 
> For the series with anticipated change for Drew's comment.
> 
> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
> 
> Do you plan to queue this up with that change? Feel free to let me know
> if you want me to take care.

Yes I'll try to submit the MR with the "push" label set.

Thanks!
Laszlo

> 
> Thanks,
> Sunil
> On Wed, Sep 13, 2023 at 12:55:48PM +0200, Laszlo Ersek wrote:
>> The shortlog below provides a good summary :)
>>
>> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
>> Cc: Andrew Jones <ajones@ventanamicro.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (3):
>>   OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG
>>   OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
>>   OvmfPkg/RiscVVirt/README: document direct kernel boot
>>
>>  OvmfPkg/RiscVVirt/README.md | 43 +++++++++++++++++++-
>>  1 file changed, 42 insertions(+), 1 deletion(-)
>>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108644): https://edk2.groups.io/g/devel/message/108644
Mute This Topic: https://groups.io/mt/101334263/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

[Laszlo Ersek]

On 9/13/23 12:55, Laszlo Ersek wrote:
> The shortlog below provides a good summary :)
>
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Jones <ajones@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (3):
>   OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG
>   OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
>   OvmfPkg/RiscVVirt/README: document direct kernel boot
>
>  OvmfPkg/RiscVVirt/README.md | 43 +++++++++++++++++++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
>

Merged as commit range cdfe4310dda2..29cce3356aec via
<https://github.com/tianocore/edk2/pull/4830>.

Range-diff between the posted and merged series:

1:  f99c0f999a47 ! 1:  5242bae5ddbb OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG
    @@ Commit message
         Cc: Jordan Justen <jordan.l.justen@intel.com>
         Cc: Sunil V L <sunilvl@ventanamicro.com>
         Signed-off-by: Laszlo Ersek <lersek@redhat.com>
    +    [lersek@redhat.com: '-bios' is rejected with KVM accel (Drew)]
    +    Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
    +    Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

      ## OvmfPkg/RiscVVirt/README.md ##
     @@ OvmfPkg/RiscVVirt/README.md: then specify that binary for QEMU, with the following additional command line
    @@ OvmfPkg/RiscVVirt/README.md: then specify that binary for QEMU, with the followi
     +Note that the above only makes a difference with software emulation (which you
     +can force with `-M accel=tcg`). With hardware virtualization (`-M accel=kvm`),
     +KVM services the SBI (Supervisor Binary Interface) calls internally, therefore
    -+any externally loaded OpenSBI binary is ignored.
    ++any OpenSBI binary specified with `-bios` is rejected.
2:  d759e9453cc7 ! 2:  1bfd63ac3955 OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
    @@ Commit message
         Cc: Jordan Justen <jordan.l.justen@intel.com>
         Cc: Sunil V L <sunilvl@ventanamicro.com>
         Signed-off-by: Laszlo Ersek <lersek@redhat.com>
    +    Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
    +    Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

      ## OvmfPkg/RiscVVirt/README.md ##
     @@ OvmfPkg/RiscVVirt/README.md: Below example shows how to boot openSUSE Tumbleweed E20.
3:  8d69ece226fc ! 3:  29cce3356aec OvmfPkg/RiscVVirt/README: document direct kernel boot
    @@ Commit message
         Cc: Jordan Justen <jordan.l.justen@intel.com>
         Cc: Sunil V L <sunilvl@ventanamicro.com>
         Signed-off-by: Laszlo Ersek <lersek@redhat.com>
    +    Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
    +    Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

      ## OvmfPkg/RiscVVirt/README.md ##
     @@ OvmfPkg/RiscVVirt/README.md: Below example shows how to boot openSUSE Tumbleweed E20.

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108647): https://edk2.groups.io/g/devel/message/108647
Mute This Topic: https://groups.io/mt/101334263/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

[Sunil V L]

On Thu, Sep 14, 2023 at 12:55:02PM +0200, Laszlo Ersek wrote:
> On 9/13/23 12:55, Laszlo Ersek wrote:
> > The shortlog below provides a good summary :)
> >
> > Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> > Cc: Andrew Jones <ajones@ventanamicro.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> >
> > Thanks
> > Laszlo
> >
> > Laszlo Ersek (3):
> >   OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG
> >   OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
> >   OvmfPkg/RiscVVirt/README: document direct kernel boot
> >
> >  OvmfPkg/RiscVVirt/README.md | 43 +++++++++++++++++++-
> >  1 file changed, 42 insertions(+), 1 deletion(-)
> >
> 
> Merged as commit range cdfe4310dda2..29cce3356aec via
> <https://github.com/tianocore/edk2/pull/4830>.
> 
Thank you for taking care!

Regards
Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108648): https://edk2.groups.io/g/devel/message/108648
Mute This Topic: https://groups.io/mt/101334263/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-