From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9D2D1740037 for ; Thu, 14 Sep 2023 07:25:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6nXwFU0DgIPDSZUdNtJ/yEa2v8i9StB6EcwMCyjTsv8=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1694676349; v=1; b=sc4PceI4mlIDargb3KSJnWZ/mR/aIn5boeipi/ZfaGeCh4rnCy0PY9eJzqs7DYVJs2zL7UV2 GbKYIq+dRdAiB69z3juBhlGTlu3y4Hi+EpnFJ/lBWzDmJz11BDv67ix+9hK4Hiim4E+GSxIcAPK SD7KvrCmDyc5xhERP3ZGIKL4= X-Received: by 127.0.0.2 with SMTP id hx3UYY7687511xBSwcGegvDh; Thu, 14 Sep 2023 00:25:49 -0700 X-Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.groups.io with SMTP id smtpd.web10.6530.1694676348488869837 for ; Thu, 14 Sep 2023 00:25:48 -0700 X-Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-401b5516104so6339385e9.2 for ; Thu, 14 Sep 2023 00:25:48 -0700 (PDT) X-Gm-Message-State: mQ8WFl5GPHw9mgCcOfAszCfXx7686176AA= X-Google-Smtp-Source: AGHT+IEcNeY+KTh4mogImYtx6K0BlbNwEec5/BEl3n5YhsNErktppAvy6qx7HHlg9EU8ESr7mJt72w== X-Received: by 2002:a7b:ca49:0:b0:402:ceb:ca5b with SMTP id m9-20020a7bca49000000b004020cebca5bmr4039068wml.20.1694676346926; Thu, 14 Sep 2023 00:25:46 -0700 (PDT) X-Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id v13-20020a05600c214d00b00401dc20a070sm3991399wml.43.2023.09.14.00.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 00:25:46 -0700 (PDT) Date: Thu, 14 Sep 2023 09:25:40 +0200 From: "Andrew Jones" To: Laszlo Ersek Cc: edk2-devel-groups-io , Andrei Warkentin , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Sunil V L Subject: Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG Message-ID: <20230914-bb153bcbb6cd4db790ec6f92@orel> References: <20230913105551.12680-1-lersek@redhat.com> <20230913105551.12680-2-lersek@redhat.com> <20230914-f3d43a351e41fffada7d5afb@orel> MIME-Version: 1.0 In-Reply-To: <20230914-f3d43a351e41fffada7d5afb@orel> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ajones@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sc4PceI4; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Sep 14, 2023 at 09:23:12AM +0200, Andrew Jones wrote: > On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote: > > Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such > > setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew. > > > > Cc: Andrei Warkentin > > Cc: Andrew Jones > > Cc: Ard Biesheuvel > > Cc: Gerd Hoffmann > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Sunil V L > > Signed-off-by: Laszlo Ersek > > --- > > OvmfPkg/RiscVVirt/README.md | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md > > index dbb40bbe89b0..193e4afe8dee 100644 > > --- a/OvmfPkg/RiscVVirt/README.md > > +++ b/OvmfPkg/RiscVVirt/README.md > > @@ -86,3 +86,8 @@ then specify that binary for QEMU, with the following additional command line > > option: > > > > -bios $OPENSBI_DIR/build/platform/generic/firmware/fw_dynamic.bin > > + > > +Note that the above only makes a difference with software emulation (which you > > +can force with `-M accel=tcg`). With hardware virtualization (`-M accel=kvm`), > > +KVM services the SBI (Supervisor Binary Interface) calls internally, therefore > > +any externally loaded OpenSBI binary is ignored. > > > > > Reviewed-by: Andrew Jones Eh, sorry for the redundant r-b and my 'ignored' comment still stands, i.e. I wouldn't mind seeing a v2 with s/ignored/rejected/ Thanks, drew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108640): https://edk2.groups.io/g/devel/message/108640 Mute This Topic: https://groups.io/mt/101334264/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-