From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8285F7803CE for ; Mon, 18 Sep 2023 15:17:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cBg2V37RrXICOUwKtnv+S26/PW3NhN21Fo2vLC6xHBI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1695050265; v=1; b=K8XYx0pAYwBHzN4xMB9ExqrHBhOEqZSiZ7F3hfOPweLizD1johfbQoiB9a1UGAgeff1kTdUS LqYXbXPzD9L8I2j6EWOhmmelNVohYzAGY3EJ9U1MiardrUl3cZlkW6VB4M6auld1nFP3GiU82qt BwVn9F6c81q6uQZ2C1IfVCOw= X-Received: by 127.0.0.2 with SMTP id zoiNYY7687511x8ehUr5BQEC; Mon, 18 Sep 2023 08:17:45 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.45821.1695019066711439455 for ; Sun, 17 Sep 2023 23:37:49 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="382319901" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="382319901" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2023 23:37:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="860930869" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="860930869" X-Received: from juichenx-mobl3.gar.corp.intel.com ([10.227.107.41]) by fmsmga002.fm.intel.com with ESMTP; 17 Sep 2023 23:37:45 -0700 From: brucex.wang@intel.com To: devel@edk2.groups.io Cc: brucex.wang@intel.com, Zhiguang Liu , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Anthony Perard , Julien Grall , Ray Ni Subject: [edk2-devel] [PATCH v4 1/4] OvmfPkg: Remove applicationProcessorEntryPoint Date: Mon, 18 Sep 2023 14:37:16 +0800 Message-Id: <20230918063719.1395-2-brucex.wang@intel.com> In-Reply-To: <20230918063719.1395-1-brucex.wang@intel.com> References: <20230918063719.1395-1-brucex.wang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brucex.wang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jADvbgUQDPjGbbCWhRrUKFc5x7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=K8XYx0pA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Zhiguang Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4494 Current reset vector uses 0xffffffe0 as AP waking vector, and expects GenFv generates code aligned on a 4k boundary which will jump to this location. However, some issues are listed below 1. GenFV doesn't generate code as the comment expects, because GenFv assumes no modifications are required to the VTF-0 'Volume Top File'. 2. Even if removing VFT0 signature and let GenFv to modify, Genfv is hard-code using another flash address 0xffffffd0. 3. In the same patch series, AP waking vector code is removed from GenFv, because no such usage anymore. The existing of first two issues also approve the usage is not available for a long time. Therefore, remove AP waking vector related code. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Anthony Perard Cc: Julien Grall Reviewed-by: Ray Ni Acked-by: Anthony PERARD Signed-off-by: Zhiguang Liu --- OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm | 15 +++------------ OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm | 16 +++------------- 2 files changed, 6 insertions(+), 25 deletions(-) diff --git a/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm b/OvmfPkg/ResetVe= ctor/Ia16/ResetVectorVtf0.asm index 12f2cedd67..8f94da89f7 100644 --- a/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm +++ b/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm @@ -160,22 +160,13 @@ guidedStructureEnd: =0D ALIGN 16=0D =0D -applicationProcessorEntryPoint:=0D ;=0D -; Application Processors entry point=0D +; 0xffffffe0=0D ;=0D -; GenFv generates code aligned on a 4k boundary which will jump to this=0D -; location. (0xffffffe0) This allows the Local APIC Startup IPI to be=0D -; used to wake up the application processors.=0D -;=0D - jmp EarlyApInitReal16=0D -=0D -ALIGN 8=0D -=0D - DD 0=0D + DD 0, 0, 0=0D =0D ;=0D -; The VTF signature=0D +; The VTF signature (0xffffffec)=0D ;=0D ; VTF-0 means that the VTF (Volume Top File) code does not require=0D ; any fixups.=0D diff --git a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm b/OvmfPkg/XenR= esetVector/Ia16/ResetVectorVtf0.asm index 56749bdbc9..67156d8252 100644 --- a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm +++ b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm @@ -39,23 +39,13 @@ xenPVHEntryPoint: =0D BITS 16=0D ALIGN 16=0D -=0D -applicationProcessorEntryPoint:=0D -;=0D -; Application Processors entry point=0D ;=0D -; GenFv generates code aligned on a 4k boundary which will jump to this=0D -; location. (0xffffffe0) This allows the Local APIC Startup IPI to be=0D -; used to wake up the application processors.=0D +; 0xffffffe0=0D ;=0D - jmp EarlyApInitReal16=0D -=0D -ALIGN 8=0D -=0D - DD 0=0D + DD 0, 0, 0=0D =0D ;=0D -; The VTF signature=0D +; The VTF signature (0xffffffec)=0D ;=0D ; VTF-0 means that the VTF (Volume Top File) code does not require=0D ; any fixups.=0D --=20 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108784): https://edk2.groups.io/g/devel/message/108784 Mute This Topic: https://groups.io/mt/101435613/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-