From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B22D7941AC8 for ; Mon, 18 Sep 2023 15:17:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4oqhewxVsqYDy08StbF31uyarX5nx2U/1Hocf8E2How=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1695050270; v=1; b=eMLZgFo9biveGsQNFm03jNnM1WCVGOqadVIdoa8pQPEcJpyc+eZ7PPB/C7LrosHDoxIWbA+A lH3QDxEGfmm29+zPz4jhKc72OxPsaiDSfcKpkKXobOVQZ2letqwi5SNc8EjwytrpoGUt0AInxDM XulquEUwSr3L0/Oq4ibu58Q0= X-Received: by 127.0.0.2 with SMTP id 91BnYY7687511xFgTb435Gpz; Mon, 18 Sep 2023 08:17:50 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.45985.1695019378754549588 for ; Sun, 17 Sep 2023 23:42:59 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="369906075" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="369906075" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2023 23:42:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="869450518" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="869450518" X-Received: from juichenx-mobl3.gar.corp.intel.com ([10.227.107.41]) by orsmga004.jf.intel.com with ESMTP; 17 Sep 2023 23:42:42 -0700 From: brucex.wang@intel.com To: devel@edk2.groups.io Cc: brucex.wang@intel.com, Zhiguang Liu , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann Subject: [edk2-devel] [PATCH v4 2/4] UefiCpuPkg/ResetVector: Remove AP waking vector from ResetVector Date: Mon, 18 Sep 2023 14:42:32 +0800 Message-Id: <20230918064235.1440-3-brucex.wang@intel.com> In-Reply-To: <20230918064235.1440-1-brucex.wang@intel.com> References: <20230918064235.1440-1-brucex.wang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brucex.wang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KwItH2bZJz3gm0Xpbg7qeKWhx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eMLZgFo9; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Zhiguang Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4494 Current reset vector uses 0xffffffe0 as AP waking vector, and expects GenFv generates code aligned on a 4k boundary which will jump to this location. However, some issues are listed below 1. GenFV doesn't generate code as the comment expects, because GenFv assumes no modifications are required to the VTF-0 'Volume Top File'. 2. Even if removing VFT0 signature and let GenFv to modify, Genfv is hard-code using another flash address 0xffffffd0. 3. In the same patch series, AP waking vector code is removed from GenFv, because no such usage anymore. The existing of first two issues also approve the usage is not available for a long time. Therefore, remove AP waking vector related code. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Reviewed-by: Ray Ni Signed-off-by: Zhiguang Liu --- UefiCpuPkg/ResetVector/Vtf0/Ia16/Init16.asm | 7 ------- .../ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm | 15 +++------------ 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/UefiCpuPkg/ResetVector/Vtf0/Ia16/Init16.asm b/UefiCpuPkg/Reset= Vector/Vtf0/Ia16/Init16.asm index cbdadee166..02b9a0303c 100644 --- a/UefiCpuPkg/ResetVector/Vtf0/Ia16/Init16.asm +++ b/UefiCpuPkg/ResetVector/Vtf0/Ia16/Init16.asm @@ -17,13 +17,6 @@ EarlyBspInitReal16: mov di, 'BP'=0D jmp short Main16=0D =0D -;=0D -; @param[out] DI 'AP' to indicate application processor=0D -;=0D -EarlyApInitReal16:=0D - mov di, 'AP'=0D - jmp short Main16=0D -=0D ;=0D ; Modified: EAX=0D ;=0D diff --git a/UefiCpuPkg/ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm b/UefiCpu= Pkg/ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm index fe5bbea803..384b1d4d98 100644 --- a/UefiCpuPkg/ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm +++ b/UefiCpuPkg/ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm @@ -32,22 +32,13 @@ ALIGN 16 TIMES (0x1000 - 0x20) DB 0=0D %endif=0D =0D -applicationProcessorEntryPoint:=0D ;=0D -; Application Processors entry point=0D +; 0xffffffe0=0D ;=0D -; GenFv generates code aligned on a 4k boundary which will jump to this=0D -; location. (0xffffffe0) This allows the Local APIC Startup IPI to be=0D -; used to wake up the application processors.=0D -;=0D - jmp EarlyApInitReal16=0D -=0D -ALIGN 8=0D -=0D - DD 0=0D + DD 0, 0, 0=0D =0D ;=0D -; The VTF signature=0D +; The VTF signature (0xffffffec)=0D ;=0D ; VTF-0 means that the VTF (Volume Top File) code does not require=0D ; any fixups.=0D --=20 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108790): https://edk2.groups.io/g/devel/message/108790 Mute This Topic: https://groups.io/mt/101435618/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-