public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Andrei Warkentin" <andrei.warkentin@intel.com>
To: devel@edk2.groups.io
Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Subject: [edk2-devel] [PATCH v1 0/1] RISCV: Fix InternalLongJump
Date: Mon, 18 Sep 2023 23:43:02 -0500	[thread overview]
Message-ID: <20230919044303.21523-1-andrei.warkentin@intel.com> (raw)

I was playing around with building code with -Os and ran into
weird crashes, that I ended up chasing down to an obviously
incorrect InternalLongJump implementation, which has never
been correctly passing its 2nd parameter down as the return
value of SetJump.

You can find the pull at https://github.com/tianocore/edk2/pull/4836,
with the failing tests seemingly unrelated (at least one of these
was related to CryptoPkg not being found).

Andrei Warkentin (1):
  RISCV: Fix InternalLongJump to return correct value

 CryptoPkg/Library/OpensslLib/openssl                  | 2 +-
 MdePkg/Library/BaseLib/RiscV64/RiscVSetJumpLongJump.S | 7 ++-----
 2 files changed, 3 insertions(+), 6 deletions(-)

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108815): https://edk2.groups.io/g/devel/message/108815
Mute This Topic: https://groups.io/mt/101450444/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2023-09-19  4:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  4:43 Andrei Warkentin [this message]
2023-09-19  4:43 ` [edk2-devel] [PATCH v1 1/1] RISCV: Fix InternalLongJump to return correct value Andrei Warkentin
2023-09-19  8:01   ` Yao, Jiewen
2023-09-19  8:04     ` Andrei Warkentin
2023-09-19 14:31   ` Ard Biesheuvel
2023-09-19 14:41     ` Leif Lindholm
2023-09-19 16:14       ` Andrei Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230919044303.21523-1-andrei.warkentin@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox