[edk2-devel] [PATCH edk2-platforms 0/2] some trivial changes

[edk2-devel] [PATCH edk2-platforms 0/2] some trivial changes

[Marcin Juszkiewicz]

Those changes float around whenever I do some changes in code. Time to
send them for merge and stop bothering.

Marcin Juszkiewicz (2):
  Silicon/SbsaQemu: drop duplicated Pcd
  Silicon/SbsaQemu: fix comment to show proper table name

 .../Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf   | 2 --
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

-- 
2.41.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108920): https://edk2.groups.io/g/devel/message/108920
Mute This Topic: https://groups.io/mt/101481483/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 1/2] Silicon/SbsaQemu: drop duplicated Pcd

[Marcin Juszkiewicz]

PcdAcpiDefaultOemRevision was listed twice.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 .../Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf   | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
index 14d760b36400..6783595e1d2d 100644
--- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
+++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
@@ -61,8 +61,6 @@ [Protocols]
   gEfiAcpiTableProtocolGuid                       ## CONSUMES
 
 [FixedPcd]
-  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision
-
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId
-- 
2.41.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108921): https://edk2.groups.io/g/devel/message/108921
Mute This Topic: https://groups.io/mt/101481485/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 2/2] Silicon/SbsaQemu: fix comment to show proper table name

[Marcin Juszkiewicz]

Someone did copy/paste in past and forgot to alter table name in
comment.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
index 3bc25a6e3540..bd3ba75f52fa 100644
--- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
+++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
@@ -504,7 +504,7 @@ AddSsdtTable (
 }
 
 /*
- * A function that adds the SSDT ACPI table.
+ * A function that adds the PPTT ACPI table.
  */
 EFI_STATUS
 AddPpttTable (
-- 
2.41.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108922): https://edk2.groups.io/g/devel/message/108922
Mute This Topic: https://groups.io/mt/101481486/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/2] some trivial changes

[Rebecca Cran via groups.io]

On 9/20/2023 9:55 AM, Marcin Juszkiewicz via groups.io wrote:
> Those changes float around whenever I do some changes in code. Time to
> send them for merge and stop bothering.
> 
> Marcin Juszkiewicz (2):
>    Silicon/SbsaQemu: drop duplicated Pcd
>    Silicon/SbsaQemu: fix comment to show proper table name
> 
>   .../Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf   | 2 --
>   Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +-
>   2 files changed, 1 insertion(+), 3 deletions(-)
> 

Series:

Reviewed-by: Rebecca Cran <rebecca@os.amperecomputing.com>

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108923): https://edk2.groups.io/g/devel/message/108923
Mute This Topic: https://groups.io/mt/101481483/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/2] some trivial changes

[Leif Lindholm]

On Wed, Sep 20, 2023 at 17:55:39 +0200, Marcin Juszkiewicz wrote:
> Those changes float around whenever I do some changes in code. Time to
> send them for merge and stop bothering.
> 
> Marcin Juszkiewicz (2):
>   Silicon/SbsaQemu: drop duplicated Pcd
>   Silicon/SbsaQemu: fix comment to show proper table name

For the series:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as f3f7d3a1b41e..cbe0e979e45a.

Thanks!

>  .../Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf   | 2 --
>  Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> -- 
> 2.41.0
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109015): https://edk2.groups.io/g/devel/message/109015
Mute This Topic: https://groups.io/mt/101481483/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-