From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5A40E7803E8 for ; Tue, 26 Sep 2023 06:40:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=epMHcQDLP/pb6JKTsUsBMO1QVWsJ1gi6V7qS7BUyDiw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1695710409; v=1; b=r2yGOejCwS6HH0uLEOFl6qoVzKGhBlt6etViHkwz5Tdq/jAgYNJ9CB5HhZbPR0NmYwo55Bd5 AfE41dbt3LjEmX71Ry5ZwEQ0TecCAWduosGXZWKgf2eeyGS0BlKnAAPPFUP+IlSJXG2OFKmI5wV +SHClu0fdF/UvedwwfkqOn0s= X-Received: by 127.0.0.2 with SMTP id 5xh4YY7687511x1CokPCIJ18; Mon, 25 Sep 2023 23:40:09 -0700 X-Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by mx.groups.io with SMTP id smtpd.web11.13055.1695710409312160888 for ; Mon, 25 Sep 2023 23:40:09 -0700 X-Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-57bca5b9b0aso1618371eaf.3 for ; Mon, 25 Sep 2023 23:40:09 -0700 (PDT) X-Gm-Message-State: E9u9aDBFneu02EmT1QgYIvuBx7686176AA= X-Google-Smtp-Source: AGHT+IGoIIwy0EIJ7TTAmuojVQZcWyvhlkoyfYjNXesFEBYFZ4/5Fr3P+QHgWOYsEIOM0xXOGc2ACA== X-Received: by 2002:a05:6358:4287:b0:134:c650:cc0a with SMTP id s7-20020a056358428700b00134c650cc0amr11473173rwc.15.1695710408278; Mon, 25 Sep 2023 23:40:08 -0700 (PDT) X-Received: from user-Latitude-5420.. ([2401:4900:1cbc:99f:aeba:67ec:3f47:cb02]) by smtp.gmail.com with ESMTPSA id q9-20020a639809000000b00573f82bb00esm8875606pgd.2.2023.09.25.23.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 23:40:07 -0700 (PDT) From: "Ranbir Singh" To: devel@edk2.groups.io, rsingh@ventanamicro.com Cc: Dandan Bi , Liming Gao , Veeresh Sangolli Subject: [edk2-devel] [PATCH v1 2/5] MdeModulePkg/Core/Dxe: Fix MISSING_BREAK Coverity issue Date: Tue, 26 Sep 2023 12:09:55 +0530 Message-Id: <20230926063958.313858-3-rsingh@ventanamicro.com> In-Reply-To: <20230926063958.313858-1-rsingh@ventanamicro.com> References: <20230926063958.313858-1-rsingh@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rsingh@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=r2yGOejC; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Ranbir Singh The function CoreIsSchedulable has switch-case code in which case EFI_DEP_BEFORE: case EFI_DEP_AFTER: has a comment that // For a well-formed Dependency Expression, the code should never get here. It also has an ASSERT (FALSE); but this is applicable only in DEBUG mode. Seemingly, for RELEASE mode, code should not be allowed to fall through to case EFI_DEP_SOR: which is below the above two. Hence, add return FALSE at the end. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4219 Cc: Dandan Bi Cc: Liming Gao Co-authored-by: Veeresh Sangolli Signed-off-by: Ranbir Singh Signed-off-by: Ranbir Singh --- MdeModulePkg/Core/Dxe/Dispatcher/Dependency.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Core/Dxe/Dispatcher/Dependency.c b/MdeModulePkg/C= ore/Dxe/Dispatcher/Dependency.c index acbf68b700fb..9799ec9ca097 100644 --- a/MdeModulePkg/Core/Dxe/Dispatcher/Dependency.c +++ b/MdeModulePkg/Core/Dxe/Dispatcher/Dependency.c @@ -265,6 +265,8 @@ CoreIsSchedulable ( //=0D DEBUG ((DEBUG_DISPATCH, " RESULT =3D FALSE (Unexpected BEFORE or = AFTER opcode)\n"));=0D ASSERT (FALSE);=0D + return FALSE;=0D +=0D case EFI_DEP_SOR:=0D //=0D // These opcodes can only appear once as the first opcode. If it = is found=0D --=20 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109061): https://edk2.groups.io/g/devel/message/109061 Mute This Topic: https://groups.io/mt/101590755/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-