From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Sami Mujawar" <sami.mujawar@arm.com>,
"Andrei Warkentin" <andrei.warkentin@intel.com>
Subject: [edk2-devel] [PATCH v2 0/5] MdePkg: various fixes to ARM/AArch64 SetJump/LongJump
Date: Tue, 26 Sep 2023 18:15:18 +0100 [thread overview]
Message-ID: <20230926171523.368706-1-quic_llindhol@quicinc.com> (raw)
Back in the mists of time (January 2020) I submitted a set to clean up
and fix a few bugs in ARM/AArch64 BaseLib SetJump/LongJump implementations:
https://edk2.groups.io/g/devel/message/65812
Then hubris struck and I meant to refactor the code for all architectures,
and since this was in my first week in a new job, that meant everything
got completely dropped on the floor.
Then Andrei's fix of similar issues for RiscV64 made me remember this set.
And I figured, let's dial back the ambition and get the actual fixes
merged.
The overall scope remains:
- Fix comments (drop Itanium mention, correct spelling)
- Make code match existing comments
- Don't try to optimise ARM for executing on the 8088
- Use the correct register sizes on AArch64
- Actually follow the API on ARM
And like the original submission, the changes to .asm files have been
neither build nor runtime tested.
Any acks/reviewed-bys have been dropped, it having been over 3.5 years.
Changes since v1:
- Rebased to current edk2 main.
- Incorporate Ard's feedback on maintaining a clean call stack for
InternalAssertJumpBuffer, *and* conditionalising it on !MDEPKG_NDEBUG.
- Changed authorship to my current identity (the company I worked at
during v1 having been acquired by my current employer, this feels
like a reasonable course of action).
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Leif Lindholm (5):
MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations
MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations
MdePkg/BaseLib: use normal register init in ARM SetJump
implementations
MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump
MdePkg/BaseLib: ensure ARM LongJump never returns 0
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 19 +++++++++++++------
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 19 +++++++++++++------
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 7 ++++---
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 7 ++++---
4 files changed, 34 insertions(+), 18 deletions(-)
--
2.30.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109074): https://edk2.groups.io/g/devel/message/109074
Mute This Topic: https://groups.io/mt/101600799/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next reply other threads:[~2023-09-26 17:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 17:15 Leif Lindholm [this message]
2023-09-26 17:15 ` [edk2-devel] [PATCH v2 1/5] MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations Leif Lindholm
2023-09-29 15:06 ` Sami Mujawar
2023-09-26 17:15 ` [edk2-devel] [PATCH v2 2/5] MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations Leif Lindholm
2023-09-29 15:06 ` Sami Mujawar
2023-10-02 15:52 ` Leif Lindholm
2023-09-26 17:15 ` [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM " Leif Lindholm
2023-09-29 15:07 ` Sami Mujawar
2023-10-02 18:00 ` Philippe Mathieu-Daudé
2023-10-03 10:43 ` Leif Lindholm
2023-09-26 17:15 ` [edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump Leif Lindholm
2023-09-29 15:07 ` Sami Mujawar
2023-09-29 22:00 ` Andrei Warkentin
2023-10-02 17:56 ` Philippe Mathieu-Daudé
2023-09-26 17:15 ` [edk2-devel] [PATCH v2 5/5] MdePkg/BaseLib: ensure ARM LongJump never returns 0 Leif Lindholm
2023-09-29 15:07 ` Sami Mujawar
2023-10-02 17:58 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926171523.368706-1-quic_llindhol@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox