From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 116ABAC19D9 for ; Fri, 29 Sep 2023 21:59:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=i8Sb5mn/tHmu9xeYxZuDIlqunYLK/0NykKx4T8wLJrY=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1696024768; v=1; b=qPB66TV7f9wI+LPhnrCJrzexa3c3GhDX0cLugDHrMzMsSDBFmter47qGSqNjMRSz7ZnNpNgj xOw6Vwk+7TA5vihxbpFfJxDrhwgqum4N//DVS5QCDCXkO/0o6x16QHaXmcQjSMr34yCC/G9g9Jr ofe0ASAmNOYTxZgCShJR8cs8= X-Received: by 127.0.0.2 with SMTP id 5FDxYY7687511x3PakvdGlXP; Fri, 29 Sep 2023 14:59:28 -0700 X-Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by mx.groups.io with SMTP id smtpd.web10.30359.1696024767354344852 for ; Fri, 29 Sep 2023 14:59:27 -0700 X-Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2c17de836fbso92225861fa.1 for ; Fri, 29 Sep 2023 14:59:27 -0700 (PDT) X-Gm-Message-State: BOhNGQzaSclcsDMG7KO3aBwvx7686176AA= X-Google-Smtp-Source: AGHT+IFq1EgwkU9IdIzccJ9z3BJUNOSJzDTLtRUzUW4WWN27nQZEYTffssBdZMbC2kXmL0KA5/uObg== X-Received: by 2002:a2e:93d6:0:b0:2c0:2ab7:9ab5 with SMTP id p22-20020a2e93d6000000b002c02ab79ab5mr4630600ljh.12.1696024765528; Fri, 29 Sep 2023 14:59:25 -0700 (PDT) X-Received: from localhost.localdomain ([185.9.78.108]) by smtp.gmail.com with ESMTPSA id y24-20020a2ebb98000000b002bfe8537f37sm890178lje.33.2023.09.29.14.59.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 29 Sep 2023 14:59:25 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 7/9] RedfishClientPkg: fix memory leak Date: Sat, 30 Sep 2023 00:59:13 +0300 Message-Id: <20230929215915.46616-8-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-1-mike.maslenkin@gmail.com> References: <20230929215915.46616-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qPB66TV7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This patch fixes leak in RedfishExternalResourceResourceFeatureCallback function. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index 32dca964aa0a..9b336d3de479 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -718,6 +718,7 @@ RedfishExternalResourceResourceFeatureCallback ( Private->Uri =3D RedfishGetUri (ResourceUri);=0D if (Private->Uri =3D=3D NULL) {=0D ASSERT (FALSE);=0D + FreePool (ResourceUri);=0D return EFI_OUT_OF_RESOURCES;=0D }=0D =0D @@ -727,6 +728,7 @@ RedfishExternalResourceResourceFeatureCallback ( }=0D =0D FreePool (Private->Uri);=0D + FreePool (ResourceUri);=0D return Status;=0D }=0D =0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109223): https://edk2.groups.io/g/devel/message/109223 Mute This Topic: https://groups.io/mt/101667467/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-