public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mike Maslenkin" <mike.maslenkin@gmail.com>
To: devel@edk2.groups.io
Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com,
	Mike Maslenkin <mike.maslenkin@gmail.com>
Subject: [edk2-devel] [PATCH 1/2] RedfishClientPkg/.github: tune file list for uncrustify check
Date: Sat, 30 Sep 2023 01:24:13 +0300	[thread overview]
Message-ID: <20230929222414.47115-2-mike.maslenkin@gmail.com> (raw)
In-Reply-To: <20230929222414.47115-1-mike.maslenkin@gmail.com>

Original "HEAD~$NO_COMMITS" returns a diff agains current repo state
including not stashed changes. As the purpose of uncrustify is to
check commits, let's get changes against HEAD itself and ignore
local modifications.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 .github/workflows/uncrustify-check.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/uncrustify-check.sh b/.github/workflows/uncrustify-check.sh
index ff61a6ae0f61..c94b892634b8 100755
--- a/.github/workflows/uncrustify-check.sh
+++ b/.github/workflows/uncrustify-check.sh
@@ -31,7 +31,7 @@ fi
 cd "$REPO_PATH"
 
 FAILURE=0
-CHANGED_FILES=$(git diff --name-only HEAD~$NO_COMMITS | grep '\(\.c$\|\.h$\)')
+CHANGED_FILES=$(git diff --name-only HEAD~$NO_COMMITS..HEAD | grep '\(\.c$\|\.h$\)')
 if [ -z "$CHANGED_FILES" ]
 then
   echo "No c or h file to run uncrustify check"
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109231): https://edk2.groups.io/g/devel/message/109231
Mute This Topic: https://groups.io/mt/101667894/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-09-29 22:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 22:24 [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script Mike Maslenkin
2023-09-29 22:24 ` Mike Maslenkin [this message]
2023-09-29 22:24 ` [edk2-devel] [PATCH 2/2] RedfishClientPkg/.github: fix file list for uncrustify check Mike Maslenkin
2023-10-02  3:25 ` [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script Chang, Abner via groups.io
2023-10-03 12:49 ` Nickle Wang via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230929222414.47115-2-mike.maslenkin@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox