[edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

[edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

[Mike Maslenkin]

Please, look at these changes. I've had some troubles when tried to run
uncrustify checks locally on macOS and those fixes helped me.
Also I tried this set on Linux and it worked.

Here is a link to PR:
https://github.com/tianocore/edk2-redfish-client/pull/53

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109230): https://edk2.groups.io/g/devel/message/109230
Mute This Topic: https://groups.io/mt/101667892/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/2] RedfishClientPkg/.github: tune file list for uncrustify check

[Mike Maslenkin]

Original "HEAD~$NO_COMMITS" returns a diff agains current repo state
including not stashed changes. As the purpose of uncrustify is to
check commits, let's get changes against HEAD itself and ignore
local modifications.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 .github/workflows/uncrustify-check.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/uncrustify-check.sh b/.github/workflows/uncrustify-check.sh
index ff61a6ae0f61..c94b892634b8 100755
--- a/.github/workflows/uncrustify-check.sh
+++ b/.github/workflows/uncrustify-check.sh
@@ -31,7 +31,7 @@ fi
 cd "$REPO_PATH"
 
 FAILURE=0
-CHANGED_FILES=$(git diff --name-only HEAD~$NO_COMMITS | grep '\(\.c$\|\.h$\)')
+CHANGED_FILES=$(git diff --name-only HEAD~$NO_COMMITS..HEAD | grep '\(\.c$\|\.h$\)')
 if [ -z "$CHANGED_FILES" ]
 then
   echo "No c or h file to run uncrustify check"
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109231): https://edk2.groups.io/g/devel/message/109231
Mute This Topic: https://groups.io/mt/101667894/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 2/2] RedfishClientPkg/.github: fix file list for uncrustify check

[Mike Maslenkin]

Current `grep` command doesn't work in macOS with
GNU bash, version 3.2.57(1)-release-(arm64-apple-darwin21)

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 .github/workflows/uncrustify-check.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/uncrustify-check.sh b/.github/workflows/uncrustify-check.sh
index c94b892634b8..7c1765cff5ba 100755
--- a/.github/workflows/uncrustify-check.sh
+++ b/.github/workflows/uncrustify-check.sh
@@ -31,7 +31,7 @@ fi
 cd "$REPO_PATH"
 
 FAILURE=0
-CHANGED_FILES=$(git diff --name-only HEAD~$NO_COMMITS..HEAD | grep '\(\.c$\|\.h$\)')
+CHANGED_FILES=$(git diff --name-only HEAD~$NO_COMMITS..HEAD | grep -e '\.c$' -e '\.h')
 if [ -z "$CHANGED_FILES" ]
 then
   echo "No c or h file to run uncrustify check"
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109232): https://edk2.groups.io/g/devel/message/109232
Mute This Topic: https://groups.io/mt/101667895/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Patch set Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Saturday, September 30, 2023 6:24 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Please, look at these changes. I've had some troubles when tried to run
> uncrustify checks locally on macOS and those fixes helped me.
> Also I tried this set on Linux and it worked.
>
> Here is a link to PR:
> https://github.com/tianocore/edk2-redfish-client/pull/53
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109252): https://edk2.groups.io/g/devel/message/109252
Mute This Topic: https://groups.io/mt/101667892/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

[Nickle Wang via groups.io]

[-- Attachment #1: Type: text/plain, Size: 3158 bytes --]



Patch set  Reviewed-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>



Hi @Mike Maslenkin<mailto:mike.maslenkin@gmail.com>, could you please add Abner and my Reviewed-by to two commit messages in this PR? https://github.com/tianocore/edk2-redfish-client/pull/53 And then I will merge this pull request.



This is an example:



Original "HEAD~$NO_COMMITS" returns a diff agains current repo state

including not stashed changes. As the purpose of uncrustify is to

check commits, let's get changes against HEAD itself and ignore

local modifications.



Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>

Reviewed-by: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>

Reviewed-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>



Thanks,

Nickle



> -----Original Message-----

> From: Mike Maslenkin <mike.maslenkin@gmail.com>

> Sent: Saturday, September 30, 2023 6:24 AM

> To: devel@edk2.groups.io

> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;

> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>

> Subject: [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

>

> External email: Use caution opening links or attachments

>

>

> Please, look at these changes. I've had some troubles when tried to run uncrustify

> checks locally on macOS and those fixes helped me.

> Also I tried this set on Linux and it worked.

>

> Here is a link to PR:

> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co<https://github.com/tianocore/edk2-redfish-client/pull/53>

> m%2Ftianocore%2Fedk2-redfish-<https://github.com/tianocore/edk2-redfish-client/pull/53>

> client%2Fpull%2F53&data=05%7C01%7Cnicklew%40nvidia.com%7Cb0010e3e1b<https://github.com/tianocore/edk2-redfish-client/pull/53>

> 704e77ebf308dbc13ad2d3%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0<https://github.com/tianocore/edk2-redfish-client/pull/53>

> %7C638316230613811494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw<https://github.com/tianocore/edk2-redfish-client/pull/53>

> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C<https://github.com/tianocore/edk2-redfish-client/pull/53>

> &sdata=Edar%2Fg4kjvKcj9v6DFz6PBu7zGrIUNt2pU%2FYwyMz6JE%3D&reserved<https://github.com/tianocore/edk2-redfish-client/pull/53>

> =0<https://github.com/tianocore/edk2-redfish-client/pull/53>

>

> Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>

> Cc: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>

> Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>

> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109282): https://edk2.groups.io/g/devel/message/109282
Mute This Topic: https://groups.io/mt/101667892/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 8246 bytes --]