From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9DA17D8023C for ; Fri, 29 Sep 2023 22:48:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3RVjqWcq5fUbKZwx4FM2u/bydzGJA/5yjEU6PsewnbQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1696027695; v=1; b=SWz9BbDmasuNoPWObgfwHqa03IqkZ7xAonkbrheIU0SEd7wjHFN3sm9Xhin8N45H+j0b9Z05 VuHs1PcezSPlNMY9fgW2wwNfEcgVj8ELUkEaBv94daEDsHTiUwovgdoKTjPiLdKeFIuzTzzdAEc rjFyxFscPlOqUCEbOWpBgTXY= X-Received: by 127.0.0.2 with SMTP id CUbQYY7687511xPf3wAC3oFm; Fri, 29 Sep 2023 15:48:15 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.31335.1696027694105857953 for ; Fri, 29 Sep 2023 15:48:14 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10848"; a="361779495" X-IronPort-AV: E=Sophos;i="6.03,188,1694761200"; d="scan'208";a="361779495" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 15:48:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10848"; a="726728055" X-IronPort-AV: E=Sophos;i="6.03,188,1694761200"; d="scan'208";a="726728055" X-Received: from nldesimo-desk.amr.corp.intel.com ([10.241.240.72]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 15:48:12 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Andrew Fish , Ray Ni , Michael D Kinney Subject: [edk2-devel] [PATCH v1] EmulatorPkg: Update MMTimerThread() signature Date: Fri, 29 Sep 2023 15:47:54 -0700 Message-Id: <20230929224754.1950-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gbN4z1CIqg2y6Gv0DNOryu2Lx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SWz9BbDm; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) In the early 2000s as part of the x64 transition the definition for LPTIMECALLBACK changed from (UINT, UINT, DWORD, DWORD, DWORD) to (UINT, UINT, DWORD_PTR, DWORD_PTR, DWORD_PTR). However, the MMTimerThread() function was never updated to the new signature. Since the implementation does not use the last three parameters, this issue has not been caught until now. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- EmulatorPkg/Win/Host/WinThunk.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/EmulatorPkg/Win/Host/WinThunk.c b/EmulatorPkg/Win/Host/WinThunk.c index 42044f2912..12f4f252a2 100644 --- a/EmulatorPkg/Win/Host/WinThunk.c +++ b/EmulatorPkg/Win/Host/WinThunk.c @@ -271,11 +271,11 @@ volatile BOOLEAN mInterruptEnabled = FALSE; VOID CALLBACK MMTimerThread ( - UINT wTimerID, - UINT msg, - DWORD dwUser, - DWORD dw1, - DWORD dw2 + UINT wTimerID, + UINT msg, + DWORD_PTR dwUser, + DWORD_PTR dw1, + DWORD_PTR dw2 ) { UINT32 CurrentTick; -- 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109233): https://edk2.groups.io/g/devel/message/109233 Mute This Topic: https://groups.io/mt/101668165/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-