public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Taylor Beebe" <taylor.d.beebe@gmail.com>
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: [edk2-devel] [PATCH v5 25/28] MdeModulePkg: Delete PCD Profile from SetMemoryProtectionsLib
Date: Sun,  8 Oct 2023 17:07:37 -0700	[thread overview]
Message-ID: <20231009000742.1792-26-taylor.d.beebe@gmail.com> (raw)
In-Reply-To: <20231009000742.1792-1-taylor.d.beebe@gmail.com>

Now that the transition to use SetMemoryProtectionsLib and
GetMemoryProtectionsLib is complete, delete the PCD profile
to avoid confusing the interface. All memory protection settings
will now be set and consumed via the libraries.

Signed-off-by: Taylor Beebe <taylor.d.beebe@gmail.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.c   | 174 +-------------------
 MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h                   |   2 -
 MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.inf |  11 --
 3 files changed, 4 insertions(+), 183 deletions(-)

diff --git a/MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.c b/MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.c
index 5a82a94fe258..b49d68547ce9 100644
--- a/MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.c
+++ b/MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.c
@@ -10,7 +10,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/BaseLib.h>
 #include <Library/DebugLib.h>
 #include <Library/BaseMemoryLib.h>
-#include <Library/PcdLib.h>
 #include <Library/SetMemoryProtectionsLib.h>
 
 #pragma pack(1)
@@ -249,99 +248,6 @@ typedef struct {
   }                                                               \
 }
 
-//
-//  A memory profile which uses the fixed at build PCDs defined in MdeModulePkg.dec
-//
-#define DXE_MEMORY_PROTECTION_SETTINGS_PCD                                                                                            \
-{                                                                                                                                     \
-  DXE_MEMORY_PROTECTION_SIGNATURE,                                                                                                    \
-  DXE_MEMORY_PROTECTION_SETTINGS_CURRENT_VERSION,                                                                                     \
-  FixedPcdGetBool (PcdCpuStackGuard), /* Stack Guard */                                                                               \
-  TRUE,                               /* Stack Execution Protection (MUST BE POPULATED) */                                            \
-  {                                   /* NULL Pointer Detection */                                                                    \
-    .Enabled            = ((FixedPcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT0) != 0),                                         \
-    .DisableEndOfDxe    = ((FixedPcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT7) != 0),                                         \
-    .NonstopModeEnabled = ((FixedPcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT6) != 0)                                          \
-  },                                                                                                                                  \
-  { /* Image Protection */                                                                                                            \
-    .ProtectImageFromUnknown = ((FixedPcdGet32 (PcdImageProtectionPolicy) & BIT0) != 0),                                              \
-    .ProtectImageFromFv      = ((FixedPcdGet32 (PcdImageProtectionPolicy) & BIT1) != 0)                                               \
-  },                                                                                                                                  \
-  { /* Execution Protection */                                                                                                        \
-    .EnabledForType = {                                                                                                               \
-      [EfiReservedMemoryType]               = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiReservedMemoryType) != 0),        \
-      [EfiLoaderCode]                       = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiLoaderCode) != 0),                \
-      [EfiLoaderData]                       = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiLoaderData) != 0),                \
-      [EfiBootServicesCode]                 = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiBootServicesCode) != 0),          \
-      [EfiBootServicesData]                 = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiBootServicesData) != 0),          \
-      [EfiRuntimeServicesCode]              = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiRuntimeServicesCode) != 0),       \
-      [EfiRuntimeServicesData]              = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiRuntimeServicesData) != 0),       \
-      [EfiConventionalMemory]               = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiConventionalMemory) != 0),        \
-      [EfiUnusableMemory]                   = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiUnusableMemory) != 0),            \
-      [EfiACPIReclaimMemory]                = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiACPIReclaimMemory) != 0),         \
-      [EfiACPIMemoryNVS]                    = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiACPIMemoryNVS) != 0),             \
-      [EfiMemoryMappedIO]                   = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiMemoryMappedIO) != 0),            \
-      [EfiMemoryMappedIOPortSpace]          = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiMemoryMappedIOPortSpace) != 0),   \
-      [EfiPalCode]                          = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiPalCode) != 0),                   \
-      [EfiPersistentMemory]                 = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiPersistentMemory) != 0),          \
-      [EfiUnacceptedMemoryType]             = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & EfiUnacceptedMemoryType) != 0),      \
-      [OEM_RESERVED_MPS_MEMORY_TYPE]        = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & BIT62) != 0),                        \
-      [OS_RESERVED_MPS_MEMORY_TYPE]         = ((FixedPcdGet64 (PcdDxeNxMemoryProtectionPolicy) & BIT63) != 0)                         \
-    }                                                                                                                                 \
-  },                                                                                                                                  \
-  { /* Heap Guard */                                                                                                                  \
-    .PageGuardEnabled                       = ((FixedPcdGet8 (PcdHeapGuardPropertyMask) & BIT0) != 0),                                \
-    .PoolGuardEnabled                       = ((FixedPcdGet8 (PcdHeapGuardPropertyMask) & BIT1) != 0),                                \
-    .FreedMemoryGuardEnabled                = ((FixedPcdGet8 (PcdHeapGuardPropertyMask) & BIT4) != 0),                                \
-    .NonstopModeEnabled                     = ((FixedPcdGet8 (PcdHeapGuardPropertyMask) & BIT6) != 0),                                \
-    .GuardAlignedToTail                     = ((FixedPcdGet8 (PcdHeapGuardPropertyMask) & BIT7) == 0)                                 \
-  },                                                                                                                                  \
-  { /* Pool Guard */                                                                                                                  \
-    .EnabledForType = {                                                                                                               \
-      [EfiReservedMemoryType]               = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiReservedMemoryType) != 0),                  \
-      [EfiLoaderCode]                       = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiLoaderCode) != 0),                          \
-      [EfiLoaderData]                       = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiLoaderData) != 0),                          \
-      [EfiBootServicesCode]                 = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiBootServicesCode) != 0),                    \
-      [EfiBootServicesData]                 = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiBootServicesData) != 0),                    \
-      [EfiRuntimeServicesCode]              = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiRuntimeServicesCode) != 0),                 \
-      [EfiRuntimeServicesData]              = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiRuntimeServicesData) != 0),                 \
-      [EfiConventionalMemory]               = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiConventionalMemory) != 0),                  \
-      [EfiUnusableMemory]                   = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiUnusableMemory) != 0),                      \
-      [EfiACPIReclaimMemory]                = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiACPIReclaimMemory) != 0),                   \
-      [EfiACPIMemoryNVS]                    = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiACPIMemoryNVS) != 0),                       \
-      [EfiMemoryMappedIO]                   = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiMemoryMappedIO) != 0),                      \
-      [EfiMemoryMappedIOPortSpace]          = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiMemoryMappedIOPortSpace) != 0),             \
-      [EfiPalCode]                          = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiPalCode) != 0),                             \
-      [EfiPersistentMemory]                 = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiPersistentMemory) != 0),                    \
-      [EfiUnacceptedMemoryType]             = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiUnacceptedMemoryType) != 0),                \
-      [OEM_RESERVED_MPS_MEMORY_TYPE]        = ((FixedPcdGet64 (PcdHeapGuardPoolType) & BIT62) != 0),                                  \
-      [OS_RESERVED_MPS_MEMORY_TYPE]         = ((FixedPcdGet64 (PcdHeapGuardPoolType) & BIT63) != 0)                                   \
-    }                                                                                                                                 \
-  },                                                                                                                                  \
-  { /* Page Guard */                                                                                                                  \
-    .EnabledForType = {                                                                                                               \
-      [EfiReservedMemoryType]               = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiReservedMemoryType) != 0),                  \
-      [EfiLoaderCode]                       = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiLoaderCode) != 0),                          \
-      [EfiLoaderData]                       = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiLoaderData) != 0),                          \
-      [EfiBootServicesCode]                 = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiBootServicesCode) != 0),                    \
-      [EfiBootServicesData]                 = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiBootServicesData) != 0),                    \
-      [EfiRuntimeServicesCode]              = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiRuntimeServicesCode) != 0),                 \
-      [EfiRuntimeServicesData]              = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiRuntimeServicesData) != 0),                 \
-      [EfiConventionalMemory]               = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiConventionalMemory) != 0),                  \
-      [EfiUnusableMemory]                   = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiUnusableMemory) != 0),                      \
-      [EfiACPIReclaimMemory]                = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiACPIReclaimMemory) != 0),                   \
-      [EfiACPIMemoryNVS]                    = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiACPIMemoryNVS) != 0),                       \
-      [EfiMemoryMappedIO]                   = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiMemoryMappedIO) != 0),                      \
-      [EfiMemoryMappedIOPortSpace]          = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiMemoryMappedIOPortSpace) != 0),             \
-      [EfiPalCode]                          = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiPalCode) != 0),                             \
-      [EfiPersistentMemory]                 = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiPersistentMemory) != 0),                    \
-      [EfiUnacceptedMemoryType]             = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiUnacceptedMemoryType) != 0),                \
-      [OEM_RESERVED_MPS_MEMORY_TYPE]        = ((FixedPcdGet64 (PcdHeapGuardPageType) & BIT62) != 0),                                  \
-      [OS_RESERVED_MPS_MEMORY_TYPE]         = ((FixedPcdGet64 (PcdHeapGuardPageType) & BIT63) != 0)                                   \
-    }                                                                                                                                 \
-  }                                                                                                                                   \
-}
-
 //  A memory profile recommended for compatibility with older
 //  versions of Grub.
 //
@@ -556,69 +462,6 @@ typedef struct {
   }                                                \
 }
 
-//
-//  A memory profile which uses the fixed at build PCDs defined in MdeModulePkg.dec
-//
-#define MM_MEMORY_PROTECTION_SETTINGS_PCD                                                                                 \
-{                                                                                                                         \
-  MM_MEMORY_PROTECTION_SIGNATURE,                                                                                         \
-  MM_MEMORY_PROTECTION_SETTINGS_CURRENT_VERSION,                                                                          \
-  { /* NULL Pointer Detection */                                                                                          \
-    .Enabled            = ((FixedPcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT1) != 0),                             \
-    .NonstopModeEnabled = ((FixedPcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT6) != 0)                              \
-  },                                                                                                                      \
-  { /* Heap Guard */                                                                                                      \
-    .PageGuardEnabled                       = ((FixedPcdGet8(PcdHeapGuardPropertyMask) & BIT2) != 0),                     \
-    .PoolGuardEnabled                       = ((FixedPcdGet8(PcdHeapGuardPropertyMask) & BIT3) != 0),                     \
-    .NonstopModeEnabled                     = ((FixedPcdGet8(PcdHeapGuardPropertyMask) & BIT6) != 0),                     \
-    .GuardAlignedToTail                     = ((FixedPcdGet8(PcdHeapGuardPropertyMask) & BIT7) == 0)                      \
-  },                                                                                                                      \
-  { /* Pool Guard */                                                                                                      \
-    .EnabledForType = {                                                                                                   \
-      [EfiReservedMemoryType]               = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiReservedMemoryType) != 0),      \
-      [EfiLoaderCode]                       = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiLoaderCode) != 0),              \
-      [EfiLoaderData]                       = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiLoaderData) != 0),              \
-      [EfiBootServicesCode]                 = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiBootServicesCode) != 0),        \
-      [EfiBootServicesData]                 = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiBootServicesData) != 0),        \
-      [EfiRuntimeServicesCode]              = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiRuntimeServicesCode) != 0),     \
-      [EfiRuntimeServicesData]              = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiRuntimeServicesData) != 0),     \
-      [EfiConventionalMemory]               = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiConventionalMemory) != 0),      \
-      [EfiUnusableMemory]                   = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiUnusableMemory) != 0),          \
-      [EfiACPIReclaimMemory]                = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiACPIReclaimMemory) != 0),       \
-      [EfiACPIMemoryNVS]                    = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiACPIMemoryNVS) != 0),           \
-      [EfiMemoryMappedIO]                   = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiMemoryMappedIO) != 0),          \
-      [EfiMemoryMappedIOPortSpace]          = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiMemoryMappedIOPortSpace) != 0), \
-      [EfiPalCode]                          = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiPalCode) != 0),                 \
-      [EfiPersistentMemory]                 = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiPersistentMemory) != 0),        \
-      [EfiUnacceptedMemoryType]             = ((FixedPcdGet64 (PcdHeapGuardPoolType) & EfiUnacceptedMemoryType) != 0),    \
-      [OEM_RESERVED_MPS_MEMORY_TYPE]        = ((FixedPcdGet64 (PcdHeapGuardPoolType) & BIT62) != 0),                      \
-      [OS_RESERVED_MPS_MEMORY_TYPE]         = ((FixedPcdGet64 (PcdHeapGuardPoolType) & BIT63) != 0)                       \
-    }                                                                                                                     \
-  },                                                                                                                      \
-  { /* Page Guard */                                                                                                      \
-    .EnabledForType = {                                                                                                   \
-      [EfiReservedMemoryType]               = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiReservedMemoryType) != 0),      \
-      [EfiLoaderCode]                       = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiLoaderCode) != 0),              \
-      [EfiLoaderData]                       = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiLoaderData) != 0),              \
-      [EfiBootServicesCode]                 = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiBootServicesCode) != 0),        \
-      [EfiBootServicesData]                 = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiBootServicesData) != 0),        \
-      [EfiRuntimeServicesCode]              = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiRuntimeServicesCode) != 0),     \
-      [EfiRuntimeServicesData]              = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiRuntimeServicesData) != 0),     \
-      [EfiConventionalMemory]               = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiConventionalMemory) != 0),      \
-      [EfiUnusableMemory]                   = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiUnusableMemory) != 0),          \
-      [EfiACPIReclaimMemory]                = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiACPIReclaimMemory) != 0),       \
-      [EfiACPIMemoryNVS]                    = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiACPIMemoryNVS) != 0),           \
-      [EfiMemoryMappedIO]                   = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiMemoryMappedIO) != 0),          \
-      [EfiMemoryMappedIOPortSpace]          = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiMemoryMappedIOPortSpace) != 0), \
-      [EfiPalCode]                          = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiPalCode) != 0),                 \
-      [EfiPersistentMemory]                 = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiPersistentMemory) != 0),        \
-      [EfiUnacceptedMemoryType]             = ((FixedPcdGet64 (PcdHeapGuardPageType) & EfiUnacceptedMemoryType) != 0),    \
-      [OEM_RESERVED_MPS_MEMORY_TYPE]        = ((FixedPcdGet64 (PcdHeapGuardPageType) & BIT62) != 0),                      \
-      [OS_RESERVED_MPS_MEMORY_TYPE]         = ((FixedPcdGet64 (PcdHeapGuardPageType) & BIT63) != 0)                       \
-    }                                                                                                                     \
-  }                                                                                                                       \
-}
-
 //
 //  A memory profile which disables all MM memory protection settings.
 //
@@ -660,11 +503,6 @@ DXE_MEMORY_PROTECTION_PROFILES  DxeMemoryProtectionProfiles[DxeMemoryProtectionS
     .Description = "Release profile without page guards recommended for performance sensitive production scenarios",
     .Settings    = DXE_MEMORY_PROTECTION_SETTINGS_PROD_MODE_NO_PAGE_GUARDS
   },
-  [DxeMemoryProtectionSettingsPcd] =                 {
-    .Name        = "Pcd",
-    .Description = "Memory protection settings from PCDs",
-    .Settings    = DXE_MEMORY_PROTECTION_SETTINGS_PCD
-  },
   [DxeMemoryProtectionSettingsGrubCompat] =          {
     .Name        = "GrubCompat",
     .Description = "DXE_MEMORY_PROTECTION_SETTINGS_PROD_MODE with some protections disabled for legacy Grub compatibility",
@@ -688,11 +526,6 @@ MM_MEMORY_PROTECTION_PROFILES  MmMemoryProtectionProfiles[MmMemoryProtectionSett
     .Description = "Release profile recommended for production scenarios",
     .Settings    = MM_MEMORY_PROTECTION_SETTINGS_PROD_MODE
   },
-  [MmMemoryProtectionSettingsPcd] =     {
-    .Name        = "Pcd",
-    .Description = "Memory protection settings from PCDs",
-    .Settings    = MM_MEMORY_PROTECTION_SETTINGS_PCD
-  },
   [MmMemoryProtectionSettingsOff] =     {
     .Name        = "Off",
     .Description = "Disables all memory protection settings",
@@ -727,9 +560,10 @@ GetOrCreateMemoryProtectionSettings (
   }
 
   ZeroMem (&Mpsp, sizeof (Mpsp));
-  Mpsp.Mps.Dxe                                 = DxeMemoryProtectionProfiles[DxeMemoryProtectionSettingsPcd].Settings;
-  Mpsp.Mps.Mm                                  = MmMemoryProtectionProfiles[MmMemoryProtectionSettingsPcd].Settings;
-  Mpsp.Mps.Dxe.StackExecutionProtectionEnabled = PcdGetBool (PcdSetNxForStack);
+  Mpsp.Mps.Dxe.StructVersion = DXE_MEMORY_PROTECTION_SETTINGS_CURRENT_VERSION;
+  Mpsp.Mps.Dxe.Signature     = DXE_MEMORY_PROTECTION_SIGNATURE;
+  Mpsp.Mps.Mm.StructVersion  = MM_MEMORY_PROTECTION_SETTINGS_CURRENT_VERSION;
+  Mpsp.Mps.Mm.Signature      = MM_MEMORY_PROTECTION_SIGNATURE;
 
   Ptr = BuildGuidDataHob (
           &gMemoryProtectionSettingsGuid,
diff --git a/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h b/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h
index 3638ba7e3ef7..02e1a2995171 100644
--- a/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h
+++ b/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h
@@ -22,7 +22,6 @@ typedef enum {
   DxeMemoryProtectionSettingsReleaseNoPageGuards,
   DxeMemoryProtectionSettingsGrubCompat,
   DxeMemoryProtectionSettingsOff,
-  DxeMemoryProtectionSettingsPcd,
   DxeMemoryProtectionSettingsMax
 } DXE_MEMORY_PROTECTION_PROFILE_INDEX;
 
@@ -36,7 +35,6 @@ typedef enum {
   MmMemoryProtectionSettingsDebug = 0,
   MmMemoryProtectionSettingsRelease,
   MmMemoryProtectionSettingsOff,
-  MmMemoryProtectionSettingsPcd,
   MmMemoryProtectionSettingsMax
 } MM_MEMORY_PROTECTION_PROFILE_INDEX;
 
diff --git a/MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.inf b/MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.inf
index 2e4a9a66ac68..830d151a8378 100644
--- a/MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.inf
+++ b/MdeModulePkg/Library/SetMemoryProtectionsLib/SetMemoryProtectionsLib.inf
@@ -29,17 +29,6 @@ [LibraryClasses]
   BaseLib
   HobLib
   DebugLib
-  PcdLib
-
-[Pcd]
-  gEfiMdeModulePkgTokenSpaceGuid.PcdNullPointerDetectionPropertyMask
-  gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPageType
-  gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPoolType
-  gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask
-  gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard
-  gEfiMdeModulePkgTokenSpaceGuid.PcdDxeNxMemoryProtectionPolicy
-  gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack
-  gEfiMdeModulePkgTokenSpaceGuid.PcdImageProtectionPolicy
 
 [Guids]
   gMemoryProtectionSettingsGuid
-- 
2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109430): https://edk2.groups.io/g/devel/message/109430
Mute This Topic: https://groups.io/mt/101843369/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2023-10-09  0:08 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09  0:07 [edk2-devel] [PATCH v5 00/28] Implement Dynamic Memory Protection Settings Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 01/28] MdeModulePkg: Add DXE and MM Memory Protection Settings Definitions Taylor Beebe
2023-11-03  5:52   ` Ni, Ray
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 02/28] MdeModulePkg: Define SetMemoryProtectionsLib and GetMemoryProtectionsLib Taylor Beebe
2023-10-09  7:52   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 03/28] MdeModulePkg: Add NULL Instances for Get/SetMemoryProtectionsLib Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 04/28] MdeModulePkg: Implement SetMemoryProtectionsLib and GetMemoryProtectionsLib Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 05/28] MdeModulePkg: Copy PEI PCD Database Into New Buffer Taylor Beebe
2023-10-09  6:47   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 06/28] MdeModulePkg: Apply Protections to the HOB List Taylor Beebe
2023-10-09  6:54   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 07/28] MdeModulePkg: Check Print Level Before Dumping GCD Memory Map Taylor Beebe
2023-10-09  7:10   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 08/28] UefiCpuPkg: Always Set Stack Guard in MpPei Init Taylor Beebe
2023-10-09  7:28   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 09/28] ArmVirtPkg: Add Memory Protection Library Definitions to Platforms Taylor Beebe
2023-10-09  7:30   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 10/28] OvmfPkg: " Taylor Beebe
2023-10-09  7:47   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 11/28] OvmfPkg: Apply Memory Protections via SetMemoryProtectionsLib Taylor Beebe
2023-10-09  8:19   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 12/28] OvmfPkg: Update PeilessStartupLib to use SetMemoryProtectionsLib Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 13/28] UefiPayloadPkg: Update DXE Handoff " Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 14/28] MdeModulePkg: " Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 15/28] ArmPkg: Use GetMemoryProtectionsLib instead of Memory Protection PCDs Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 16/28] EmulatorPkg: " Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 17/28] OvmfPkg: " Taylor Beebe
2023-10-09  8:29   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 18/28] UefiCpuPkg: " Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 19/28] MdeModulePkg: " Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 20/28] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib Taylor Beebe
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 21/28] OvmfPkg: Add QemuFwCfgParseString to QemuFwCfgSimpleParserLib Taylor Beebe
2023-10-09  8:40   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 22/28] OvmfPkg: Add MemoryProtectionConfigLib Taylor Beebe
2023-10-09  9:17   ` Laszlo Ersek
2023-10-09  9:22     ` Laszlo Ersek
2023-10-09  9:34   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 23/28] OvmfPkg: Enable Choosing Memory Protection Profile via QemuCfg Taylor Beebe
2023-10-09  9:53   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 24/28] ArmVirtPkg: Apply Memory Protections via SetMemoryProtectionsLib Taylor Beebe
2023-10-09 10:00   ` Laszlo Ersek
2023-10-10 11:48     ` Gerd Hoffmann
2023-10-09  0:07 ` Taylor Beebe [this message]
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 26/28] OvmfPkg: Delete Memory Protection PCDs Taylor Beebe
2023-10-09 10:02   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 27/28] ArmVirtPkg: " Taylor Beebe
2023-10-09 10:02   ` Laszlo Ersek
2023-10-09  0:07 ` [edk2-devel] [PATCH v5 28/28] MdeModulePkg: " Taylor Beebe
2023-10-09 10:03   ` Laszlo Ersek
2023-10-09 14:47     ` Taylor Beebe
2023-10-09 10:16 ` [edk2-devel] [PATCH v5 00/28] Implement Dynamic Memory Protection Settings Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231009000742.1792-26-taylor.d.beebe@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox