[edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg

["Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>]

From: Abner Chang <abner.chang@amd.com>

Remove duplicate IpmiCommandLib.h and use the one
under MdeModulePKg instead.

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../IpmiFeaturePkg/BmcElog/BmcElog.inf        |   1 +
 .../IpmiFeaturePkg/Frb/FrbPei.inf             |   1 +
 .../GenericIpmi/Dxe/GenericIpmi.inf           |   1 +
 .../GenericIpmi/Pei/PeiGenericIpmi.inf        |   1 +
 .../GenericIpmi/Smm/SmmGenericIpmi.inf        |   1 +
 .../IpmiFeaturePkg/IpmiFru/IpmiFru.inf        |   1 +
 .../IpmiFeaturePkg/OsWdt/OsWdt.inf            |   1 +
 .../IpmiFeaturePkg/SolStatus/SolStatus.inf    |   1 +
 .../Include/Library/IpmiCommandLib.h          | 314 ------------------
 9 files changed, 8 insertions(+), 314 deletions(-)
 delete mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiCommandLib.h

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf
index 388dd2740c..1e7a7658b7 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf
@@ -21,6 +21,7 @@
 
 [Packages]
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
   IpmiFeaturePkg/IpmiFeaturePkg.dec
 
 [LibraryClasses]
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf
index 797dbe6a07..bfd80d4a98 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf
@@ -20,6 +20,7 @@
 
 [Packages]
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
   IpmiFeaturePkg/IpmiFeaturePkg.dec
 
 [LibraryClasses]
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/GenericIpmi.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/GenericIpmi.inf
index 1564ceb08a..d37d1c5046 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/GenericIpmi.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/GenericIpmi.inf
@@ -37,6 +37,7 @@
 
 [Packages]
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
   IpmiFeaturePkg/IpmiFeaturePkg.dec
 
 [LibraryClasses]
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf
index 3a73180ce6..d7fb7f1c5b 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf
@@ -36,6 +36,7 @@
 
 [Packages]
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
   IpmiFeaturePkg/IpmiFeaturePkg.dec
 
 [LibraryClasses]
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.inf
index 12dc17ae84..75162007ce 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.inf
@@ -28,6 +28,7 @@
 
 [Packages]
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
   IpmiFeaturePkg/IpmiFeaturePkg.dec
 
 [LibraryClasses]
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf
index 322f061a0f..f5778f3468 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf
@@ -21,6 +21,7 @@
 
 [Packages]
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
   IpmiFeaturePkg/IpmiFeaturePkg.dec
 
 [LibraryClasses]
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.inf
index 3fd1078271..e90cd4d55e 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.inf
@@ -20,6 +20,7 @@
 
 [Packages]
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
   IpmiFeaturePkg/IpmiFeaturePkg.dec
 
 [LibraryClasses]
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.inf
index 9019b849ac..8690c493a1 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.inf
@@ -21,6 +21,7 @@
 
 [Packages]
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
   IpmiFeaturePkg/IpmiFeaturePkg.dec
 
 [Pcd]
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiCommandLib.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiCommandLib.h
deleted file mode 100644
index d5f8f1d01b..0000000000
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiCommandLib.h
+++ /dev/null
@@ -1,314 +0,0 @@
-/** @file
-  This library abstract how to send/receive IPMI command.
-
-Copyright (c) 2018-2021, Intel Corporation. All rights reserved.<BR>
-Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
-
-SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-
-#ifndef _IPMI_COMMAND_LIB_H_
-#define _IPMI_COMMAND_LIB_H_
-
-#include <Uefi.h>
-#include <IndustryStandard/Ipmi.h>
-
-//
-// NetFnApp
-//
-EFI_STATUS
-EFIAPI
-IpmiGetDeviceId (
-  OUT IPMI_GET_DEVICE_ID_RESPONSE  *DeviceId
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetSelfTestResult (
-  OUT IPMI_SELF_TEST_RESULT_RESPONSE   *SelfTestResult
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiResetWatchdogTimer (
-  OUT UINT8                            *CompletionCode
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiSetWatchdogTimer (
-  IN  IPMI_SET_WATCHDOG_TIMER_REQUEST  *SetWatchdogTimer,
-  OUT UINT8                            *CompletionCode
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetWatchdogTimer (
-  OUT IPMI_GET_WATCHDOG_TIMER_RESPONSE *GetWatchdogTimer
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiSetBmcGlobalEnables (
-  IN  IPMI_SET_BMC_GLOBAL_ENABLES_REQUEST  *SetBmcGlobalEnables,
-  OUT UINT8                                *CompletionCode
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetBmcGlobalEnables (
-  OUT IPMI_GET_BMC_GLOBAL_ENABLES_RESPONSE *GetBmcGlobalEnables
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiClearMessageFlags (
-  IN  IPMI_CLEAR_MESSAGE_FLAGS_REQUEST  *ClearMessageFlagsRequest,
-  OUT UINT8                             *CompletionCode
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetMessageFlags (
-  OUT IPMI_GET_MESSAGE_FLAGS_RESPONSE *GetMessageFlagsResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetMessage (
-  OUT IPMI_GET_MESSAGE_RESPONSE *GetMessageResponse,
-  IN OUT UINT32                 *GetMessageResponseSize
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiSendMessage (
-  IN  IPMI_SEND_MESSAGE_REQUEST  *SendMessageRequest,
-  IN  UINT32                     SendMessageRequestSize,
-  OUT IPMI_SEND_MESSAGE_RESPONSE *SendMessageResponse,
-  IN OUT UINT32                  *SendMessageResponseSize
-  );
-
-/**
-  This function gets the system UUID.
-
-  @param[out] SystemGuid   The pointer to retrieve system UUID.
-
-  @retval EFI_SUCCESS               UUID is returned.
-  @retval EFI_INVALID_PARAMETER     SystemGuid is a NULL pointer.
-  @retval Others                    Other errors.
-
-**/
-EFI_STATUS
-EFIAPI
-IpmiGetSystemUuid (
-  OUT EFI_GUID *SystemGuid
-  );
-
-/**
-  This function gets the channel information.
-
-  @param[in]  GetChannelInfoRequest           The get channel information request.
-  @param[out] GetChannelInfoResponse          The get channel information response.
-  @param[out] GetChannelInfoResponseSize      When input, the expected size of response.
-                                              When output, the exact size of the returned
-                                              response.
-
-  @retval EFI_SUCCESS            Get channel information successfully.
-  @retval EFI_INVALID_PARAMETER  One of the given input parameters is invalid.
-  @retval Others                 Other errors.
-
-**/
-EFI_STATUS
-EFIAPI
-IpmiGetChannelInfo (
-  IN  IPMI_GET_CHANNEL_INFO_REQUEST  *GetChannelInfoRequest,
-  OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse,
-  OUT UINT32                         *GetChannelInfoResponseSize
-  );
-
-//
-// NetFnTransport
-//
-EFI_STATUS
-EFIAPI
-IpmiSolActivating (
-  IN  IPMI_SOL_ACTIVATING_REQUEST  *SolActivatingRequest,
-  OUT UINT8                        *CompletionCode
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiSetSolConfigurationParameters (
-  IN  IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST  *SetConfigurationParametersRequest,
-  IN  UINT32                                         SetConfigurationParametersRequestSize,
-  OUT UINT8                                          *CompletionCode
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetSolConfigurationParameters (
-  IN  IPMI_GET_SOL_CONFIGURATION_PARAMETERS_REQUEST  *GetConfigurationParametersRequest,
-  OUT IPMI_GET_SOL_CONFIGURATION_PARAMETERS_RESPONSE *GetConfigurationParametersResponse,
-  IN OUT UINT32                                      *GetConfigurationParametersResponseSize
-  );
-
-/**
-  This function gets the LAN configuration parameter.
-
-  @param[in]     GetLanConfigurationParametersRequest   Request data
-  @param[out]    GetLanConfigurationParametersResponse  Response data
-  @param[in,out] GetLanConfigurationParametersSize      When input, the expected size of response data.
-                                                        When out, the exact size of response data.
-
-  @retval EFI_SUCCESS            Lan configuration parameter is returned in the response.
-  @retval EFI_INVALID_PARAMETER  One of the given input parameters is invalid.
-  @retval Others                 Other errors.
-
-**/
-
-EFI_STATUS
-EFIAPI
-IpmiGetLanConfigurationParameters (
-  IN     IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST  *GetLanConfigurationParametersRequest,
-  OUT    IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE *GetLanConfigurationParametersResponse,
-  IN OUT UINT32                                         *GetLanConfigurationParametersSize
-  );
-
-//
-// NetFnChasis
-//
-EFI_STATUS
-EFIAPI
-IpmiGetChassisCapabilities (
-  OUT IPMI_GET_CHASSIS_CAPABILITIES_RESPONSE  *GetChassisCapabilitiesResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetChassisStatus (
-  OUT IPMI_GET_CHASSIS_STATUS_RESPONSE  *GetChassisStatusResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiChassisControl (
-  IN IPMI_CHASSIS_CONTROL_REQUEST  *ChassisControlRequest,
-  OUT UINT8                        *CompletionCode
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiSetPowerRestorePolicy (
-  IN  IPMI_SET_POWER_RESTORE_POLICY_REQUEST  *ChassisControlRequest,
-  OUT IPMI_SET_POWER_RESTORE_POLICY_RESPONSE *ChassisControlResponse
-  );
-
-//
-// NetFnStorage
-//
-EFI_STATUS
-EFIAPI
-IpmiSetSystemBootOptions (
-  IN  IPMI_SET_BOOT_OPTIONS_REQUEST  *BootOptionsRequest,
-  OUT IPMI_SET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetSystemBootOptions (
-  IN  IPMI_GET_BOOT_OPTIONS_REQUEST  *BootOptionsRequest,
-  OUT IPMI_GET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse
-  );
-
-//
-// NetFnStorage
-//
-EFI_STATUS
-EFIAPI
-IpmiGetFruInventoryAreaInfo (
-  IN  IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST   *GetFruInventoryAreaInfoRequest,
-  OUT IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE  *GetFruInventoryAreaInfoResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiReadFruData (
-  IN  IPMI_READ_FRU_DATA_REQUEST        *ReadFruDataRequest,
-  OUT IPMI_READ_FRU_DATA_RESPONSE       *ReadFruDataResponse,
-  IN OUT UINT32                         *ReadFruDataResponseSize
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiWriteFruData (
-  IN  IPMI_WRITE_FRU_DATA_REQUEST       *WriteFruDataRequest,
-  IN  UINT32                            WriteFruDataRequestSize,
-  OUT IPMI_WRITE_FRU_DATA_RESPONSE      *WriteFruDataResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetSelInfo (
-  OUT IPMI_GET_SEL_INFO_RESPONSE  *GetSelInfoResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetSelEntry (
-  IN IPMI_GET_SEL_ENTRY_REQUEST    *GetSelEntryRequest,
-  OUT IPMI_GET_SEL_ENTRY_RESPONSE  *GetSelEntryResponse,
-  IN OUT UINT32                    *GetSelEntryResponseSize
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiAddSelEntry (
-  IN IPMI_ADD_SEL_ENTRY_REQUEST    *AddSelEntryRequest,
-  OUT IPMI_ADD_SEL_ENTRY_RESPONSE  *AddSelEntryResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiPartialAddSelEntry (
-  IN IPMI_PARTIAL_ADD_SEL_ENTRY_REQUEST    *PartialAddSelEntryRequest,
-  IN UINT32                                PartialAddSelEntryRequestSize,
-  OUT IPMI_PARTIAL_ADD_SEL_ENTRY_RESPONSE  *PartialAddSelEntryResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiClearSel (
-  IN IPMI_CLEAR_SEL_REQUEST   *ClearSelRequest,
-  OUT IPMI_CLEAR_SEL_RESPONSE *ClearSelResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetSelTime (
-  OUT IPMI_GET_SEL_TIME_RESPONSE *GetSelTimeResponse
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiSetSelTime (
-  IN IPMI_SET_SEL_TIME_REQUEST  *SetSelTimeRequest,
-  OUT UINT8                     *CompletionCode
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetSdrRepositoryInfo (
-  OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE  *GetSdrRepositoryInfoResp
-  );
-
-EFI_STATUS
-EFIAPI
-IpmiGetSdr (
-  IN  IPMI_GET_SDR_REQUEST          *GetSdrRequest,
-  OUT IPMI_GET_SDR_RESPONSE         *GetSdrResponse,
-  IN OUT UINT32                     *GetSdrResponseSize
-  );
-
-#endif
-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109477): https://edk2.groups.io/g/devel/message/109477
Mute This Topic: https://groups.io/mt/101870849/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-