[edk2-devel] [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface Capabilities

[edk2-devel] [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface Capabilities

[Chang, Abner via groups.io]

From: Abner Chang <abner.chang@amd.com>

Define the structure for IPMI Get System Interface
Capabilities command (0x57)

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
---
 MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
index b6bc91f46c2..d973b7155b3 100644
--- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
+++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
@@ -1092,6 +1092,14 @@ typedef struct {
   UINT8                                          InputMaxMsgSize;
 } IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE;
 
+//
+// Response of interface capability of SSIF/KCS/SMIC.
+//
+typedef union {
+  IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE      *InterfaceSsifCapability;
+  IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE  *InterfaceKcsSmicCapability;
+} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_RESPONSE;
+
 //
 //  Definitions for Get System Interface Capabilities command SSIF transaction support
 //
-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109479): https://edk2.groups.io/g/devel/message/109479
Mute This Topic: https://groups.io/mt/101870986/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface Capabilities

[Chang, Abner via groups.io]

From: Abner Chang <abner.chang@amd.com>

Define the API for IPMI Get System Interface
Capabilities command (0x57)

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 MdeModulePkg/Include/Library/IpmiCommandLib.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/MdeModulePkg/Include/Library/IpmiCommandLib.h b/MdeModulePkg/Include/Library/IpmiCommandLib.h
index 7edaf36cbe5..a84124c01e9 100644
--- a/MdeModulePkg/Include/Library/IpmiCommandLib.h
+++ b/MdeModulePkg/Include/Library/IpmiCommandLib.h
@@ -249,6 +249,23 @@ IpmiGetChannelInfo (
   OUT UINT32                          *GetChannelInfoResponseSize
   );
 
+/**
+  This function gets system interface capability
+
+  @param[in]  InterfaceCapabilityRequest    Get system interface capability request.
+  @param[out] InterfaceCapabilityResponse   The response of system interface capability.
+
+  @retval EFI_SUCCESS            Command is sent successfully.
+  @retval Other                  Failure.
+
+**/
+EFI_STATUS
+EFIAPI
+IpmiGetSystemInterfaceCapability (
+  IN  IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST  *InterfaceCapabilityRequest,
+  OUT IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_RESPONSE *InterfaceCapabilityResponse
+  );
+
 //
 // IPMI NetFnTransport
 //
-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109480): https://edk2.groups.io/g/devel/message/109480
Mute This Topic: https://groups.io/mt/101870987/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface Capabilities

[gaoliming via groups.io]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: abner.chang@amd.com <abner.chang@amd.com>
> 发送时间: 2023年10月10日 16:36
> 收件人: devel@edk2.groups.io
> 抄送: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface
> Capabilities
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> Define the structure for IPMI Get System Interface
> Capabilities command (0x57)
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> index b6bc91f46c2..d973b7155b3 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> @@ -1092,6 +1092,14 @@ typedef struct {
>    UINT8
> InputMaxMsgSize;
>  } IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE;
> 
> +//
> +// Response of interface capability of SSIF/KCS/SMIC.
> +//
> +typedef union {
> +  IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE
> *InterfaceSsifCapability;
> +  IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE
> *InterfaceKcsSmicCapability;
> +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_RESPONSE;
> +
>  //
>  //  Definitions for Get System Interface Capabilities command SSIF
> transaction support
>  //
> --
> 2.37.1.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109507): https://edk2.groups.io/g/devel/message/109507
Mute This Topic: https://groups.io/mt/101889077/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface Capabilities

[gaoliming via groups.io]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: abner.chang@amd.com <abner.chang@amd.com>
> 发送时间: 2023年10月10日 16:36
> 收件人: devel@edk2.groups.io
> 抄送: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Jian J Wang
> <jian.j.wang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> 主题: [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface
> Capabilities
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> Define the API for IPMI Get System Interface
> Capabilities command (0x57)
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  MdeModulePkg/Include/Library/IpmiCommandLib.h | 17
> +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/MdeModulePkg/Include/Library/IpmiCommandLib.h
> b/MdeModulePkg/Include/Library/IpmiCommandLib.h
> index 7edaf36cbe5..a84124c01e9 100644
> --- a/MdeModulePkg/Include/Library/IpmiCommandLib.h
> +++ b/MdeModulePkg/Include/Library/IpmiCommandLib.h
> @@ -249,6 +249,23 @@ IpmiGetChannelInfo (
>    OUT UINT32
> *GetChannelInfoResponseSize
>    );
> 
> +/**
> +  This function gets system interface capability
> +
> +  @param[in]  InterfaceCapabilityRequest    Get system interface
> capability request.
> +  @param[out] InterfaceCapabilityResponse   The response of system
> interface capability.
> +
> +  @retval EFI_SUCCESS            Command is sent successfully.
> +  @retval Other                  Failure.
> +
> +**/
> +EFI_STATUS
> +EFIAPI
> +IpmiGetSystemInterfaceCapability (
> +  IN  IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST
> *InterfaceCapabilityRequest,
> +  OUT IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_RESPONSE
> *InterfaceCapabilityResponse
> +  );
> +
>  //
>  // IPMI NetFnTransport
>  //
> --
> 2.37.1.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109508): https://edk2.groups.io/g/devel/message/109508
Mute This Topic: https://groups.io/mt/101889078/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface Capabilities

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Hi maintainers,
Please help to review this.

I also would like to propose myself and one more person as the maintainers of some manageability C header files under both MdePkg and MdeModulePkg. Such as Pldm, IPMI and etc.. How do you think?

Thanks
Abner

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Tuesday, October 10, 2023 4:36 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Jian J
> Wang <jian.j.wang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get
> System Interface Capabilities
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> From: Abner Chang <abner.chang@amd.com>
>
> Define the API for IPMI Get System Interface
> Capabilities command (0x57)
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  MdeModulePkg/Include/Library/IpmiCommandLib.h | 17
> +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/MdeModulePkg/Include/Library/IpmiCommandLib.h
> b/MdeModulePkg/Include/Library/IpmiCommandLib.h
> index 7edaf36cbe5..a84124c01e9 100644
> --- a/MdeModulePkg/Include/Library/IpmiCommandLib.h
> +++ b/MdeModulePkg/Include/Library/IpmiCommandLib.h
> @@ -249,6 +249,23 @@ IpmiGetChannelInfo (
>    OUT UINT32                          *GetChannelInfoResponseSize
>    );
>
> +/**
> +  This function gets system interface capability
> +
> +  @param[in]  InterfaceCapabilityRequest    Get system interface capability
> request.
> +  @param[out] InterfaceCapabilityResponse   The response of system
> interface capability.
> +
> +  @retval EFI_SUCCESS            Command is sent successfully.
> +  @retval Other                  Failure.
> +
> +**/
> +EFI_STATUS
> +EFIAPI
> +IpmiGetSystemInterfaceCapability (
> +  IN  IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST
> *InterfaceCapabilityRequest,
> +  OUT IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_RESPONSE
> *InterfaceCapabilityResponse
> +  );
> +
>  //
>  // IPMI NetFnTransport
>  //
> --
> 2.37.1.windows.1
>
>
>
> 
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109705): https://edk2.groups.io/g/devel/message/109705
Mute This Topic: https://groups.io/mt/102033872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface Capabilities

[Nickle Wang via groups.io]

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner
> via groups.io
> Sent: Tuesday, October 10, 2023 4:36 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Jian J Wang
> <jian.j.wang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get
> System Interface Capabilities
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> Define the API for IPMI Get System Interface
> Capabilities command (0x57)
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  MdeModulePkg/Include/Library/IpmiCommandLib.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/MdeModulePkg/Include/Library/IpmiCommandLib.h
> b/MdeModulePkg/Include/Library/IpmiCommandLib.h
> index 7edaf36cbe5..a84124c01e9 100644
> --- a/MdeModulePkg/Include/Library/IpmiCommandLib.h
> +++ b/MdeModulePkg/Include/Library/IpmiCommandLib.h
> @@ -249,6 +249,23 @@ IpmiGetChannelInfo (
>    OUT UINT32                          *GetChannelInfoResponseSize
>    );
> 
> +/**
> +  This function gets system interface capability
> +
> +  @param[in]  InterfaceCapabilityRequest    Get system interface capability
> request.
> +  @param[out] InterfaceCapabilityResponse   The response of system interface
> capability.
> +
> +  @retval EFI_SUCCESS            Command is sent successfully.
> +  @retval Other                  Failure.
> +
> +**/
> +EFI_STATUS
> +EFIAPI
> +IpmiGetSystemInterfaceCapability (
> +  IN  IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST
> *InterfaceCapabilityRequest,
> +  OUT IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_RESPONSE
> *InterfaceCapabilityResponse
> +  );
> +
>  //
>  // IPMI NetFnTransport
>  //
> --
> 2.37.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110093): https://edk2.groups.io/g/devel/message/110093
Mute This Topic: https://groups.io/mt/102198829/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-