From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 48B7C941566 for ; Wed, 11 Oct 2023 08:57:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mNELzOhgTHrxRLjk2AN9FHkpkNIgmyahxMI0UrU3ng8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697014660; v=1; b=wto5MUVjJAmc8hvj8RH8esdXqEdWBRaMr6lkQtvGXwzAUUURMvTZLr+8b+zf3/r5HzqgYz6N 0X+CWZkfrEPdF1CFlsvr5LyALSqvmbw4z+m22Uq2yvBk40tYTJeqn1kiowyOe164ilAlJMrACT2 +ygtfKsZNtPDTFbMRcQGVfsU= X-Received: by 127.0.0.2 with SMTP id GZ6LYY7687511xifnoc6bACo; Wed, 11 Oct 2023 01:57:40 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.12342.1697014659927073961 for ; Wed, 11 Oct 2023 01:57:40 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="387456242" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208";a="387456242" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 01:57:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="819611047" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208";a="819611047" X-Received: from shwdeopenlab705.ccr.corp.intel.com ([10.239.55.100]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 01:57:35 -0700 From: "Yuanhao Xie" To: devel@edk2.groups.io Cc: Yuanhao Xie , Eric Dong , Rahul Kumar , Gerd Hoffmann , Ray Ni Subject: [edk2-devel] [PATCH] UefiCpuPkg/CpuDxe: Eliminate the unused variable. Date: Wed, 11 Oct 2023 16:57:19 +0800 Message-Id: <20231011085719.1134-1-yuanhao.xie@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MSAyJmsLk6sF22qBxFZGYJRCx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wto5MUVj; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This change does not introduce any functional modifications. Recover the modification that was accidentally performanced during cherry-pick commit 1f78add. 1. Remove the unused variable. 2. reinstate the comment message. Signed-off-by: Yuanhao Xie Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ray Ni --- UefiCpuPkg/CpuDxe/CpuDxe.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c index c5ac624f9e..a6497c91fb 100644 --- a/UefiCpuPkg/CpuDxe/CpuDxe.c +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c @@ -15,15 +15,20 @@ // // Global Variables // -BOOLEAN InterruptState = FALSE; -EFI_HANDLE mCpuHandle = NULL; -BOOLEAN mIsFlushingGCD; -BOOLEAN mIsAllocatingPageTable = FALSE; -UINT64 mValidMtrrAddressMask; -UINT64 mValidMtrrBitsMask; -UINT64 mTimerPeriod = 0; -UINT32 mCpuTargetCState = 0; -EFI_CPU_ARCH_PROTOCOL gCpu = { +BOOLEAN InterruptState = FALSE; +EFI_HANDLE mCpuHandle = NULL; +BOOLEAN mIsFlushingGCD; +BOOLEAN mIsAllocatingPageTable = FALSE; +UINT64 mTimerPeriod = 0; +UINT32 mCpuTargetCState = 0; + +// +// A new writeble pagetable for non-smm. +// SystemMemory range is RW in this page table. +// +UINTN mWritablePageTable; + +EFI_CPU_ARCH_PROTOCOL gCpu = { CpuFlushCpuDataCache, CpuEnableInterrupt, CpuDisableInterrupt, -- 2.36.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109520): https://edk2.groups.io/g/devel/message/109520 Mute This Topic: https://groups.io/mt/101892967/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-