[edk2-devel] [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused variable.

[edk2-devel] [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused variable.

[Yuanhao Xie]

This change does not introduce any functional modifications.

Remove the unused mValidMtrrAddressMask and mValidMtrrBitsMask.

Reviewed-by: Ray Ni <ray.ni@intel.com>
Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 UefiCpuPkg/CpuDxe/CpuDxe.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
index c5ac624f9e..bf03978710 100644
--- a/UefiCpuPkg/CpuDxe/CpuDxe.c
+++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
@@ -15,15 +15,13 @@
 //
 // Global Variables
 //
-BOOLEAN                InterruptState = FALSE;
-EFI_HANDLE             mCpuHandle     = NULL;
-BOOLEAN                mIsFlushingGCD;
-BOOLEAN                mIsAllocatingPageTable = FALSE;
-UINT64                 mValidMtrrAddressMask;
-UINT64                 mValidMtrrBitsMask;
-UINT64                 mTimerPeriod     = 0;
-UINT32                 mCpuTargetCState = 0;
-EFI_CPU_ARCH_PROTOCOL  gCpu             = {
+BOOLEAN     InterruptState = FALSE;
+EFI_HANDLE  mCpuHandle     = NULL;
+BOOLEAN     mIsFlushingGCD;
+BOOLEAN     mIsAllocatingPageTable = FALSE;
+UINT64      mTimerPeriod           = 0;
+
+EFI_CPU_ARCH_PROTOCOL  gCpu = {
   CpuFlushCpuDataCache,
   CpuEnableInterrupt,
   CpuDisableInterrupt,
-- 
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109536): https://edk2.groups.io/g/devel/message/109536
Mute This Topic: https://groups.io/mt/101911140/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused variable.

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 2345 bytes --]

Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
________________________________
From: Xie, Yuanhao <yuanhao.xie@intel.com>
Sent: Thursday, October 12, 2023 10:22 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Xie, Yuanhao <yuanhao.xie@intel.com>; Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
Subject: [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused variable.

This change does not introduce any functional modifications.

Remove the unused mValidMtrrAddressMask and mValidMtrrBitsMask.

Reviewed-by: Ray Ni <ray.ni@intel.com>
Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 UefiCpuPkg/CpuDxe/CpuDxe.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
index c5ac624f9e..bf03978710 100644
--- a/UefiCpuPkg/CpuDxe/CpuDxe.c
+++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
@@ -15,15 +15,13 @@
 //
 // Global Variables
 //
-BOOLEAN                InterruptState = FALSE;
-EFI_HANDLE             mCpuHandle     = NULL;
-BOOLEAN                mIsFlushingGCD;
-BOOLEAN                mIsAllocatingPageTable = FALSE;
-UINT64                 mValidMtrrAddressMask;
-UINT64                 mValidMtrrBitsMask;
-UINT64                 mTimerPeriod     = 0;
-UINT32                 mCpuTargetCState = 0;
-EFI_CPU_ARCH_PROTOCOL  gCpu             = {
+BOOLEAN     InterruptState = FALSE;
+EFI_HANDLE  mCpuHandle     = NULL;
+BOOLEAN     mIsFlushingGCD;
+BOOLEAN     mIsAllocatingPageTable = FALSE;
+UINT64      mTimerPeriod           = 0;
+
+EFI_CPU_ARCH_PROTOCOL  gCpu = {
   CpuFlushCpuDataCache,
   CpuEnableInterrupt,
   CpuDisableInterrupt,
--
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109538): https://edk2.groups.io/g/devel/message/109538
Mute This Topic: https://groups.io/mt/101911140/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5262 bytes --]