From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 50535D8108F for ; Mon, 16 Oct 2023 13:18:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UmdtNgBhHjxN6IvnqDP6erJk4vG6gi2O0d1tdUsmmzk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697462311; v=1; b=CyWgCDPrm06IAVs+v+Sj0XDJmCvzF8kw4cuYiK+GFSoIjiZzzp87vbLSVlOaZXRnGMlUe1wj TbaGaqcnbb8b7kku5hae1+MDltp3+zS4kz3xbd7G//mV9uK/T8ztV+ONlW/2oyAoUa8EvntpY8D gwwGfO0+0gZYmzhFt29+gTqk= X-Received: by 127.0.0.2 with SMTP id AMf6YY7687511x9xxAhorQqJ; Mon, 16 Oct 2023 06:18:31 -0700 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web11.123866.1697462309013277007 for ; Mon, 16 Oct 2023 06:18:29 -0700 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c17de836fbso53876031fa.1 for ; Mon, 16 Oct 2023 06:18:28 -0700 (PDT) X-Gm-Message-State: p6762UdMaKC3kIv9Dh31Oswgx7686176AA= X-Google-Smtp-Source: AGHT+IHzvLVCvJ2cUZqR1c5Gig8UZqGYuNUfKPXgoyChuvH2JuERK+KfyTw2nEsXROdXUt9IZUF5pw== X-Received: by 2002:a2e:a552:0:b0:2c5:13e8:e6d5 with SMTP id e18-20020a2ea552000000b002c513e8e6d5mr4946518ljn.23.1697462306910; Mon, 16 Oct 2023 06:18:26 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id 9-20020a2e1449000000b002ba586d27a2sm1362545lju.26.2023.10.16.06.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 06:18:26 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, isaac.w.oram@intel.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms 10/10] ManageabilityPkg: Return error on multiple-packet MCTP responses Date: Mon, 16 Oct 2023 16:18:16 +0300 Message-Id: <20231016131816.6634-11-aladyshev22@gmail.com> In-Reply-To: <20231016131816.6634-1-aladyshev22@gmail.com> References: <20231016131816.6634-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CyWgCDPr; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Since the current driver doesn't yet support handling of multiple-packet MCTP responses, return EFI_UNSUPPORTED error in such cases. Signed-off-by: Konstantin Aladyshev --- .../MctpProtocol/Common/MctpProtocolCommon.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index 4aae4fcba9..7cf2d916f4 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -524,6 +524,17 @@ CommonMctpSubmitMessage ( FreePool (ResponseBuffer);=0D return EFI_DEVICE_ERROR;=0D }=0D + if ((MctpTransportResponseHeader->Bits.StartOfMessage !=3D 1) ||=0D + (MctpTransportResponseHeader->Bits.EndOfMessage !=3D 1) ||=0D + (MctpTransportResponseHeader->Bits.PacketSequence !=3D 0)) {=0D + DEBUG ((=0D + DEBUG_ERROR,=0D + "%a: Error! Multiple-packet MCTP responses are not supported by the = current driver\n",=0D + __func__,=0D + ));=0D + FreePool (ResponseBuffer);=0D + return EFI_UNSUPPORTED;=0D + }=0D =0D MctpMessageResponseHeader =3D (MCTP_MESSAGE_HEADER *)(MctpTransportRespo= nseHeader + 1);=0D if (MctpMessageResponseHeader->Bits.MessageType !=3D MctpType) {=0D --=20 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109643): https://edk2.groups.io/g/devel/message/109643 Mute This Topic: https://groups.io/mt/101994949/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-