From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 91AE8941963 for ; Mon, 16 Oct 2023 20:13:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7pnH/ErxCnB94FntEZ0zb5W6dEd/pWBOqzDKWkrdgKs=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697487200; v=1; b=TIv90tmurVCFw4LZ7gsvSXOo0wzBtmhXrduZ3hA5v68e6uJCsnkWBqX3Gd9X4uQ19SmGZc82 52t9YBWfHBzILXbxKkdVr8z7liFLAm0dy8961I0igJYZU/Hgv1bQ1phwAvOVQqALb8Y1d60zYie 8EX4gSDJHrDYne+3fpb908y8= X-Received: by 127.0.0.2 with SMTP id ZYR0YY7687511x6n7eh3s4EZ; Mon, 16 Oct 2023 13:13:20 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.178913.1697487199840174099 for ; Mon, 16 Oct 2023 13:13:19 -0700 X-Received: from localhost.localdomain (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id E0BFB20B74C3; Mon, 16 Oct 2023 13:13:18 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E0BFB20B74C3 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sean Brogan , Michael D Kinney , Liming Gao Subject: [edk2-devel] [PATCH v2 6/7] .pytool/CISettings: Enable CodeQL audit mode Date: Mon, 16 Oct 2023 16:12:37 -0400 Message-ID: <20231016201239.953-7-mikuback@linux.microsoft.com> In-Reply-To: <20231016201239.953-1-mikuback@linux.microsoft.com> References: <20231016201239.953-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YEVUSPn9RYcGC3xXJmyR0tZrx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TIv90tmu; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Michael Kubacki Since a large number of CodeQL queries are being enabled to identify issues that the community can collectively resolve, audit mode needs to be enabled to prevent the build from failing. In the future, this global audit mode can be disabled and individual packages can enable/disable audit mode in their package CI YAML file using the instructions in the CodeQL plugin readme. Cc: Sean Brogan Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Michael Kubacki --- .pytool/CISettings.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index b8b8080439c1..ec3beb0dcf9d 100644 --- a/.pytool/CISettings.py +++ b/.pytool/CISettings.py @@ -196,6 +196,12 @@ class Settings(CiBuildSettingsManager, UpdateSetting= sManager, SetupSettingsManag =20 try: scopes +=3D codeql_helpers.get_scopes(self.codeql) + + if self.codeql: + shell_environment.GetBuildVars().SetValue( + "STUART_CODEQL_AUDIT_ONLY", + "TRUE", + "Set in CISettings.py") except NameError: pass =20 --=20 2.42.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109652): https://edk2.groups.io/g/devel/message/109652 Mute This Topic: https://groups.io/mt/102004570/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-