From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 55551D81120 for ; Mon, 23 Oct 2023 13:05:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8cLGlta4E3RZ9XRyx0nq3MdWkuWOe7NCJzgDwXd5fbA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698066325; v=1; b=pWG/9+bkHMeaP2QJsgH4lm9WJUt8NS8dD3XCHmmGaAbPdefdV0fFweLOS+CvNcdTBNmGG32g taZRsAkRp4ymhKDAnsG83tFhraddmpAZqboVYU1j22Yl2D2MHG5Q638jwt3Z0ib0DVpHXSSD8D6 6PSuxIrxZFFulVsO3XsiSXBM= X-Received: by 127.0.0.2 with SMTP id SEoDYY7687511xPQpiDsXAn2; Mon, 23 Oct 2023 06:05:25 -0700 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web10.119846.1698066323289932092 for ; Mon, 23 Oct 2023 06:05:23 -0700 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c5056059e0so49518691fa.3 for ; Mon, 23 Oct 2023 06:05:23 -0700 (PDT) X-Gm-Message-State: Zrtzgj6XLKDvPgP1SYcy1bWrx7686176AA= X-Google-Smtp-Source: AGHT+IGSfsWY5jIljmVs7MsrSlvIDkcYNQOlcLCM8uak25AItsGfDUm3DtXUMeW3rq0TBD1uRirKtw== X-Received: by 2002:a05:651c:1409:b0:2c5:1d11:5688 with SMTP id u9-20020a05651c140900b002c51d115688mr6044569lje.14.1698066321049; Mon, 23 Oct 2023 06:05:21 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id r11-20020a2e994b000000b002b9e0d19644sm1550081ljj.106.2023.10.23.06.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 06:05:20 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v3 07/16] ManageabilityPkg: Correct value for the MCTP TAG_OWNER response bit Date: Mon, 23 Oct 2023 16:05:02 +0300 Message-Id: <20231023130511.4521-8-aladyshev22@gmail.com> In-Reply-To: <20231023130511.4521-1-aladyshev22@gmail.com> References: <20231023130511.4521-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="pWG/9+bk"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Currently the MCTP TAG_OWNER bit is checked against 1 both in MTCP request and response. According to the MTCP Base specification in case of the MCTP response the TAG_OWNER bit should be equal to 0. Correct MCTP_MESSAGE_TAG_OWNER_RESPONSE flag value to fix the issue. Signed-off-by: Konstantin Aladyshev --- .../Include/Library/ManageabilityTransportMctpLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Features/ManageabilityPkg/Include/Library/ManageabilityTranspo= rtMctpLib.h b/Features/ManageabilityPkg/Include/Library/ManageabilityTransp= ortMctpLib.h index 462e7436e6..a8dc8a8519 100644 --- a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpL= ib.h +++ b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpL= ib.h @@ -51,8 +51,8 @@ typedef struct { // is not defined by the specification.=0D #define MCTP_MESSAGE_TAG 0x1=0D =0D -#define MCTP_MESSAGE_TAG_OWNER_REQUEST 0x01=0D -#define MCTP_MESSAGE_TAG_OWNER_RESPONSE 0x01=0D +#define MCTP_MESSAGE_TAG_OWNER_REQUEST 1=0D +#define MCTP_MESSAGE_TAG_OWNER_RESPONSE 0=0D =0D #define MCTP_PACKET_SEQUENCE_MASK 0x3=0D =0D --=20 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109915): https://edk2.groups.io/g/devel/message/109915 Mute This Topic: https://groups.io/mt/102134655/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-